Commit Graph

6363 Commits

Author SHA1 Message Date
Konstantina Chremmou
acc5ed0210 CP-38542: Remove option to disable live patching.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:17:22 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page:
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:07:43 +01:00
Konstantina Chremmou
ef86be5347
Merge pull request #2978 from kc284/actions
Compacted ParallelAction and MultipleAction constructors.
2022-04-01 16:07:30 +01:00
Danilo Del Busso
7a3fe5ddee CA-334613: Clip region within which performance graph lines are drawn
Sharp turns in the graph can result in the line being drawn outside of the box.
This change makes sure the line is only rendered within the input rectangle.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-01 15:41:04 +01:00
Konstantina Chremmou
51a400bf70 CA-365717: Two corrections on VM import (from XVA):
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 11:21:41 +01:00
Danilo Del Busso
05ba1ce8a0
CA-322672: Partly tidy up VNCTabView.cs
Apply some naming and styling conventions. Specifically, remove useless usages of `this.`, use arrow syntax for RDP fields, and remove redundant bool field initialisation

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-03-29 15:46:31 +01:00
Danilo Del Busso
1d98a298f5
CA-322672: Partly tidy up XSVNCScreen.cs
Apply some naming and styling conventions.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-03-29 15:41:06 +01:00
Danilo Del Busso
c5d2e36564
CA-322672: Do not stop polling for RDP capabilities on VMs
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-03-29 15:34:09 +01:00
Konstantina Chremmou
81d5c508a1 Refactoring suggested by code review (largely naming conventions).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-28 13:43:24 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:50:27 +00:00
Konstantina Chremmou
f5672a8645 CP-39323: Check for DMC in use prior to cross-pool migration to pools where DMC is unavailable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
dd978914cf CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
2110607cc1 CA-365143: Correction when changing a VM's memory settings:
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:40 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:25 +00:00
Konstantina Chremmou
3453e84a0f CA-365223: PVS accelerator is now part of the main install.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:33:03 +00:00
Konstantina Chremmou
ab676786b1 CP-39366: Disallow connection to servers earlier than yangtze.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:48 +00:00
Konstantina Chremmou
713bec52ce CA-365082: Do not run the PrepareToUpgradeCheck before the necessary RPU hotfix has been applied.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:29 +00:00
Konstantina Chremmou
25760b2bc6 CP-38814: Minor message improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:11 +00:00
Konstantina Chremmou
eb58973497 Fixed crash when retrieving pool info from DR metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:48 +00:00
Konstantina Chremmou
545d85d433 CA-364273: Do not log out the current user if they cancel the operation from the elevated session dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:31 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-02-24 11:53:31 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Konstantina Chremmou
a342adc859 CA-364152: Do not calculate completed percentage if there are no actions to run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Danilo Del Busso
a578b6924c CA-361078: Parse OVFs without a Limit element in the vCPUs section
VMWare OVFs don't export the value

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-18 10:28:38 +00:00
Konstantina Chremmou
8493ee5e90 CA-363819: Fixed issue where VM network usage data were not shown on the Search TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
29189873a3 CA-363610: OVF import: fixed upload of OS fixup ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
df6f1ba65b CP-38832: Bumped branding library version to v4.2.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:49 +00:00
Konstantina Chremmou
edfcf036d2 CP-38832: Try again bumping xencenter-pipeline to v4.3.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:59 +00:00
Konstantina Chremmou
7771471522 Use Write-Host when we just want to log output on the console.
Write-Output passes data further down the pipeline.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:59 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
9af52bdcbf CP-39053: Bumped branding library version to v4.1.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-09 11:25:50 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool.
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
c506c5e47c Reverted pipeline library to v4.2.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-28 14:19:34 +00:00
Konstantina Chremmou
713a61cead Updated C# SDK (xapi 22.5.0-1.xs8).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-28 14:19:34 +00:00
Konstantina Chremmou
1580a89594
Merge pull request #2931 from kc284/settings
Minor refactoring; null check; tidy up
2022-01-27 13:34:20 +00:00
Konstantina Chremmou
bae03aff8b Fixed issue where the settings from previous installations were not imported. Added more documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 19:55:38 +00:00
Danilo Del Busso
2bc25d72d5 CP-38814: Add friendly names to new xapi alerts
vm_migrated
vm_snapshotted
vm_snapshot_reverted
vm_checkpointed
vm_paused
vm_unpaused

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Danilo Del Busso
d7f1853562 Bump C# SDK to modified version of xapi 21.3.0/1.xs8
SDK update does not contain the removal of `evacuate` overloads

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Danilo Del Busso
7f38f71a6e CP-38832: Bump xencenter-pipeline to v4.3
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:23:40 +00:00