Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-24 22:06:59 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,363 Commits 11 Branches 48 Tags 186 MiB
a1a577fa22
Commit Graph

6363 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
a1a577fa22 Removed field thinCliProtocol.dProgress because it was not implemented. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
c226316632 Replaced field thinCliProtocol.dExit with direct call to Environment.Exit(). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
b343a97b72 Replaced field thinCliProtocol.dConsoleReadLine with direct call to Console.ReadLine(). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
c992c4b171 Replaced field thinCliProtocol.dConsoleWriteLine with method Logger.Info() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
e31cfaeda5 Removed field thinCliProtocol.dConsoleWrite. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
2bbebce05f Replaced field thinCliProtocol.dGlobalDebugstatic method Logger.Debug() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
0abef1f9ca Replaced field thinCliProtocol.dGlobalUsagewith static method Logger.Usage() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
e2ded395ee Replaced field thinCliProtocol.dGlobalError with static method Logger.Error() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
113dab51d5 Moved CommandLib classes used only by Xe to the latter project where they belong. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
d0fdc5360b
Merge pull request #2980 from danilo-delbusso/bug/rdp-gray_CA-322672 
CA-322672: Do not stop polling for RDP capabilities on VMs
 2022-05-09 15:15:39 +01:00
Konstantina Chremmou
938de8dcb7 CA-311156: Select the home node prior to starting restoring sessions. 
Because if these are protected by a master password, the application shows
all tabs it constructed with while the password dialog is open.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:38:25 +01:00
Konstantina Chremmou
b172cd0785 Removed private field ToolbarsEnabled: 
It's not worth increasing the complexity of the already complex main form
in order to avoid repeating the setting's name.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:38:25 +01:00
Konstantina Chremmou
404ee1680a Tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
ae7df535c2 Some layout and logic changes so the page looks and behaves more like the other wizard pages with progress bars. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
9b7d502e74 CA-329538: Tell the user to ensure tools are installed if a VM cannot be migrated via drag-and-drop. 
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:16 +01:00
Konstantina Chremmou
6f3895ff10 Minor refactoring: 
Use C# naming conventions; merged nested if blocks; use pattern matching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
429341cdca
Merge pull request #2992 from kc284/console 
Port PR#2941 to master
 2022-04-25 17:06:35 +01:00
Konstantina Chremmou
4496d4571d CA-365905 (XSI-1215): Create a temporary file in the target download folder if the latter is in a different drive from the default temporary folder. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:17 +01:00
Konstantina Chremmou
1928cf3db7 CA-366139: Specify which VM lacking the feature could not be migrated during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:01 +01:00
Konstantina Chremmou
2908547411 Added code owners (default reviewers). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:05:37 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-22 14:32:14 +01:00
Konstantina Chremmou
efb855a6e9 Modifications around VncView disposal: 
- Do not dispose of the activeView when pausing the console (which happens
  when we move away from the console tab.
- When setting a new source, remove and re-add the activeView only when
  it has changed.
- Dispose an unneeded view immediately instead of starting a timer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
5453c0c2ca Corrected toggling console paused state when selecting/deselecting the console tabs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
456cd93db8 A VncView is created for both VNC and RDP, so I don't see why it should be disposed of for VNC only. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
0c1541985c Check for docking should happen outside the VncView's Pause() method. 
Also, use Pascal case for property name to match C# conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
3601ada1f6 Reduced the public interface of the console panel. 
Methods exposing internal functionality like the timers should not be public.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Konstantina Chremmou
4d7457c331 The console panel is not meant to come in focus when the user navigates on the treeview. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Konstantina Chremmou
63c170310d Use Pascal case for method names to match C# conventions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Danilo Del Busso
d17b99e6b0
CA-322672: Improve comments around RDP status checks 
`data/ts` indicates the VM has RDP enabled

`feature-ts2` is the feature flag indicating that `data/ts` is valid.

`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)

the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-20 12:39:47 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube 
CP-36392: Improvement of sonarqube score
 2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-14 11:45:21 +01:00
Danilo Del Busso
38043403b9 Update MAINTAINERS 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-14 11:37:23 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986) 
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-14 11:36:55 +01:00
Konstantina Chremmou
07f2de6786 Use C# naming conventions. Removed some code redundancies. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-12 10:32:57 +01:00
Konstantina Chremmou
9e8a8a77a5 Code style fixes. Removal of unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 22:57:08 +01:00
Konstantina Chremmou
558897740d Reworked instantiation of dummy actions that complete immediately. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 19:43:09 +01:00
Konstantina Chremmou
a35efa06aa CP-36392: Removed unnecessary statement: 
The body of the setter never proceeds before the first line because value==_state
and the child's level has just been increased and is zero or greater.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:35 +01:00
Konstantina Chremmou
04ac8249a6 CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:35 +01:00
Konstantina Chremmou
d2548ae4c0 CP-36392: Do not create an action for changing the master password. 
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:34 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:34 +01:00
Konstantina Chremmou
84ad7054ea Compacted the ActionBase constructors and renamed file to match the class name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
758a60f3f8 Converted interface HistoryItem to an abstract class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method. 
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
177c47f79f CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
b3bc93f1f6 CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 
Also, removed some unused GridRow class members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
c28bb4b34c CP-36392: Removed block that is never hit: 
The situation described in the comment is not applicable as scaling does
not change outside the UI thread, and OnResize() does call SetupScaling().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:32 +01:00
Konstantina Chremmou
3c4808a689 Remove redundant code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-05 10:19:13 +01:00
Konstantina Chremmou
492cd4dc88 CP-36392: Do not use a loop for only one iteration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-04 21:07:09 +01:00