Commit Graph

2474 Commits

Author SHA1 Message Date
Konstantina Chremmou
a342adc859 CA-364152: Do not calculate completed percentage if there are no actions to run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Danilo Del Busso
a578b6924c CA-361078: Parse OVFs without a Limit element in the vCPUs section
VMWare OVFs don't export the value

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-18 10:28:38 +00:00
Konstantina Chremmou
8493ee5e90 CA-363819: Fixed issue where VM network usage data were not shown on the Search TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
29189873a3 CA-363610: OVF import: fixed upload of OS fixup ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool.
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
713a61cead Updated C# SDK (xapi 22.5.0-1.xs8).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-28 14:19:34 +00:00
Danilo Del Busso
2bc25d72d5 CP-38814: Add friendly names to new xapi alerts
vm_migrated
vm_snapshotted
vm_snapshot_reverted
vm_checkpointed
vm_paused
vm_unpaused

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Danilo Del Busso
d7f1853562 Bump C# SDK to modified version of xapi 21.3.0/1.xs8
SDK update does not contain the removal of `evacuate` overloads

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Konstantina Chremmou
8f9afafb7a Use Tick() when setting both the PercentComplete and the Description to avoid firing OnChanged() twice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Konstantina Chremmou
1225e98225 Improved logging and reporting percentage when importing an XVA.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483
CP-38483: Unbundle putty from  Citrix Hypervisor Center
2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc CA-362354: Account for non-exe files when saving SSH client path
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-17 14:09:34 +00:00
Konstantina Chremmou
1e1bb8ddcd Retry sorting .resx strings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-10 14:39:38 +00:00
Darren Matthews
95667d3c80 L10N : Translations
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-01-10 10:13:24 +00:00
Konstantina Chremmou
e129b0b321 Revert "Sort .resx strings"
This reverts commit 0536fdc05a.
2022-01-10 10:12:30 +00:00
Danilo Del Busso
0536fdc05a Sort .resx strings
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-10 09:53:58 +00:00
Konstantina Chremmou
879191424c Added hotkeys. Corrected tab indices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-06 10:50:13 +00:00
Danilo Del Busso
c58d066389 CP-38529: Order strings in Messages.resx alphabetically
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-06 10:50:13 +00:00
Danilo Del Busso
c6eedbc9f3 CP-38529: Add ssh client strings to Messages.resx
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-06 10:50:13 +00:00
Danilo Del Busso
41be442413 CP-38529: Add SshConsole enum
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-06 10:50:13 +00:00
Darren Matthews
702ce7ce0f L10N : Resx resync and Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-01-05 11:38:40 +00:00
Danilo Del Busso
48dd60486a
Merge pull request #2889 from danilo-delbusso/CA-359124
CA-359124 & CA-360426: Add snapshot VIFs to mapping during cross pool migration & fix VIF mapping in cross pool migration
2022-01-05 12:13:40 +01:00
Danilo Del Busso
d33f90aaf3
CA-361078: vCPUs count isn't exported/imported within OVFs (#2913)
* CA-361078: Export max vCPUs when generating OVF

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Populate max vCPUs when importing OVFs

Also keeps backwards compatibility with old import

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Tidy up `SetCPUs` method in `OVF.cs`

Also fixes whitespace using automatic formatter in VS2019

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-04 10:56:16 +00:00
Konstantina Chremmou
f6db9820a1 Retrieve VM snapshots from the cache instead of making an API call to the server.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-12-23 16:40:05 +01:00
Danilo Del Busso
18595759f7 CA-362018: Improve update notification dismissal message
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-22 12:15:08 +01:00
Danilo Del Busso
16d7f74158
CP-36392: Misc fixes to flagged Bugs (#2907)
* CP-36392: Add several `null` checks

All were flagged by SonarQube

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `SettingsUpdate`

Added to `XenAdmin`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Collapse useless condition check

Also use pattern matching for type cast

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `ProduceConsumerQueue`

Add to `XenAdmin.Actions`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Add explicit `null` check

While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Replace useless self-assignment with ad-hoc method

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Fix minor formatting issues

Add newline at end of file, and reformat content of if statement

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up latest flagged bugs changes

- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up setter in `ChangeableList.cs`

Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-21 15:53:46 +00:00
Konstantina Chremmou
4a6b2b1e1b
CA-343229: Some modifications:
- Fixed issue whereby logging out the current user did not log out other
  sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-12-17 11:08:31 +00:00
Danilo Del Busso
53bf485a14
Replace negative term with log(ging) out user
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-17 11:06:56 +00:00
Danilo Del Busso
4fe544a8e0
CA-343229: Add Helper function to fetch list of logged in subjects
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-17 11:06:53 +00:00
Danilo Del Busso
f7527534e5
CA-343229: Update messages for roles update and user logout
- Add options for multiple users/subjects
- Let user know they'll also be disconnecting other users

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-17 10:58:49 +00:00
Konstantina Chremmou
c19fb06bf7 CP-38473: Block RPU if the pool has hosts with certificate key length less than 2048
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-12-16 11:34:23 +00:00
Danilo Del Busso
e169f0bfcc
Amend indentation in changes for CA-359124 & CA-360426
Refactor all tabs into 4x spaces

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-14 13:29:31 +00:00
Danilo Del Busso
7e007cd6ef
CA-360426: Fix VIF to Network mapping during cross pool migration
Amend mapping so it reflects xapi calls, keeping VIF -> Network mapping and removing Network -> Network mapping

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-14 13:27:22 +00:00
Danilo Del Busso
bee0b881d4
CA-359124: Add snapshot VIFs to mapping during cross pool migration
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Add VM snapshots VIFs to network mapping wizard page

This is not entirely necessary, since the mapping in the background is actually Network -> Network.
However, this is closer to the intent of the page.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Tidy up methods in `VmCrossPoolMigrateACtion.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-14 13:25:58 +00:00
Konstantina Chremmou
a0a706e9bb Merge branch 'master' into vm-copy-credentials_CA-359712
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/ImportWizard/ImportWizard.cs
#	XenModel/Actions/VM/VMCopyAction.cs
2021-12-02 22:14:48 +00:00
Konstantina Chremmou
cace3036cf
Merge pull request #2854 from danilo-delbusso/CA-339273
CA-339273: Add source server/pool info to descriptions of actions that move/copy/import resources
2021-12-02 21:01:20 +00:00
Konstantina Chremmou
2af5758424
Merge pull request #2842 from danilo-delbusso/master
CA-350411: Add conditional page control refresh in Import Wizard
2021-12-02 21:01:00 +00:00
Konstantina Chremmou
e9fa5674c3 CA-339273: Some corrections and minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-12-02 11:20:49 +00:00
Konstantina Chremmou
eef4e5f995 CP-38427 issue 1: Do not allow enabling TLS verification during RPU.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-11-30 22:46:43 +00:00
Konstantina Chremmou
051c205899 CA-350411 part 2: Add conditional page control refresh in Import Wizard
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-11-24 15:35:00 +00:00
Konstantina Chremmou
a327390e4a Further refactoring of CopyVM- and CopyTemplateCommand to reduce repetitive code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-11-24 09:58:43 +00:00
Konstantina Chremmou
e265e86cfa Refactored and renamed class WizardPermission and the code areas using it. Corrections to RBAC messages. Sorted Messages.resx.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-11-24 09:58:43 +00:00