Commit Graph

5973 Commits

Author SHA1 Message Date
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-17 15:30:59 +00:00
Konstantina Chremmou
f05b16eff7 Do not use the task description as the AsyncAction description because in most cases it is not localised.
Also, do not poll if the RelatedTask is null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-16 10:27:55 +00:00
Konstantina Chremmou
47d9146ce3 CA-352455: Parse the task result as xml document instead of using a regex.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-16 10:27:55 +00:00
Mihaela Stoica
96956dbc81 CA-352663: Fix button action on Custom Field deletion confirmation dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-16 00:13:06 +00:00
Edwin Török
eaf6bb7507 Update DEFAULT_NUM_VBDS_ALLOWED to 255
All currently supported versions of the product support 255 VBDs,
see https://docs.citrix.com/en-us/xenserver/7-0/downloads/config-limits.pdf

When a VM is imported through XCM it may not have recommendations,
and XenCenter falls back to the default, which is 16.
Then adding another disk shows an error that the maximum number of disks was reached,
which contradicts our support statement of 255 disks.

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
2021-03-16 00:12:50 +00:00
Konstantina Chremmou
6e5cb325f3 CP-35899, CP-36202: Show the driver domain console tab on the corresponding SR.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Konstantina Chremmou
29f3f9cd33 CP-35898: Do not show SMAPIv3 SRs as of unknown type if the type can be inferred from the SM plugin.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Konstantina Chremmou
a109f5f22d Pascal-cased method name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Darren Matthews
a8988276be L10n : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2021-03-02 09:44:29 +00:00
Konstantina Chremmou
97c92e918d CP-34402: Calculate sha256 checksum for deliverables.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-24 23:21:41 +00:00
Konstantina Chremmou
5e76a3cae8 CA-352022: Fixed broken retrieval of polling result.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-18 10:33:18 +00:00
Konstantina Chremmou
f40bf2019b Restored branding.sh for local build.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-17 14:45:36 +00:00
Konstantina Chremmou
abd6b41926 Fixed Next button state when re-landing on the page. Usability enhancements.
Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-17 11:56:12 +00:00
Konstantina Chremmou
d1f73a6ba0 Added pacman library.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-16 10:07:46 +00:00
Konstantina Chremmou
e63e288be7 Build script modifications for the new build node.
- Alternative MSBuild path.
- Removed obsolete instruction.
- Suppress ICE validation temporarily.
- Create zip instead of tar archives.
- Ignore test temporarily.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-16 10:07:46 +00:00
Konstantina Chremmou
f852167ad1 Created re-usable project target to add manifest to an assembly. Be specific about the mt executable to use.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-16 10:07:46 +00:00
Konstantina Chremmou
eb3662aa88 CA-345342: Cope with optional parameters in the HTTP_actions.
- Removed wrapper delegates; call the http_actions directly.
- In case of failure or cancellation of the http_action, poll the related task
  ignoring any exceptions thrown, so that any clean up code within the http_action's exception handling can run.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
bc92cf793d Removed class TaskPoller and moved its code to AsyncAction.
This simplifies the code since the TaskPoller cannot be perceived without an AsyncAction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
145483b193 Minor corrections on Task extensions:
- Stop rethrowing exceptions.
- Added some checks.
- Renamed method XenCenterUUID to GetXenCenterUUID to match the methods
  SetXenCenterUUID and RemoveXenCenterUUID.
- Replaced check via static string list with a string switch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
b0eafcf1d1 Code design issue: do not override DestroyTask. Minor refactoring in VMSnapshotCreateAction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed.
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
4cf37879ec Made ShowConfirmationDialog private as in the one case it was accessed by the inheriting class it was not making the code simpler.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
0d10e1e53f Replaced own method ConvertToSelection<T>() with Linq queries.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
db89699bac Removed method SetParent. Use a setter for the property Parent instead. Property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
ab59bf22d0 Code design: removed unnecessary base class for Patching and RPU wizards.
Not sure why I had added that since the containing protected method is probably
more relevant as a static method in the Problem class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-08 17:20:05 +00:00
Konstantina Chremmou
75cec4dd67 Removed dependency on server side branding. Made the pipeline steps internal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-26 12:31:31 +00:00
Konstantina Chremmou
71a5712647
Merge pull request #2764 from xenserver/feature/REQ-797
Merge feature/REQ-797 into master
2021-01-20 10:13:46 +00:00
Konstantina Chremmou
fee6e3942c
Merge pull request #2766 from kc284/feature/REQ-797
Merge master into feature/REQ-797
2021-01-19 11:34:04 +00:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Konstantina Chremmou
75f9127e27 Move files to a better location.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-19 10:37:35 +00:00
Vetrivel Chinnasamy
78033c8186 CA-350227: L10N- Translation Updates 2021-01-15 11:54:48 +00:00
Konstantina Chremmou
be010e1c39 CA-350406: Exclude the Tools SR when plugging PBDs after a host reboot during an update process.
Also, try plugging PBDs only for the host in question (other hosts are not necessary,
as the PBDs are re-checked for any previously evacuated VMs before repatriation).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-12 12:15:12 +00:00
Konstantina Chremmou
9a5c664eb0 CA-350574: Corrections to signing an appliance.
Also, removed listing of CryptoServiceProviders from the settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-12 12:14:31 +00:00
Konstantina Chremmou
90e6cb0dc9 Memory leak when disposing of the RdpControl.
The rdpControl was set to null too soon and by the time the timer ticked it had
no chance to be disposed of at all. Also, the timer itself was not disposed of.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-06 11:28:32 +00:00
Konstantina Chremmou
bbad0e5cf8 Disable schema validation as it shows false warnings for multiple VM appliances.
It thinks that the element VirtualSystem is an invalid child element of
VirtualSystemCollection, which is not the case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-04 16:23:11 +00:00
Konstantina Chremmou
501cca2ffb CA-350410: Ensure we set the certificate before checking it's null.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-04 16:23:11 +00:00
Konstantina Chremmou
542a329a27 Fixed failure to start a VM after it was imported as an XVA package.
Regression introduced by the changes for CA-64500. Since we initiate a VMStartAction
we need to ensure that the VM object passed to the action has a non-null Connection.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
0b0d6973ba CA-348139: Don't exclude zero bytes from the checksum calculation during manifest verification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
3f5b11048f CA-349855: Reworked the disk validation to prevent false warnings about missing disk linkages.
Also, removed the known file extensions from the Settings because they are not
user or application settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1d332ba0b0 CA-347483: Silence exception thrown when disposing compression or tar stream if the user has requested cancellation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file.
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
e325548a75 CA-349836: Reworked handling of manifest and signature for appliance import/export.
- Moved the code to the ExportApplianceAction so it's easier to modify the
  action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
  OVF package was ignored.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
8d004401fb CA-343280: Removed metadata entry.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
6286f96cb1 CA-343280: Extended proxy authentication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
f73ea42cb2 CA-343280: Reworked saving user settings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
28c0f1d62a Tweaked the column autosize mode on the SelectNetwork page. 2020-12-07 15:57:00 +00:00
Konstantina Chremmou
3e0d982631 CA-347849: No need to keep track of the VIF.device numbers across all VMs of the imported appliance.
Reset to 0 for each VM.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:00 +00:00
Konstantina Chremmou
84d0a2b8ae Bad application of the code reusability principle in VMDestroyAction.
Destroying a VM does not disrupt the connection, hence the use of the BestEffort
method is not warranted. After this correction, BestEffort is only used in the
DestroyedBondAction, hence I removed it completely and replaced it with simpler
exception handling in the latter class's Run method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-03 14:56:11 +00:00
Konstantina Chremmou
94024f99a9 CA-347481: Clean up the disks of the destroyed VM if import is interrupted due to cancellation or failure.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-03 14:55:38 +00:00
Konstantina Chremmou
7e6064eeb1 CP-35343: Fixed broken build.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-01 12:37:46 +00:00