Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-22 00:00:40 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,961 Commits 12 Branches 48 Tags 186 MiB
abd6b41926
Commit Graph

3738 Commits

Author SHA1 Message Date
Konstantina Chremmou
4949109bf8 CA-337323: SR.scan should be added to the method list of the Import wizard's RBAC page 
Otherwise it is evaluated independently and launches the RoleElevation dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also: 
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
8d6686b63f CA-337280: Creation of GFS2 SRs with CHAP authentication is not supported. 
This is also a better fix for CA-335356.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard 
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5b6bd343dd CA-322705: Disallow re-attaching GFS2 SR if clustering is not enabled. Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
fd497a1370 Added outlook style status labels showing the number of various types of notifications. 
The labels are additionally clickable and navigate to the corresponding panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-30 08:30:30 +01:00
Konstantina Chremmou
0fa374313f Corrected dialog title. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-30 08:30:30 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
 2020-04-29 16:47:48 +01:00
Konstantina Chremmou
436ffe4a37 CA-338003: The action's Sessions is set once the action has started to run. Added missing help references. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-27 10:36:51 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
 2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests. 
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
 2020-04-24 15:37:01 +01:00
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats. 
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-24 14:30:32 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching 
Merge feature/read-caching branch to master
 2020-04-24 11:47:26 +01:00
Konstantina Chremmou
ec86bb39dc Fixed broken build. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 22:44:17 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627) 
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 14:47:03 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 10:33:22 +01:00
Konstantina Chremmou
0ffccc6d03 CA-338184: Check for null before accessing host properties. 
Also, property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-21 10:38:15 +01:00
Konstantina Chremmou
fda52da475 Adjusted margins; made label bold because the current server state was not very obvious. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 19:07:31 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 19:07:31 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811 
Merge feature/REQ-811 into master
 2020-04-20 18:39:37 +01:00
Konstantina Chremmou
f31a8f2085 Some refactoring to memory editing controls. 
Override the polymorphic methods of XenTabPage on the ballooning wizard;
No need to exposed the memory values outside the VMMemoryControlsEdit class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards. 
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
456978e572 CP-32688: Remove guest tools from DVD ISO dropdown for Stockholm onwards 
Also, removed properties that were never set to true.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Mihaela Stoica
66d192b1d8 CP-32985: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-15 14:30:00 +01:00
Darren Matthews
bb560db1dc L10N : Resx resync and translation update 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-04-08 15:56:46 +01:00
Konstantina Chremmou
0188fdc69b Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64 Try handling a connection interruption. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
79bebdb816 Parse the certificate alert body as xml. Accept more ISO 8086 formats. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d CP-32699: New dialog for certificate installation on a server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
f0f8f90875 Dispose of X509Certificate2 objects. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
52369c9d0d Removed references to SSL certificates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
73a7903ddf Move deprecated feature checks closer to the top of the list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-02 23:39:42 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2020-04-02 23:29:54 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
 2020-04-02 10:58:58 +01:00
Konstantina Chremmou
d5035a010d Run LegacySsl , PowerOn mode, and PV Guest checks only if strictly necessary. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-02 10:55:37 +01:00
Konstantina Chremmou
21071ce463 CA-330308: Do not mark the page as changed or save settings before the page is loaded for the first time. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-02 10:55:37 +01:00
Konstantina Chremmou
6c5edddda8 CP-32701: Show certificate expiry alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
fc944784b4 CP-32697: Show certificate metadata on the host's General TabPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
3ecd6a4d8b Fixed missing ExpandedChanged event registrations. Tidied up methods toggling the section expanded state. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
8c4af40cf2 Added command and menu item for launching the certificate installation dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
2b3884fa72 Spinner Icon enhancements 
Added failure result; added default values for success and failure images;
renamed method and property; removed duplicate code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
00e015f2d0 Run vSwitch Controller and PV Guest checks only if strictly necessary. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 15:31:36 +01:00
Konstantina Chremmou
8f79c7cf13 CA-336986: Handle server side update precheck for vSwitchController. 
Also, renamed a couple of parameters because the old name was specific to one error.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 15:31:36 +01:00
Konstantina Chremmou
974ece8878 CA-337287: Skip legacy protocol and power-on iLO checks with a warning if the RPU hotfix is missing. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3a35a96530 CP-33294: Remove iLO power on option from XenCenter 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
5406b933fd CA-330308: Rewrote Power-On edit page to fix workflow issues: 
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
d7ae7a8571 Corrected instruction to match the documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-27 16:49:51 +00:00
Konstantina Chremmou
888a0555ab CA-337287: Skip vSwitch controller and PV guest checks with a warning if the RPU hotfix is missing. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-27 16:47:25 +00:00
Konstantina Chremmou
608f56fe7d CA-336931: Informational problems should not be resolvable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-18 13:24:22 +00:00
Konstantina Chremmou
862971621b CA-333059: Fixed issue where the updates list was not refreshed for pool slaves after applying an update. 
Also, fixed some performance issues; minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
6c06b08024 Some refactoring and code modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
44dd03e85f Fixed issue where it was possible to have both View ToolStripMenuItems in unchecked state. 
Also, UX enhancement: added tooltips showing the update alert page URL.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
452edbc496 Fixed broken build. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-10 14:22:59 +00:00
Konstantina Chremmou
fb7f5ef2d0 CA-335356: If the GFS2 probe cannot find devices, do not prevent the user from creating LVMoHBA SRs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-10 14:00:31 +00:00
Konstantina Chremmou
237da850b8 Moved vSwitch controlller check closer to the top of the check list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-06 13:15:09 +00:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-04 12:40:20 +00:00
Konstantina Chremmou
a07c68a345 CA-334756: Allow detaching and reattaching all types of SRs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-03 09:30:00 +00:00
Konstantina Chremmou
00cc547aaf Warning and error corrections. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
d3c5769a70 CP-32844: Check and warn if DVSC is configured when updating or upgrading a pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
ebcbf9cabc CP-32947: Hide CHIN network type and do not restrict QoS options. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
4ff42f51f3 Modifications on the NewNetwork wizard (includes CA-192746). 
- NetworkDetails page: reworked it to fix NumericUpdown validation and messages (CA-192746).
- SelectNetworkType page: moved warnings closer to the corresponding network types,
  fixed wrong label enabled state and made enablement logic more explicit.
- All pages: property modernisation and control layout tweaks (mostly margins).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
501970dec5 Name explicitly the control to be focused on page load. No need to search through all the controls of the page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
76ba20205e CA-335633: Prevent crash due to iterating through modified dictionary. Ensure that per-XenObject dialogs closed by the user are removed from the tracking table. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-28 13:33:57 +00:00
Konstantina Chremmou
cf633c3d9d Removed duplicate method. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-28 13:33:57 +00:00
Konstantina Chremmou
7aeb17272b CP-32844: Check and warn if legacy SSL mode is enabled when updating or upgrading a pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Konstantina Chremmou
64b23be1aa CP-32844: Drop legacy SSLv3 setting 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Konstantina Chremmou
a36b4062b8 Derive BrokenSR from HostProblem. Removed obsolete classes. Some code modernisation and consolidation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Konstantina Chremmou
bbc826264a Put controls on a TableLayoutPanel. Corrected warning text for standalone host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Konstantina Chremmou
711d1d0e63 Register events for connection only if a connection dialog does not exist already. 
If they are registered on all cases and then unregistered and a new connection is
attempted, the connection dialog launched from the first connection attempt is
not closed after connection is established, because the connection events have
been unregistered.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-26 13:24:47 +00:00
Darren Matthews
7925bcae27 L10N : Translation and resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-02-26 08:24:06 +00:00
Konstantina Chremmou
1b35a6898f Spelling corrections, mostly for consistency with the docs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-14 14:43:22 +00:00
Konstantina Chremmou
3869d9654d New bindings (includes CP-29452, CA-75634, CA-280976). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-14 14:43:22 +00:00
Konstantina Chremmou
f0c1396a7c CA-334860: Attempt repatriating only VMs that have actually been evacuated 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-14 14:42:14 +00:00
Mihaela Stoica
b46369bf9e
Merge pull request #2606 from kc284/master 
Merge feature/REQ-803 into master
 2020-02-13 12:56:35 +00:00
Konstantina Chremmou
b1440b3e19 CA-232294: Remove connection dialog from the list if the connection hasn't gone through. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-13 12:37:27 +00:00
Konstantina Chremmou
1bcec343f1 Merge remote-tracking branch 'upstream/feature/REQ-803' 2020-02-13 11:43:17 +00:00
Mihaela Stoica
2b0822f3d3 CP-32931: Stop sending licensing information to the licensing server 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-02-11 08:35:42 +00:00
Darren Matthews
07d475b6cd L10N : Translation update and resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-02-03 13:51:15 +00:00
Konstantina Chremmou
6caa4199cd CA-328267: Only remove connection dialogs when they close, not when the AddServerDialog closes. 
Otherwise the connection dialog remains open even after a connection that required
entering a new password succeeded.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-29 10:07:36 +00:00
Konstantina Chremmou
576d2d5a83 CA-271455 regression: clean temporary OVF packages extracted from OVAs, but not original OVF packages. 
Also, remove obsolete lines that delete touch files (they are not created any more).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-29 10:07:36 +00:00
Konstantina Chremmou
70ec38b5d5 CA-333226: Reload the SR selection page when the selected affinity changes. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-24 11:45:54 +00:00
Konstantina Chremmou
f7391e991b
CA-156873, CP-31105 (partial): Apply common branding and versioning to assemblies; branding refactoring 
Added brand management files and refactored the following brand variables:
* BRANDING_XENSERVER_UPDATE_URL
* BRANDING_PERF_ALERT_MAIL_LANGUAGE_DEFAULT
* BRANDING_SEARCH
* BRANDING_UPDATE
* BRANDING_BACKUP
* BRANDING_LEGACY_PRODUCT_BRAND
* ISO
* BRANDING_VERSION_5_6
* BRANDING_VERSION_6_2
* BRANDING_VERSION_6_0
* BRANDING_VERSION_6_5
* BRANDING_VERSION_7_0
* BRANDING_VERSION_7_1_2
* BRANDING_VERSION_8_0
* BRANDING_VERSION_8_1
* BRANDIND_COPYRIGHT
* BRANDING_COPYRIGHT_2

Also: Try passing the timestamp server as parameter
 2020-01-22 14:47:39 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import. 
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-16 16:26:30 +00:00
Konstantina Chremmou
6c59501265 Corrections around signing manifests. Updated .gitignore. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-10 12:00:50 +00:00
Konstantina Chremmou
ec298938c3 CP-32561: Upgraded WiX Toolset to 3.11.2. Also: 
- Changed the verbosity of some commands.
- Do not compile the splash screen twice.
- Do not brand obsolete folder XenServer.
- Moved the WiX source patch to a more relevant folder.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-10 12:00:50 +00:00
Konstantina Chremmou
45fe63ecde Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
efa0fc2fdc CA-187943: Show a warning when a new VM's disks cannot be accommodated on the template or default SR due to lack of space. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
9e33f4c90c Do not re-select a best SR if the user has already selected one via the New Disk dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
99a3a30fc7 Removed methods that add unnecessary complexity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
ef7c90a9e9 Layout modifications. 
- Renamed button to make it more discoverable.
- Placed the controls on a table layout panel for better response to wizard resizing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
9e1ec4cf41 CA-333236: Calculate local time for HotfixEligibilityAlert properties on the UI thread. 
The Title and Description of HotfixEligibilityAlert  involve calculation of local
time which should be done on the UI thread, otherwise the time is not localised
correctly, and additionally the application crashes when dismissing or sorting
these alerts.
Also, stop spamming the logs with each alert removal; code efficiency correction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-02 13:15:18 +00:00
Darren Matthews
ce217adc60 L10N : Translation and Resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-12-13 12:49:56 +00:00
Konstantina Chremmou
198baf4beb CA-332711: Do not count checked pools as selected if they are disabled. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-11 10:25:43 +00:00
Konstantina Chremmou
f459ef5956 CA-331420: Do not refresh the license status on the general tab if the selected object is not a pool/host. 
- Removed AsyncServerTime class as it adds complexity and the risk of
  getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-09 14:39:09 +00:00
Xueqing Zhang
224acb6706 CA-330890: update storage select wazard in XCM 
Signed-off-by: Xueqing Zhang <xueqing.zhang@citrix.com>
 2019-12-09 11:06:25 +00:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
1bf5add051 Typo in property name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
b9522c8cb2 CA-328267: Do not show the connection dialog if it's already disposed. Various other code improvements: 
- Use the base class connection property instead of an own field.
- Do not fix fonts an window location; it's done in the parent class.
- Corrected event registration and duplicate handling.
- Launch modal forms in using blocks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
a18d6d3ccb The application would not exit if closed with a connection dialog open. Performance improvement. 
- Set owner form for some connection commands to ensure that the application
will exit if the user attempts to close the main window while a connection
dialog is visible.
- Do not iterate through all the VMs of the connection in order to close
potentially open VM dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
11cd01900b Made the XenDialogBase's connection a readonly field so it's set in a uniform way throughout the application. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
e34cf30168 Renamed dialog to match containing file name. Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
9cfb714322 CA-330814: Code clean-up in the XenOvfTransport project. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-19 09:20:14 +00:00
Konstantina Chremmou
6bc54fc1e8 CA-330686: use the SM capabilities instead of the allowed operations for deducing if the SR supports mirroring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-18 13:01:33 +00:00
Mihaela Stoica
cb1531ae0d CA-330689: Fix failure in the cross pool migrate filter 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-15 17:11:09 +00:00
Konstantina Chremmou
1050b14edc Prevent from crashing if cancelling the Import wizard while on the Select host page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-14 12:14:26 +00:00
Mihaela Stoica
aca8be2939 CP-32431: Add version check to the drag and drop commands 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-13 13:39:27 +00:00
Konstantina Chremmou
5614dafbe6 CA-329742, CA-330301: Logging simplification. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
99572da0fb Corrections to the logging of Win32 exceptions. Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
61fccecac6 Corrected the supported runtime's sku in xenadmin's application config. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:19 +00:00
Konstantina Chremmou
0eb2f09fa2 Ensure we update the controls on the UI thread. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:19 +00:00
Mihaela Stoica
b73f5c9beb CP-32431: Remove the CPU feature compatibility check from XenCenter 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-12 09:47:04 +00:00
Darren Matthews
e56a6e5d66 L10N : Translation Update and Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-11-11 15:23:40 +00:00
Mihaela Stoica
93a6171108 CP-32361: Update the RPU hotfixes 
- Replaced RPU003 and RPU004 with new versions
- Added RPU005 for Naples

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-11 15:23:29 +00:00
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated. 
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-08 10:27:49 +00:00
Konstantina Chremmou
4a8507fd86 CA-330394: Fixed issue whereby queued conversions had a start time in future. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-08 09:24:06 +00:00
Mihaela Stoica
326e4d8fe8 CA-329695: Restrict switching the boot mode in the New VM wizard (when created from template or snapshot) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-01 15:14:24 +00:00
Konstantina Chremmou
56b3990875 CA-329838: Do not reload the last wizard page when hitting the finish button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-01 11:00:46 +00:00
Konstantina Chremmou
5d8b0f685f Corrected spelling to match the docs. Use en-us spelling. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-30 11:41:44 +00:00
Konstantina Chremmou
dcaf527757 CA-293784: Path and message updates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-30 11:41:44 +00:00
Konstantina Chremmou
7cc42fe2ee CA-329317: When migrating a VDI do not enable target SRs that do not allow mirroring. 
- Compacted code deciding whether to show an SR on the picker.
- Removed code sorting the disabled SRs because it repeats partially the
SR checks without reflecting exactly the disabled reason and probably
causes confusion when compared with the main treeview.
- Renamed property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-25 10:07:06 +01:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-10-21 13:53:59 +01:00
Mihaela Stoica
32981d24f1 CP-32254: Add DMC deprecation banner 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-10-18 10:04:51 +01:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter 
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
 2019-10-18 09:56:21 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections. 
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
6f0a9cae6a CA-293784: updated plugins to use the XenServerPSModule as the snap-in has been retired. 
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-09 13:32:07 +01:00
Konstantina Chremmou
6bae7380a2 Property modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-09 13:32:07 +01:00
Konstantina Chremmou
e9d2da082d Prevent XenCenter from crashing if starting it by double-clicking a license file. 
Also, fixed hotkeys and info message on the PasswordRequest dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-07 18:00:32 +01:00
Konstantina Chremmou
73d457ec16 CA-328086: Prevent XenCenter from crashing when started from the cli without enough parameters for connecting to a server. 
Also, compacted the code parsing command line parameters; removed class
and cli option MessageBoxTest as it adds to code complexity, plus that
the application is not meant to be used as testing infrastructure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-07 18:00:32 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756 
Merge feature/REQ-756 into master
 2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-09-25 15:17:19 +01:00
Konstantina Chremmou
91e2ec3bbe CP-32101: Allow the application to seek help relevant to its release instead of always pointing to help for the latest CR. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 15:02:05 +01:00
Konstantina Chremmou
5244c91658 Help refactoring. 
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 15:02:05 +01:00
Konstantina Chremmou
eed06a6b4a Fixed unlocalised message. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 15:02:05 +01:00
Konstantina Chremmou
b46d9fda92 Throw specific NotImplementedException instead of generic exception. Some property modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 15:02:05 +01:00
Konstantina Chremmou
441734be82 CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool. 
Also, corrected the RBAC permission check after stopping using the conversion plugin.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 13:25:26 +01:00
Konstantina Chremmou
3d92246607 The GpuConfiguration list should not be editable. Resize GpuShinyBar Edit button when the text changes. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-23 13:39:54 +01:00
Konstantina Chremmou
ceccfcbe79 CA-325439: Pre-populate download locations. Validation corrections on the server status report wizard. 
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-19 14:06:28 +01:00