Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,216 Commits 11 Branches 48 Tags 186 MiB
b50ba18b38
Commit Graph

6216 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
b50ba18b38 Show the snapshot's name for the extra VIFs belonging to snapshots. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Konstantina Chremmou
f6db9820a1 Retrieve VM snapshots from the cache instead of making an API call to the server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Danilo Del Busso
e169f0bfcc
Amend indentation in changes for CA-359124 & CA-360426 
Refactor all tabs into 4x spaces

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:29:31 +00:00
Danilo Del Busso
7e007cd6ef
CA-360426: Fix VIF to Network mapping during cross pool migration 
Amend mapping so it reflects xapi calls, keeping VIF -> Network mapping and removing Network -> Network mapping

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:27:22 +00:00
Danilo Del Busso
bee0b881d4
CA-359124: Add snapshot VIFs to mapping during cross pool migration 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Add VM snapshots VIFs to network mapping wizard page

This is not entirely necessary, since the mapping in the background is actually Network -> Network.
However, this is closer to the intent of the page.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Tidy up methods in `VmCrossPoolMigrateACtion.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:25:58 +00:00
Konstantina Chremmou
2d5ccdb37e
Merge pull request #2904 from danilo-delbusso/vm-copy-credentials_CA-359712 
CA-359712 & CA-359709: Add RBAC check to VM/template copy/clone and Server Status Report Wizard
 2021-12-03 10:48:17 +00:00
Danilo Del Busso
76b20f4874
Merge pull request #12 from kc284/vm-copy-credentials_CA-359712 
Merge from master
 2021-12-03 10:44:42 +00:00
Konstantina Chremmou
a0a706e9bb Merge branch 'master' into vm-copy-credentials_CA-359712 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/ImportWizard/ImportWizard.cs
#	XenModel/Actions/VM/VMCopyAction.cs
 2021-12-02 22:14:48 +00:00
Konstantina Chremmou
cace3036cf
Merge pull request #2854 from danilo-delbusso/CA-339273 
CA-339273: Add source server/pool info to descriptions of actions that move/copy/import resources
 2021-12-02 21:01:20 +00:00
Konstantina Chremmou
2af5758424
Merge pull request #2842 from danilo-delbusso/master 
CA-350411: Add conditional page control refresh in Import Wizard
 2021-12-02 21:01:00 +00:00
Konstantina Chremmou
e9fa5674c3 CA-339273: Some corrections and minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-02 11:20:49 +00:00
Konstantina Chremmou
eef4e5f995 CP-38427 issue 1: Do not allow enabling TLS verification during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-30 22:46:43 +00:00
Konstantina Chremmou
051c205899 CA-350411 part 2: Add conditional page control refresh in Import Wizard 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 15:35:00 +00:00
Konstantina Chremmou
355321faea Made ovfModeOnly an optional parameter. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 15:35:00 +00:00
Konstantina Chremmou
89620bff4b Restored RBAC check on source connection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
Konstantina Chremmou
a327390e4a Further refactoring of CopyVM- and CopyTemplateCommand to reduce repetitive code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
Konstantina Chremmou
e265e86cfa Refactored and renamed class WizardPermission and the code areas using it. Corrections to RBAC messages. Sorted Messages.resx. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898) 
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-11-22 12:02:26 +00:00
Konstantina Chremmou
c2f92aa02a
Merge pull request #2903 from danilo-delbusso/CP-36392-Bugs 
CP-36392: Address statically flagged trivial issues that can cause bugs
 2021-11-17 11:36:48 +00:00
Danilo Del Busso
f2fdf31a5a
CP-36392: Avoid multiple enumerations in LicenseStatus.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-17 09:01:25 +00:00
Danilo Del Busso
3e861411db
CP-36392: Invert if statements to reduce nesting in HostMemoryControls and changeControlDomainMemoryCommand 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:42:18 +00:00
Danilo Del Busso
47510f5b07
CP-36392: Reassign expiryGroups after ordering 
regression from db2c00d5

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:39:50 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
 2021-11-15 15:49:39 +00:00
Danilo Del Busso
6ed9e28da1
Move RBAC page addition to separate method in ExportApplianceWizard.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 12:04:04 +00:00
Danilo Del Busso
09c26d7936
Move CheckRbacPermissions to superclass 
Also decouple the `ErrrorDialog` creation from the method.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 12:01:29 +00:00
Danilo Del Busso
e791b70ba7
CP-36392: Move return to new line in Search.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:39 +00:00
Danilo Del Busso
11e90940e0
CP-36392: Simplify Equals method in QueryTypes.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:08 +00:00
Danilo Del Busso
f66216bf7b
CP-36392: Improve readability in Name method of Network's xapi extension 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:18:32 +00:00
Danilo Del Busso
9b4f960336
CP-36392: Check for whitespace-only values in GEtPerfmonDefinitions 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:15:29 +00:00
Danilo Del Busso
cfff0722c7
CP-36392: Limit ex-readonly public lists to {get;} usages only 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:11:41 +00:00
Danilo Del Busso
6f7faefce1
CP-36392: Replace complex method with single LINQ calls in DRFailoverWizardStoragePage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:09:11 +00:00
Danilo Del Busso
68b54682ae
CP-36392: Move param checks outside of RepairSRDialog.cs's constructor 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:05:08 +00:00
Danilo Del Busso
31702c9e43
CP-36392: Add null checks for ControlDomainMemoryDialog's constructor params 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:00:50 +00:00
Danilo Del Busso
cc917e2a66
CP-36392: Simplify if and else if blocks to reduce nesting in AddServerDialog.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:57:08 +00:00
Danilo Del Busso
1acce3638c
CP-36392: Move vms null and Count checks outside of WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

damni

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:52:06 +00:00
Danilo Del Busso
396bcb0e35
CP-36392: Make type field readonly in QueryElement.cs 
field is used in `GetHashCode`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:46:12 +00:00
Danilo Del Busso
494f78966d
CP-36392: Address logic issue in FilterLocationToolStripDropDownButton.cs 
As suggested during review:

> The check after the `&&` should go in a nested if block: if we are in a split second where the cache has not been populated yet, there should be no item added, however, this code will add a `p` item.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:43:50 +00:00
Danilo Del Busso
02439d5303
CP-36382: Replace _nameCell with ad-hoc _xenObject readonly field 
To ensure that the field in the `GetHasCode` call is `readonly`
Also remove unused constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:36:42 +00:00
Danilo Del Busso
5d5d971c74
CP-36329: Remove redundant verbatim in WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:21 +00:00
Danilo Del Busso
47884376a3
CP-36392: Fix typo in VNCTabView.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:19 +00:00
Danilo Del Busso
caf608344e
CP-36392: remuve redundant iteration in ResumeVMOnHostToolStripMenuItem.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:24:17 +00:00
Danilo Del Busso
5f117e90c5
CP-36392: Add null check in EnableHostAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:21:25 +00:00
Danilo Del Busso
b6a70e2ffc
CP-36392: Add null check for _vmOptList in WlbOptimizePoolAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:55 +00:00
Danilo Del Busso
45512b4cde
CP-36392: Add removed null check in WlbOptiomizePool.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:09 +00:00
Danilo Del Busso
6ce0a4b49d
CP-36392: Remove repetitive count and null check 
Check is performed within the constructor of `WlbRecommendations`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 16:07:36 +00:00
Danilo Del Busso
0924563cff
CA-350411: Add conditional page control refresh in Import Wizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-350411: Tidy up local variables within ImportWizard

* Use of local variables for readibility.
* Fixed ordering issue which caused if block to check for condition too late.
* Add connection and type of import checks before adding/removing boot options page

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-350411: Update visibility settings in fields needed for fix

Fields were either read-only, or private. Internal accessor settings allows for external modification and checks.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-350411: Add checks for the `ImportSourcePage` and `GlobalSelectHost` page types

Also remove unused methods in `NetworkPickerPage.cs` and `StoragePickerPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:42:08 +00:00
Danilo Del Busso
2978f60f8a
CP-36392: Improve readability of latest changes 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:23:21 +00:00
Konstantina Chremmou
688fe99e3e CA-359969: Do not rebuild the list if the scanning of the SRs has not finished yet. Removed unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-02 16:53:48 +00:00
Danilo Del Busso
f5149a415f
CA-359709: Add error message for RBAC failure in BugToolWizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-28 13:55:29 +01:00
Danilo Del Busso
ae1efbd54d Add method to add API methods checks to RBAC page 
Also minor refactor of wizards that were using the same logic

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-28 13:48:24 +01:00