Commit Graph

3077 Commits

Author SHA1 Message Date
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
a548c21120 CP-18417: Simplifying the automatic enabled/disabled logic.
Automatic is disabled if any pool forbids auto restart (per Neptune), and reboot is required. It's also disabled if the update type isn't one of the three in the switch statement. If it's enabled it is checked by default.
2016-08-26 14:45:24 +01:00
Callum McIntyre
8639660562 Move the check to stop Neptune servers being selected into the IsInAutomaticMode checks 2016-08-26 14:24:24 +01:00
Callum McIntyre
615b55321d Intermediate checkin, branched from REQ156 and applied my changes, needs checking. 2016-08-19 17:27:24 +01:00
Konstantina Chremmou
26009a79f0 Ignore temporarily this test on branch REQ-156 (broke on trunk and is not relevant for this feature).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 12:56:15 +01:00
Frezzle
bbfd32353b Merge pull request #1130 from kc284/REQ-156
CA-217232: Added some null ref checks.
2016-08-19 12:44:04 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Konstantina Chremmou
f17bf6fc68 Merge pull request #1129 from GaborApatiNagy/REQ-156_github_master
Merge master into branch REQ-156
2016-08-18 17:02:47 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
37c120ee57 CA-217232: Fixed regression caused by the fix for CA-216935
Creation of PoolPatchMapping objects made safer.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:30:50 +01:00
Gabor Apati-Nagy
feafb7ac62 CA-217232: Fixed regression caused by the fix for CA-216935
Comparing uuids instead of references that likely will be changed after the Cache has been repopulated.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:25:39 +01:00
Gabor Apati-Nagy
71cdd69f90 Merge pull request #1127 from kc284/master
Improvements made while investigating CA-218953:
2016-08-18 11:11:11 +01:00
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Gabor Apati-Nagy
684b03317d Merge pull request #1120 from MihaelaStoica/CA-180127
CA-180127: Unable to unset VM home server if all shared SRs are full
2016-08-16 16:22:16 +01:00
Gabor Apati-Nagy
a069e177c3 Merge pull request #1118 from MihaelaStoica/CA-147142
CA-147142: ReadOnly user should not be allowed to delete crash dump f…
2016-08-16 16:16:56 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Mihaela Stoica
a3ad025bc6 Merge pull request #1117 from mcintyre94/CA-218304
CA-218304: Text cut off in Properties dialog, Alerts tab
2016-08-16 11:03:48 +01:00
Callum McIntyre
e2215c71f5 CA-218304: Modify tab stops in alert properties tab
Now behaves as expected - alert interval (top control) has lowest tab stop, all other groups incremented by 1.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 10:44:37 +01:00
Mihaela Stoica
4bc3cca91c Merge pull request #1122 from GaborApatiNagy/master_CA-150198
CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk
2016-08-16 10:40:55 +01:00
Mihaela Stoica
7c4a4fa219 Merge pull request #1121 from mcintyre94/CA-218241
CA-218241: Cancel connect right click menu item does not seem to be doing anything
2016-08-16 09:44:51 +01:00
Callum McIntyre
4559e162b7 CA-218304: Text cut off in Properties dialog, Alerts tab
Instead of adding a second table layout panel for the rubric label, I have extended the original table to include two new rows at the top - one for the label rubric, and one for the repeat interval controls (previously not in the table).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 08:49:56 +01:00
Mihaela Stoica
8bdcbc5208 Merge pull request #1119 from mcintyre94/CA-217821
CA-217821: Specified home server in cross pool migration should behave as home server
2016-08-15 19:38:00 +01:00
Gabor Apati-Nagy
0cb878d577 CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:32:53 +01:00
Callum McIntyre
a41c76a0ba CA-217821: Remove unused TARGET_SERVER_MENU_ITEM key from Japanese+Chinese resources
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 16:38:48 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
8b035b3af5 CA-218241: Cancel connect right click menu item does not seem to be doing anything
The CancelHostConnectionCommand executes by using a DisconnectCommand, so the fix here is to allow that command to execute on connections in progress as well as those that are connected.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 15:25:14 +01:00
Mihaela Stoica
67be366858 CA-180127: Unable to unset VM home server if all shared SRs are full
By passing null as the srHost parameter to the affinity picker, the "no home server" radio button remains enabled, even when no shared SRs are available, allowing users to unset the home server of a VM

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 15:15:00 +01:00
Mihaela Stoica
b35564cb85 CA-147142: ReadOnly user should not be allowed to delete crash dump files
- Made the action PureAsyncAction, so that it automatically checks if the current user can perform all the necessary api calls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 14:27:43 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Callum McIntyre
0cb567128b CA-218304: Text cut off in Properties dialog, Alerts tab
This is resolved by moving the label into a TableLayoutPanel, docked to the top and with auto-grow on.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 10:45:53 +01:00
Gabor Apati-Nagy
c90582a72e Merge pull request #1116 from GaborApatiNagy/master_livepatch
CP-18012: Fixed the Jenkins build, regenerated resources
2016-08-12 18:31:27 +01:00
Gabor Apati-Nagy
b835090338 CP-18012: Fixed the Jenkins build, regenerated resources
Fixed test:
1) Test Failure : XenAdminTests.UnitTests.MiscTests.NamesAndMessagesTests.XapiFriendlyNameStaticMethodsReturnStrings
     Null value returned for get_SR_BACKEND_FAILURE_457
  Expected: not null
  But was:  null

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-12 18:26:30 +01:00
Gabor Apati-Nagy
8a10351c5d Merge pull request #1113 from xenserver/revert-1110-CP-18011
Revert "Cp 18011: [XenCenter] Add live patching checkbox"
2016-08-12 17:20:38 +01:00
Gabor Apati-Nagy
9dd3a41857 Revert "Cp 18011: [XenCenter] Add live patching checkbox" 2016-08-12 17:19:34 +01:00
Mihaela Stoica
aeeb1260e7 Merge pull request #1110 from mcintyre94/CP-18011
Cp 18011: [XenCenter] Add live patching checkbox
2016-08-12 17:17:37 +01:00
Gabor Apati-Nagy
62dabcccf7 Merge pull request #1112 from MihaelaStoica/master
Add ElyOrGreater function
2016-08-12 17:06:31 +01:00
Mihaela Stoica
e5ab6fe06d Add ElyOrGreater function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 17:03:49 +01:00
Callum McIntyre
1cfa2f6df0 CP-18011: Change the restrict_live_patching check to use BoolKeyPrefer true
This means that if license_params doesn't contain this key we consider it restricted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 16:05:50 +01:00
Callum McIntyre
cc25e3ec45 CP-18011: [XenCenter] Add live patching checkbox
UI changes to add rubric label and radio buttons instead of a checkbox.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 15:58:49 +01:00
Mihaela Stoica
54b3d6c2bb Merge pull request #1109 from kc284/REQ-156
CA-217846: Fixed two more tooltip texts with fullstops.
2016-08-12 13:48:00 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Callum McIntyre
82092adee4 CP-18011: Add licensing check for live patching before showing the new page
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 11:55:12 +01:00
Callum McIntyre
d3f4a4aa99 CP-18011: [XenCenter] Add live patching checkbox
Add the Live Patching tab as a new part of PropertiesDialog, shown for pools and standalone hosts. Tab contains one checkbox which toggles the live_patching_disabled XenServer API property. Not yet implemented: license check ("The option should only be shown if the pool is licensed")

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 09:51:20 +01:00
Konstantina Chremmou
61640d6435 CA-217846: Fixed two more tooltip texts with fullstops.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-12 09:15:42 +01:00
Gabor Apati-Nagy
2d02f806fd Update BatchUpdatesTests.cs
CA-217862: Fixed unit test, removed unneeded Assert
2016-08-11 14:40:48 +01:00
Gabor Apati-Nagy
9de5e7ef9f Merge pull request #1107 from mcintyre94/CP-18011
CP-18011: Add live patching checkbox
2016-08-11 13:21:30 +01:00