Commit Graph

6936 Commits

Author SHA1 Message Date
Danilo Del Busso
bba9f43c31
CA-376887: Refactor thread management for ArchiveMaintainer (#3148)
* Tidy up `ArchiveMaintainer`: use naming conventions
* Tidy up `ArchiveMaintainer`: use `var` when possible
* Tidy up `ArchiveMaintainer`: fix typos
* Tidy up `ArchiveMaintainer`: move action methods in own region
* Tidy up `ArchiveMaintainer`: apply code formatting
* Tidy up `ArchiveMaintainer`: remove unused constant/using
* Tidy up `ArchiveMaintainer`: group methods into regions
* Tidy up `ArchiveMaintainer`: remove xmldocs
* Tidy up `ArchiveMaintainer`: miscellaneous changes
* Tidy up `ArchiveMaintainer`: move `NextArchiveDown` to correct `region`
* CA-376887: Use multiple threads to load performance tab data
This commit removes the ad-hoc use of `Thread` and instead relies on `ThreadPool` and `CancellationToken`s to handle multi-threading. To achieve this, `ArchiveMaintainer` instances are now tied to only one `XenObject`. If a user navigates to another Performance tab, a new instance of `ArchiveMaintainer` is used. This enables XenCenter to quietly cancel ongoing data fetching operations, and start a new one without affecting the UI. UI elements are simply updated to point to the new `ArchiveMaintainer` while the old one is being  closed.
Please note that follow up commits to clean up `ArchiveMaintiner` and this implementation are coming. They have been separated to make reviews easier
* CA-376887: Move initial load logic to separate method in `ArchiveMaintainer`
* CA-376887: Rename `Update` to `StartUpdateLoop` in `ArchiveMaintainer`
* CA-376887: Fix use of `Dispose` in `PerformancePage` and collapse `Stop`/`Pause` into one method
* CA-376887: Remove unused `FirstTime` variable
* Tidy up `ArchiveMaintainer`: use `switch` when possible and improve logging
* Tidy up `ArchiveMaintainer`: Move variables inline
* Tidy up `ArchiveMaintainer`: Standardize fields/properties
* Tidy up `ArchiveMaintainer`: Normalize whitespace
* CA-376887: Ensure only one thread is spawned for each `ArchiveMaintainer`
- Ensures resources are disposed of
- Fixes issues whereby quickly starting and stopping threads for the same `XenObject` `ArchiveMantainer` would cause threads from not exiting
* Improve formatting and whitespace in `ArchiveMaintainer`
* Improve logging of exceptions in `ArchiveMaintainer:Get`
* Fix `ServerNow` calls in `ArchiveMaintainer`
* Deregister `ArchiveMaintainer` events when a new one is reassigned.
Also rename methods
* Apply code review suggestions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-09-07 10:03:43 +01:00
Konstantina Chremmou
dd98fe6732
CP-45071: Convert XenCenter build scripts to PowerShell. (#3219)
* CP-45071: Convert XenCenter build scripts to PowerShell.
* Removed obsolete variable.
* Pass the timestamp server and the certificate thumbprint as parameters to the build and sign scripts.
* Added further logging and made the verbose output of cmdlets optional.
* Updated README.
* Improved script readability.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-06 15:48:12 +01:00
Danilo Del Busso
53dd3d97ca Update links between CONTRIBUTING and MAINTAINERS
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-09-04 12:29:36 +01:00
Konstantina Chremmou
98c3814ce0
Merge pull request #3212 from kc284/oil
Refactored retrieval of values from Messages.resx.
2023-09-04 10:32:46 +01:00
Konstantina Chremmou
89fd16b903 CP-45097: Show product brand alongside the version on the General and Search tabPage.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-04 10:32:18 +01:00
Konstantina Chremmou
30e9924b33
Merge pull request #3209 from kc284/tech-debt
CP-40739 (build with VS 2022) and some tech debt
2023-09-01 13:09:05 +01:00
Konstantina Chremmou
49334fc425
Merge pull request #3210 from danilo-delbusso/dev/readme
Update README and CONTRIB files
2023-09-01 13:08:40 +01:00
Konstantina Chremmou
c5430d0bd1 CA-381212 : The error is not always Internal Server Error;
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-30 17:08:06 +01:00
Konstantina Chremmou
d990e37a87 Moved two WLB actions to the same folder as the rest of the WLB actions. Removed obsolete messages.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-29 20:57:21 +01:00
Konstantina Chremmou
9c37834bd0 Stop retrieving values from Messages.resx by passing hardcoded strings to the Messages.ResourceManager.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-29 20:57:21 +01:00
Danilo Del Busso
69e3c6cf42
Rename CONTRIB to CONTRIBUTING.md
File name needs to be `CONTRIBUTING` for GitHub to pick it up as a valid file for contributor guidelines. See https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#adding-a-contributing-file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-25 08:41:50 +01:00
Danilo Del Busso
78ea00e0fd
Update README.md
- Add missing rebranding change
- C++ splash screen was removed

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-25 08:39:45 +01:00
Konstantina Chremmou
54c2fbb3f1 Manifest updates:
- Removed target to add manifest using mt.exe. The manifest is already in the project and embedded in the executable after the build.
- Removed Windows Vista and Windows 8 as .NET Framework 4.8 is not installable there.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-24 14:19:07 +01:00
Konstantina Chremmou
adec15e2ac CP-40739: Build with VS 2022.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-24 14:19:07 +01:00
Konstantina Chremmou
214e24589a Removed obsolete project xva_verify.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-24 14:19:07 +01:00
Konstantina Chremmou
8644ed3d83 CA-381212 : The protocol is not always HTTP/1.1
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-21 13:52:32 +01:00
Konstantina Chremmou
de1120f18b
More fixes including CA-381728, CA-381618, CA-381225 (#3205)
* CA-381728: If no post-update tasks exist, XenCenter should explicitly state so.

Also, livepatches should be shown if other guidance is absent.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Missing placeholders for building locally without applying branding.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Missing help links.

Also removed scripts that are not used any more.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* CA-381618: The HA/WLB off check is a pool, not a host check.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* CA-381225: Corrected order of running update guidance (also uses input from CA-381718).

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* UPDATES_URL has been renamed to XC_UPDATES_URL.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

---------

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-21 13:35:49 +01:00
Konstantina Chremmou
002bcbfecf
Merge pull request #3204 from kc284/cdn-fixes
CA-381212, CA-381664, CA-381215, CP-44618
2023-08-18 14:26:28 +01:00
Konstantina Chremmou
776dfc1a13 Updated introductory info for the HA configuration wizard.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
99612f2fc3 CP-44618: Bumped branding to v5.1.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
e485a0a803 CA-381215: Try waiting on host.apply_updates if it is not immediately available.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
fe8a28e970 CA-381212, CA-381664: Corrections when fetching list of available updates:
- Try waiting on get_updates if it is not immediately available.
- Log instead of failing when a known (404/500) BadServerResponseException occurs.
- Ensure the UI is refreshed after fetching the list of updates.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
e4b2b67cf5
Merge pull request #3198 from kc284/master
UX improvements: CA-381442, XSI-1476, CA-375740
2023-08-18 10:35:05 +01:00
Konstantina Chremmou
fdd5ca775a
Merge pull request #3202 from kc284/supp-pack
Wording change; corrections for supp-pack installation.
2023-08-17 18:45:26 +01:00
Konstantina Chremmou
351c652813
Merge pull request #3200 from kc284/CA-381502-reason
CA-381502: Show the disabled reason in a new column. Extended the messages shown.
2023-08-17 18:45:02 +01:00
Danilo Del Busso
fbdcf5f5de CA-381678: Fix misc wording issues in ManageCdnUpdatesPage export file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-17 18:44:39 +01:00
Konstantina Chremmou
113c19f9bd
Merge pull request #3199 from danilo-delbusso/bug/CA-381500_unlicensed
CA-381500: Fix `misc` instances of Unlicensed wording showing for post Nile host/pools
2023-08-17 18:44:16 +01:00
Konstantina Chremmou
6cfba9fe5a
Merge pull request #3169 from danilo-delbusso/bug/rdp-crash_CA-379640_XSI-1454
CA-379640, CA-356178, CA-370866: Do not reset remote consoles if they're still attempting connection to a VM
2023-08-17 15:50:22 +01:00
Danilo Del Busso
c1bb907a77
Remove useless lock around RemoteConsole calls
If a different thread accesses this code, the assertion will throw a Fatal error before hitting the content of the `lock`.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-17 15:42:52 +01:00
Danilo Del Busso
212543f4c0
Improve readability of ConnectToRemoteConsole in XSVNCScreen
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-17 15:24:57 +01:00
Konstantina Chremmou
82f55229da Changed wording.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-17 12:51:02 +01:00
Konstantina Chremmou
a98a1353c4 Applied supp-packs were not shown at pool level for new servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-17 12:50:57 +01:00
Konstantina Chremmou
6e175a4280 Corrected prechecks and calculation of post-update tasks for supp-packs installed on new servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-17 12:50:50 +01:00
Danilo Del Busso
d9885d342b CA-381593: Remove CIS privacy policy link from Server Status Report
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-16 19:09:28 +01:00
Danilo Del Busso
b9f2779c7e
CA-381500: Use custom wording for post-Nile license status in the General Tab
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-16 15:34:45 +01:00
Danilo Del Busso
1f7fbc017c
CA-381500: Revert renaming of Status to Expiry status
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-16 15:34:43 +01:00
Konstantina Chremmou
0d103e9af6 CA-381502: Improved the disabled reason for new servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 21:09:25 +01:00
Konstantina Chremmou
143974e93d CA-381502: Show the disabled reason in a new column because the tooltips are obscure.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 21:09:25 +01:00
Konstantina Chremmou
218d910b0a Typo.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 21:09:25 +01:00
Konstantina Chremmou
78396156ea CA-375740: VMSS has no other_config, hence no custom fields can be set.
Also, allow for a longer field label before ellipsization takes over.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 10:55:14 +01:00
Danilo Del Busso
81bf424013
CA-381500: Remove "(Unlicensed)" for post Nile hosts in MainWindow
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-15 09:23:36 +01:00
Danilo Del Busso
0680d9cba0
CA-381500: Ensure unlicensed hosts post Nile do not show as such in General Tab Page
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-15 09:23:35 +01:00
Konstantina Chremmou
2a81e63eba Use different image for the RPM packages to distinguish them from the updates.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 02:07:35 +01:00
Konstantina Chremmou
046476cd6e Show a different alert message if the user has never synchronized.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 01:20:31 +01:00
Konstantina Chremmou
cda79820b3 XSI-1476: No need to disable the post-update tasks textbox.
Also, prevent OnPageUpdated being called twice.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-14 23:25:13 +01:00
Konstantina Chremmou
fd1c08218a CA-381442: Disable the textboxes instead of making them readonly as it causes confusion to the user.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-14 22:58:05 +01:00
Konstantina Chremmou
bee2388225
Merge pull request #3197 from kc284/master
Merge feature/cdn-updates to master + CA-381216
2023-08-11 16:35:04 +01:00
Konstantina Chremmou
de18d6449f CA-381216: Corrections to Help URL and message.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 14:58:51 +01:00
Konstantina Chremmou
72fd9d4bb2 Merge remote-tracking branch 'upstream/feature/cdn-updates' 2023-08-11 14:45:26 +01:00
Konstantina Chremmou
b32168d8d8 Further work on CA-380738: After updates are applied retrieve the new metadata from the host in order to refresh the server status.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00