Commit Graph

6627 Commits

Author SHA1 Message Date
Konstantina Chremmou
bc40d47ba6 Corrections to removal of custom fields:
- Custom fields were not removed from all types of objects the UI allows
  setting them for, which meant they were left behind in the other_config.
- Only remove a custom field if it is set on an object, otherwise we hammer
  the server with unnecessary requests.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Konstantina Chremmou
87ff42086f Missing RBAC permission checks for CreateDiskAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
d3a2805af8 Renamed private fields to match conventions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
8c42b0428e Refactored the actions creating disks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
5828c03e8d CA-375173: Create the VDI and VBD records before closing the new disk dialog. Also:
Fixed issue where the SR was not preselected when editing an existing disk and no scans were taking place.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
af23635a20 CA-375366: Delete ZIP file generated while checking write permissions in BugToolPageDestination.cs
Also contains minor whitespace tidy up

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-24 18:09:52 +00:00
Konstantina Chremmou
f139334ac3 CP-40842: Changed icons for status report rows.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-24 18:09:42 +00:00
Danilo Del Busso
3edf31b7a2 CA-375346: Point to Wix Shell instead of executable when launching XenCenter
XenCenter executable was started with elevated privileges even with use of `Impersonate = "yes"`, and `WixShellExecTarget` was actually ignored.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-24 18:09:28 +00:00
Konstantina Chremmou
4089e821bd
Merge pull request #3099 from danilo-delbusso/remove-localisation-CP-41748
CP-41748: Remove non-English locals from installer
2023-02-22 14:41:34 +00:00
Danilo Del Busso
88a60312df
CP-41748: Update branding tag in Jenkinsfile
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 14:30:11 +00:00
Danilo Del Busso
c74f6169bf
CP-41748: Remove non-English locals from installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 14:29:50 +00:00
Danilo Del Busso
92b9f59e55
Merge pull request #3098 from danilo-delbusso/chc-rename-CP-42186
CP-42186: Rename CHCUpdates mentions and schema into XC based ones
2023-02-22 11:40:59 +00:00
Danilo Del Busso
ea9669ce1b
CP-42186: Update XML tag name in DownloadUpdatesXmlAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:05 +00:00
Danilo Del Busso
375b7485a6
CP-42186: Update tags in Jenkinsfile
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:04 +00:00
Danilo Del Busso
044ca44f3f
CP-42186: Rename CHCUpdates mentions and schema into XC based ones
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:29:38 +00:00
Konstantina Chremmou
91055c6e2c
Merge pull request #3096 from kc284/master
(master) CP-42155: Removal of HealthCheck service leftovers
2023-02-21 16:13:00 +00:00
Konstantina Chremmou
c70116691a Corrections as per code review:
- Bumped branding to v4.11.
- Reverted VS version in the solution file.
- Removed brand override registry entry.
- Converted HealthCheck warning pop-up to info pop-up.
- Moved status report actions to a separate folder.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:10 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Konstantina Chremmou
b49481b83b CP-42155: Removed HealthCheck tests.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Konstantina Chremmou
3a71ff29eb CP-42155: Removed HealthCheck service leftovers from the build and the installer.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Danilo Del Busso
39b84bbcc5 CA-375282: Insert sanitised TARs into Temp folder
Avoids permission related exceptions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-17 11:50:33 +00:00
Danilo Del Busso
653d66cb10 CP-40842: Report host action as failed when connection isn't possible
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-14 11:26:17 +00:00
Konstantina Chremmou
f885be7e4d
Merge pull request #3094 from xenserver/feature/vtpm
Merge feature/vtpm into master
2023-02-13 15:33:50 +00:00
Danilo Del Busso
2678f70f83
Merge pull request #3091 from danilo-delbusso/datasources-CP-40157
CP-40157: Updates to `GraphDetailsDialog`
2023-02-13 14:04:52 +00:00
Danilo Del Busso
6f6bddd755
CP-40842: Remove CIS upload from Server Status Report wizard (#3087)
* Remove credentials controls from `BugToolPageDestination`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Explicitly call dispose in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Tidy up code in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `StatusReportRow` to its own file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `ClientSideDataRow` and `HostStatusRow` to own files

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update order of pages in `BugToolWizard`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update action and create row for packaging status report in BugTool wizard

Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Allow for pending `StatusReportAction` to be cancelled

This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Report packaged data amount in `ZipStatusReportAction`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Remove unused `using`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Minor layout tweaks.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed folder and namespace to match the ones for the other wizards.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed wizard's private fields. Some code efficiency corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Keep the row classes as private within the BugToolPageRetrieveData class.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Removed leftover unused action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Tidy up status report messages. Use more relevant icon.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Made blurb localisable.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed private fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplified the stages of the compilation of the status report.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed row classes again to match the action names.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplify reporting the progress of the zipping action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Recursive call is not necessary. Tweaked message.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Sort strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Update copyright notices

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-02-13 13:47:21 +00:00
Konstantina Chremmou
798d22b87c
Merge pull request #3092 from kc284/master
Merge branch feature/rebrand into master
2023-02-09 15:43:44 +00:00
Konstantina Chremmou
a4ddce63c6 Merge remote-tracking branch 'upstream/feature/rebrand'
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Actions/Pool/SyncDatabaseAction.cs
#	XenModel/Actions/PureAsyncAction.cs
#	XenModel/Actions/VM/VMSuspendAction.cs
#	XenModel/XenServerProxy/RbacCollectorProxy.cs
2023-02-08 16:41:07 +00:00
Danilo Del Busso
df908e5049
Add missing unit handling in DataSet
Fixes issue #3080

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-08 14:00:37 +00:00
Danilo Del Busso
e35dbe5ef7
CP-40157: Show some hidden datasources in GraphHelpers.cs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-08 14:00:34 +00:00
Danilo Del Busso
0a14ece670
CP-40157: Move Description column to second place
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-08 14:00:32 +00:00
Danilo Del Busso
b8e1376d52
Revert string sorting
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-08 14:00:30 +00:00
Danilo Del Busso
2248395e6b
Tidy up source in GraphDetailsDialog
- Rename fields
- Reorder methods
- Rename methods
- Add `sealed` to `DataSourceGridViewRow`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-08 14:00:29 +00:00
Danilo Del Busso
b2c1331a0f
CP-40157: Increase default GraphDetailsDialog width to accomodate new column
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-01 11:23:41 +00:00
Danilo Del Busso
48e5c9ecf2
CP-40157: Add data source description as column in GraphDetailsDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-01 11:23:39 +00:00
Danilo Del Busso
6fecc41045
CP-40157: Update friendly name for xapi_open_fds data source
Also apply string sorting

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-01 11:23:37 +00:00
Danilo Del Busso
fb2f10be33
CP-40157: Expose some hidden data sources to UI
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-01 10:23:42 +00:00
Konstantina Chremmou
fc950d1718 Bumped branding pipeline to v4.10.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 17:02:29 +00:00
Konstantina Chremmou
0aaeadfb93 CP-40730: Added text explaining what the vTPM properties mean.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:38 +00:00
Konstantina Chremmou
f30afbe1d2 XSI-1362/CA-373773: Reworked the logic for selecting boot mode when creating a VM.
The new logic takes also account of platform:secure-boot=auto.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
439d29d9c3 Don't make server requests in the body of a property. Some minor code smells.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
86c39a559a
Merge pull request #3077 from kc284/pureAsyncAction
Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions.
2023-01-31 12:20:47 +00:00
Konstantina Chremmou
208036f197 Added copyright label to the splash screen.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
dcbfe2c8fa Corrected user visible copyright and uses of vendor names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
34ca86fed7 Corrections as per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-26 00:15:57 +00:00
Konstantina Chremmou
ed3122371f
Merge pull request #3084 from xenserver/master
Merge master into feature/vtpm
2023-01-25 14:04:40 +00:00
Konstantina Chremmou
8d0e8c90ac Fixed broken tests.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
372e70e95f Corrections are per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
47d3d4c7d1 CP-41433: Use different product version variable for the installer.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00