Commit Graph

1208 Commits

Author SHA1 Message Date
Konstantina Chremmou
67a0980318 Brought the Select/Clear All buttons closer to the bottom of the server list
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
0567d838df Do not set the owner form within the NewDiskDialog constructor; it should be
set by the caller. Test corrections so they don't time out due to blocking
open dialogs. Some tidying up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 09:45:13 +00:00
Darren Matthews
1bf47e47df L10N : Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-13 01:06:04 +00:00
Darren Matthews
0f6f7c0ec4 L10N: Translation updates and resx resync (#2363)
L10N: Translation updates and resx resync

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-10 14:03:27 +00:00
minli1
3f4cf82a13 CP-30405: Refine conditions when creating VM scheduled snapshots.
Since we support checkpoint of Nvidia VGPU dedicated VMs, the conditions
text when new a VMSS needs to be refined.Note that Intel and AMD dedicated
GPUs VMs still be blocked for checkpoint.

Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
Konstantina Chremmou
ada6f7dac7 CA-296490: Upload single update to multiple pools in parallel. (#2338)
* Simplification: use auto-properties.

* Removed unnecessary null check. Converted private methods to linq method chain.

* Removed unused file. Added null check.

* Corrected property names as it was difficult to distinguish between the alert,
the patch and the filepath.

* Removed duplicate lock.

* CA-296490: Rewrote the logic uploading single updates so as to facilitate uploading to multiple pools in parallel.

* Corrections as per code review.

* Account for the case of uploading from disk legacy updates that do not correspond to an update alert.
Removed unfriendly error messages (the failure is written out in the logs anyway).

* Wizard test corrections and some modernising:
- Only call cancel on the last page if the test allows us to.
- Do finish the UpdatesWizard test.
- Finish the RunWizardKeyboardTests using key strokes instead of button clicks.
- Ensure the Cancel/Previous buttons do not have focus when sending an Enter stroke.
- Use optional parameters in the WizardTest constructor and string interpolation.

* Renamed badly named property.

* Improved code cloning VMs by assigning new opaque_refs to cloned VBDs.
Compacted test object provider: use optional parameters instead of method overloads.

* Modifications to prevent multiple update of enabled state and ensure the wizard
buttons are updated last.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-10 13:24:42 +00:00
Konstantina Chremmou
7a0658c908 Reduced accessibility of controls to private. Moved some of the wizard cancelling
logic to the last wizard page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Mihaela Stoica
42054964cd
Merge pull request #2361 from xenserver/feature/REQ-396
Merge feature/REQ-396 to master
2019-01-08 10:48:36 +00:00
Konstantina Chremmou
e59019858c Ensure we never attempt getting the file size if file is null
Fixes https://github.com/xenserver/xenadmin/issues/2356
Also, some code modernising.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-07 14:19:02 +00:00
Konstantina Chremmou
e32e67cd02 Added missing copyright notice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-02 12:54:08 +00:00
Konstantina Chremmou
e762dd04c7 Added readonly restrictions to DataGridViewRow cells.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Mihaela Stoica
138e5884b6 CP-30251: Show a warning if the feature is experimental
Use two separate feature flags, `guefi` and `guefi-secureboot`, with the following rules:
- If the feature is disabled, then the option is hidden in XenCenter.
- If the feature is enabled and experimental, then the option is visible and a warning is displayed in XenCenter (in the New Vm and Import wizards).

Also show the reason why a boot mode option is greyed out (when the uefi/uefi-secure boot mode is not supported in the selected template).

(On the Page_InstallationMedia control, I moved the BootModeContol and PvBootBox controls inside the TableLayoutPanel, to allow better alignment and for better visibility in the design mode)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-18 15:56:27 +00:00
Mihaela Stoica
d90340efbe CP-30251: Check version number to determine feature availability.
- In the New VM wizard, the boot mode control is only visible for Naples or greater hosts
- In the Import wizard, I had moved the boot mode options to a separate page, added after the target selection page, to allow the version check. The new "Boot options" page is only added for Naples or greater hosts.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-18 15:44:23 +00:00
Mihaela Stoica
703630ea36 Merge remote-tracking branch 'upstream/master' into feature/REQ-396
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/MessageAlert.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/VM.cs
2018-12-12 16:02:03 +00:00
Mihaela Stoica
fdbcdcf0e1 CP-29856: Support minimum number of vCPUs in guest templates (#2332)
* CP-29856: Support minimum number of vCPUs in guest templates

- Show a warning if the user wants to set a smaller number of vCPUs than the minimum specified in the template
- Add a null check; Set the warning label text before making it visible to avoid flickering.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-11 14:34:35 +00:00
Darren Matthews
e6d2861b9b L10N : Translation updates and resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-03 14:48:42 +00:00
Konstantina Chremmou
930f7380d3 CA-303201: Added null check for the update on host corresponding to the selected update.
If, for example, the host was disconnected, poolUpdateFromHost was null,
which was causing a silent exception resulting to an empty precheck list
shown on the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-03 10:44:35 +00:00
Mihaela Stoica
fe7b4b6297 CA-304025: XenCenter should not do an immediate toolstack restart if a host reboot is pending, but do the host reboot instead
If the update sequence for automated updates contains an update which requires a host reboot and a hotfix with an immediate toolstack restart (after-apply-guidance=restartXAPI and guidance-mandatory=true),
then XenCenter should do an immediate host reboot after applying the hotfix that required the immediate toolstack restart (as doing a toolstack restart when a host reboot is required is potentially risky)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-30 13:54:02 +00:00
Aaron Robson
7024c5b11f CA-300384: XC unable to create (GFS2) VDI of virtual-size larger than… (#2318)
* CA-300384: XC unable to create (GFS2) VDI of virtual-size larger than available storage when creating new VM.
Calling SR.VdiCreationCanProceed on the total space required of each SR as it takes into account that Thinly Provisioned SRs may overprovision in the same way that the NewDiskDialog does by effectively ignoring the free space limit.
IsSufficientFreeSpaceAvailableOnSrForVdi was not taking into account Thin Provisioning when checking if the virtual disk would fit on the SR and as a consequence would attempt to find another SR to place it on silently; either choosing "Local Storage" or "<no suitable storage>" depending on the size requested relative to the SR sizes.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>

* CA-300384: Hooking into the warning mechanism of the storage grid to ensure that the user is aware that over-provisioning is occurring, but not block them from continuing.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-28 16:32:40 +00:00
Mihaela Stoica
6cd2e28754 CA-300760: Only create the action that moves a halted VM if there are actually disks that need to be moved
- with this change the user won't see the misleading "Moving VM to new storage" in History if they tried to move the VM inside the pool, but actually didn't select different SRs for the VM's disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
8ab3ea2837 CA-300760: Allow intra-pool move of halted VMs through the wizard, even if the storage migration is not allowed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
88ec36ae5f CA-300760: Allow VM intra-pool migration through the wizard, even if the storage migration is not allowed
- if a VM can migrate inside a pool, then we will allow it in the wizard, even if storage migration is not allowed
- If it is a intra-pool migration (without moving the disks), then use the VM migrate action (which does a VM.pool_migrate), not the cross pool migrate action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Darren Matthews
97b847ffa6 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-11-22 23:48:28 +00:00
Konstantina Chremmou
243f3a209d CA-302807: Fixed issue where the server selection on the Patching wizard was
lost when leaving and returning back to the SelectServers page.
Also, the list of SelectedServers does not need to be re-evaluated every time
it is accessed but rather once when we move away from the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-22 13:58:19 +00:00
Aaron Robson
c597b2f795 CP-290940: Dundee is the earliest version to support Automated Updates, show a Server up to date tooltip for Dundee and later, where there are no updates to perform.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-22 10:47:23 +00:00
Aaron Robson
6f847962ca CA-272847: Compilation time is way overestimated (when creating a ser… (#2316)
* CA-272847: Compilation time is way overestimated (when creating a server status report).

- As the times are made up of server timeouts they overestimate quite significantly, we are removing the time estimates from the screen.
- Do not mention being able to see the time that has been removed inside the explanatory label.
- Removing further unused Util functions LThanTime and GThanTime.
- Redone the layout with the privacy link on a separate row to avoid wrapping at smaller sizes and to even up the layout of the Select/Clear buttons with the Total Size label.
- Fixed the tab indexes and removed the invisible Split Container.
- Adjusted the blurb margins to our default and set the last row with the privacy link to be AutoSize rather than absolute in case of truncation in other languages.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-19 12:27:31 +00:00
Mihaela Stoica
660eab5d99 CA-300759: When there is a GFS2 SR in the pool, VMs on local storage should still be allowed to be migrated to the local storage of another host.
When XenCenter checks if a VM can be storage-migrated (including in the same pool), it only checks if migration is possible to one SR (the first SR from the SR list  that supports vdi creation), which could be a GFS2 SR, where migration is not supported. With this fix, we will only consider the SRs which support migration (instead of vdi creation).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-16 11:50:12 +00:00
Tim Liu
0377db7be0 CA-301156: VM created from disk import for a UEFI VM has missing values (#2311)
* CA-301156: VM created from disk import for a UEFI VM has missing values

Set default params when importing VHD

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-11-16 10:03:18 +00:00
Konstantina Chremmou
f5174e5bfe Fixed issue where the patching wizard offered to re-apply an already applied
update if the user selected it from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
b7fd97af11 Removed obsolete UpdateType.Existing and associated properties and methods.
Also, simplified the logic selecting the single update when we leave the
SelectPatchPage so as to avoid ambiguities in which properties are to be set
and refactored the error handling methods to avoid duplicate checks and
provide the right error message (for example, the error message was misleading
for a non-existent path; or, the level of detail provided in the case of
invalid zip content was of lesser relevance to the user).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
67cc929f91 Fixed crash occurring on closing the PatchingWizard if the user uploaded a
legacy patch and then went back to select and install an update.

The code was removing all the uploaded legacy patches except the installed
ones. In this case the installed legacy patch is null hence all the already
uploaded patches need to be removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Darren Matthews
599d4ea7df L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-11-12 10:29:10 +00:00
Joey
6d2c3541f5 CP-29768: Add Skip functionality for RPU supp pack installation (#2283)
* CP-29768: Add Skip functionality for RPU supp pack installation

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* Minor corrections

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* Revert unnecessary layout changes

Also changed the title of the confirmation dialog to the wizard title, as it could be shown in either RPU or the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-07 18:07:53 +02:00
Konstantina Chremmou
9751de6d5e Fixed crash occurring when the user selected a single legacy patch, moved to
the Prechecks page, then back to select a single iso update, and forwards again
to the Prechecks page. The cause was that the values of Patch and PoolUpdate
were not always propagated from the Upload page to the following pages, hence
on that occasion they were both non-null, while the logic of the following
pages expects only one of the two to be non-null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
3e0a958783 Removed accessors that were set but never used. Removed unused constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
e63ca825e4 Fixed crash caused by code redundancy.
One of the PatchGridViewRow constructors was obsoleted, hence the _image and
_status cells and the row's PathPatch were always null. When a user selected a
patch, moved to the Prechecks page, back to the Select page, and the host got
disconnected, on moving to the SelectServers page and closing the warning pop-up,
XenCenter crashed because it was trying to update details of null cells. Also,
removed obsoleted toggling expanded state functionality.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
8b107c86e8 Renamed UpdateType NewRetail to Legacy.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Darren Matthews
c8ff108fef L10N: Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-25 09:32:42 +01:00
Aaron Robson
1e7b99c5c3 CA-299065: Duplicate host name in error message resolving in the Patching Wizard as well.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-24 14:25:24 +01:00
Aaron Robson
1a0a1f6359 CA-299065: Duplicate host name in error message in the RPU and Patching wizards. 2018-10-24 14:25:24 +01:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
f1d5abb7a5 Replaced duplicate events ItemSelectionNull and ItemSelectionNotNull with SrSelectionChanged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
e8ff04d671 Removed HostMaintenanceModeCheck; simplified logic by having the HostLivenessCheck
verify, if required, whether the host is enabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Aaron Robson
fbb8864a51
Merge pull request #2276 from xenserver/master
Merge master into feature branch
2018-10-18 15:08:54 +01:00
Konstantina Chremmou
90589a30c9 Modified treeview and toolbar updates (#2264)
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed.

* Removed some duplicate calls to RefershTreeView and UpdateToolbars because
they are called within the action's Complete event handler.
Also, normalise the way the treeview refresh is requested by the various actions the
commands are launching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Removed some explicit calls to refresh the treeview since this is done by
the connection result handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* The toolbars and tabs should be updated every time the treeview is refreshed.

This should happen when the refresh event is handled rather than calling
UpdateToolbars explicitly after a treeview refresh is requested; also, it is
the treeview refreshes that should be throttled and not the toolbar and
tab updates (the throttling mechanism may need correction).
Also, removed unnecessary Invoke as we are already on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Simplified UpdateManager.Update event declaration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-16 16:24:54 +01:00
Darren Matthews
5645cb9596 L10N: resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-16 12:38:36 +01:00
Darren Matthews
877f656d15 L10N: Translations updates (#2258)
* L10N: Translations updates
* L10N : Updated Ja homepage link

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-11 10:41:58 +01:00
=
e62096da26 CP-29106: XenCenter should disable the automatic check of VDIs
integrity and scare the user if it is turned on.

Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@citrix.com>
2018-10-11 08:13:56 +01:00
Darren Matthews
a8e03537a5 L10N : Translation updates and ReSync resx files
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-09 12:26:51 +01:00
Aaron Robson
6517403aa2 [aaf84eec] CA-298693: Using enum for memorymode to replace magic numbers.
Refactoring the memory spinner visibility logic for clarity in the New VM wizard.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Aaron Robson
3bd0a489f2 CA-298693: Going back to the Template tab of the NewVM wizard should not cause a different template to be selected, even if the template was selected outside of the form it should only initially set it.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Aaron Robson
edbf616ef8 CA-298693: Making the Static Maximum visible explicitly (with memory mode of 3) in the New VM wizard.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Ji Jiang
6a421173cc CP-29276: Implement update/supp pack application in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 12:32:01 +01:00
Ji Jiang
539d1850d0 CA-298913 + CA-297215: Fix KeyNotFoundException
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 11:12:50 +01:00
Ji Jiang
c31778c3fe CA-298913 CA-297215: Fix restartHost and restartXapi bugs after patching
With this change, following are working:
1) After applying XS75E003-5 only restart host, no restart toolstack
2) After applying vGPU driver on 7.4, restart host happens

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-05 15:45:05 +01:00
Mihaela Stoica
02075486ba
Merge pull request #2237 from xenserver/feature/REQ-488
Merge branch feature/REQ-488 into master
2018-10-05 09:41:21 +01:00
Aaron Robson
a6d1ad9bfa CA-297666: Wait for host to become enabled before resuming a VM in the patching wizard. (#2233)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-04 13:55:50 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Darren Matthews
47be1b0ecf L10N: CA-294292 resync Japanese and Chinese files. Truncation issues fixed.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
2b83de433d CA-294292: Layout modifications to fix error message truncation issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Aaron Robson
2f497e1053 CA-294286: New VM memory limitations shown
Added labels showing the VM memory limits posed by the template.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-26 11:06:24 +01:00
Konstantina Chremmou
95cd300e61 CA-210190 Memory spinner: removed the label so it's easier to align
the spinner with the surrounding controls on a parent control/form.
Also, removed the icon from the spinner because in the
majority of implementations it was invisible and the extra space was just
complicating the alignment of the surrounding controls.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-26 11:06:24 +01:00
Konstantina Chremmou
1d7008beab
Merge pull request #2227 from xenserver/feature/REQ-680
REQ-680: Rebranding XenServer to Citrix Hypervisor
2018-09-21 00:28:44 +01:00
Michael Z
40197ae2d0 REQ-680: Fix auto-merge errors.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-20 22:41:11 +08:00
Darren Matthews
2ae91f85e2 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-19 10:52:23 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Konstantina Chremmou
04b37092a6 CA-297020: Do not download imported appliance on a modal dialog (#2200)
* CA-297020: Do not download imported appliance on a modal dialog, but rather
asynchronously on the ImportSourcePage, so that the rest of XenCenter is usable
while the download is taking place; used the page's progress bar for this purpose
and removed the DownloadApplianceDialog.

* Corrections to the validation of the import source.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-14 15:55:05 +01:00
Michael Z
5e37264185 CA-297617: Change Citrix Hypervisor Tools to Citrix VM Tools.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 15:54:04 +01:00
Darren Matthews
fa5dd85c52 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-13 11:40:50 +01:00
Darren Matthews
99d0c6ed88 L10N : CA-294333 fixed with resx resync. Translation updates. (#2215)
* L10N: Translation and resx resync
* L10N: CA-294333 Overlap Issue fixed in redesign.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-12 23:44:16 +01:00
Konstantina Chremmou
c35a8f739d CA-294333: NewPolicySnapshotPage corrections + small checkbox bug (#2199)
* CA-294333: NewPolicySnapshotPage corrections.
- Fixed layout and accessibility of controls.
- Changed clickable info icons to normal icon+text info panels because they
are used more widely across XenCenter and the user does not need extra clicks
to access the information.
- Fixed bug where two clicks were required to check the quiescing checkbox
if the Disk and Memory radio was selected.

* Minor layout correction.

* Removed some obsolete code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-12 09:22:03 +01:00
Darren Matthews
d17dedc3fd L10N: CA-286950 Fixed truncation issue in Japanese and Chinese languages. Provide additional fix to the Chinese resource file.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-11 11:15:30 +01:00
Konstantina Chremmou
90183251d8 CA-297088: Fixed issue where XenCenter froze if a new server was added while
we were on the select host page of the Import and Migration Wizards.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-05 13:31:19 +01:00
Konstantina Chremmou
b634988c69 CA-297087: Fixed crash occurring when launching the Import Wizard without
having preselected a connection on the treeview. Also added a null check to
prevent crash if the connection is suddenly interrupted while moving away
from the select destination host page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-31 17:58:37 +01:00
Tim Liu
685a53bc22 CP-28679: XC: Allow choosing boot options during disk import (#2203)
* CP-28679: XC: Allow choosing boot options during disk import

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CP-28679: XC: Allow choosing boot options during disk import

1. Keep spaces instead of tabs
2. Update page header text to reflect the new control
3. Refine UI

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-31 02:02:33 +01:00
Konstantina Chremmou
a1033de3a4
Merge pull request #2206 from xenserver/master
Merging from master into feature/REQ-396 to fix broken tests
2018-08-29 15:17:44 +01:00
Konstantina Chremmou
ad773d8f75 Fixed null reference exception in tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-29 10:25:47 +01:00
Tim Liu
2cc5b1f0b6 CP-28676: XC: Allow choosing boot options during new VM wizard
1. Make controls auto sizable
2. Change hotkey
3. Rename variable

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
f0b1e6b3af CP-28676: XC: Allow choosing boot options during new VM wizard
1. Update the duplicated shortcuts on CPU&Mem Page
2. Default radio boxes invisible
3. Move hardcoded logic to VM.cs
4. BIOS boot should be always enabled
5. Move radio boxes to Installation Media page
6. Extract radio boxes as a user control
7. Update summary

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
98207906d7 CP-28676: XC: Allow choosing boot options during new VM wizard
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Darren Matthews
f7859a1596 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-23 08:41:13 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Darren Matthews
fc7ec88fd4 L10N: CA-294333 fixed overlap issue in JA resource file
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Tim Liu
d432cf5477 CA-293776: The order in which a single update is applied on the slave… (#2180)
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Apply the same Hosts sorting rules for all the PatchingWizard Pages .

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Place orderby clause after where clause

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-20 15:46:58 +01:00
Konstantina Chremmou
b36534c157 CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package. (#2183)
* CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 12:05:16 +01:00
Konstantina Chremmou
542da6487c Removed call to empty base method. Added erroneously removed comma.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
c67f85ebaa CA-210190: Fixed various layout and truncation issues on the VM/template memory
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
9b61298113 Added hotkeys; fixed tab order; fixed flickering of warning message on first load.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 14:09:36 +01:00
Konstantina Chremmou
c8c2ea448a CA-156828: Do not uncompress imported appliance on a modal dialog, but rather
asynchronously on the SelectImportSourcePage, so that the rest of XenCenter
is usable while the unzip is taking place; for this purpose a progress bar
was added on the page and the DecompressApplianceDialog was removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 10:59:35 +01:00
Konstantina Chremmou
f4d92da5ee CA-202377: Removed last instance of the QueuedBackgroundWorker and deleted the class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
78ecef617d Fixed issue where the agility calculation was run even for VMs that were not
actually added (because they can't be protected, e.g. the control domains).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
649e5a3483 Do not start updating the agility before reaching the corresponding page on the HAWizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
a68ca3beb2 Added tooltip on the Agility cell so the user can see the reason why the VM
is not agile simply by hovering over the cell. Previously the user could see
this only if they selected the VM, expanded the restart priority dropdown
and hovered over the Restart item.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
0827d686ba Added hotkeys to ToolStriMenuItems and ellipsis (in reality only the iscsiToolStripMenuItem
launches a dialog requiring user input, but added it to fcToolStripMenuItem
too because it looks symmetric and in any case the user does have to close
an error pop-up if the scan fails). Also, do not show "no SRs found pop-up"
if the user cancels the IscsiDeviceConfigDialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
serencorbett1
cb26b4a259 CP-28926: Block export of VMs with >2TB disks in ova/ovf format (#2162)
CP-28926: Block export of VMs with >2TiB disks in ova/ovf format

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-07 09:43:36 +01:00
Mihaela Stoica
b8168eed28 CA-292626: Consider the contains-livepatch flag of all the applicable… (#2165)
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.

Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-03 16:11:06 +01:00
timliu55
51ba3a82ce CA-293854: Patching wizard updates list loses selection and resizes c… (#2164)
* CA-293854: Patching wizard updates list loses selection and resizes columns when resorted
Remove the redundant code
Change the AutoSize mode from DisplayedCells to AllCells.
Fix the date column sorting
Disable column header AutoSizing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-03 11:32:51 +01:00
liulinC
7be8bd0530 CA-204242: save the server status report blocks xencenter (#2158)
* CA-204242: save the server status report blocks xencenter

Signed-off-by: Lin Liu <lin.liu@citrix.com>
2018-08-03 09:08:47 +01:00
Darren Matthews
a6991596a5 L10N Bug Fixes (CA-294292 & CA-294333) (#2163)
* L10N: CA-294292 Fixed truncation issue in language files.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-02 10:13:54 +01:00