Commit Graph

5519 Commits

Author SHA1 Message Date
Mihaela Stoica
aaa573dd21
Merge pull request #2438 from xenserver/feature/REQ-745
Merge feature/REQ-745 branch into master
2019-05-20 10:48:48 +01:00
Mihaela Stoica
36b1e44030 CA-310177: Use a new tooltip message when the selected iso is neither corrupted nor an update
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
6075f5185d CA-310177: Check if the selected iso file contains a valid ISO file system.
Also removed unnecessary call to OnPageUpdated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
32a41236a8 CA-317856: Ensure that VMs are repatriated after all hotfixes are appl… (#2436)
* CA-317856: Ensure that VMs are repatriated after all hotfixes are applied and the host has been rebooted.
- there is no need to remove the "reboot host" plan actions from the delayed actions list, because the action itself has code to check if a reboot is actually needed.
* CA-317856: Only add the "Exit maintenance mode" progress step if the host is in maintenance mode at that point.
- moved the AddProgressStep() call inside the function that checks if anything needs to be done (i.e. is host needs to be enables)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:32:25 +01:00
Mihaela Stoica
c96bf94f8c CA-318280: Add a null check for the VM.appliance property, as it could be null when read from the DR metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-15 13:16:21 +01:00
Konstantina Chremmou
2605955d2c
Merge pull request #2435 from MihaelaStoica/feature/REQ-745
Merge master into feature/REQ-745
2019-05-15 12:07:26 +01:00
Mihaela Stoica
8e5db5ce58 Merge branch 'master' into feature/REQ-745
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/AutomatedUpdatesBasePage.cs
#	XenAdmin/Wizards/PatchingWizard/PlanActions/RestartHostPlanAction.cs
2019-05-14 16:46:02 +01:00
Konstantina Chremmou
2fd49ba49b Updated bindings; includes CA-315688 (bumped API version to 2.14 for the plymouth release)
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-05-09 09:23:13 +01:00
Mihaela Stoica
f3064173e3 CA-304786: Fix the error where the Patching wizard cannot display available hosts when patch ISO is used by another process
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-26 12:14:38 +01:00
Andrew Kisliakov
d8341d5162 Correct spelling in Resolving Subjects Dialog
Signed-off-by: andrew.kisliakov@citrix.com
2019-04-26 12:13:06 +01:00
Darren Matthews
1100fb5199 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-25 16:29:56 +01:00
Mihaela Stoica
2f29450539 Add PlymouthOrGreater function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-25 16:29:43 +01:00
Konstantina Chremmou
4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
Konstantina Chremmou
8492d2713a No need to set ShowProgress to its default value. Removed unused constructor. Compacted Properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
7c2c970423 Fixed typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
c3f77a7113 Increased slightly the size of the dialog to avoid message truncation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
f55e797bf6 Changed the logical order of the instructions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
6273856761 Prevent VisualStudio's designer from crashing when opening the MainWindow.
Made command parameterless constructors public; made browsable events public;
replaced manually written with auto-generated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
c444d21719 Removed duplicate resource.
Also, renamed message to match naming convention for same category messages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
3d75d5396a Removed obsolete file from the list of dependencies.
Also, removed duplicate code from utility script.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Mihaela Stoica
273c9f3394 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-16 23:01:11 +01:00
Mihaela Stoica
a069338191 CA-313224: Update the description of the Health Check Service in the localised installer
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-16 22:27:10 +01:00
Darren Matthews
bc009bda2c L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-04 09:05:50 +01:00
Mihaela Stoica
9e100f4fb9 CP-31022: Update the "XenCenter out-of-date" message
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-01 17:43:01 +01:00
Konstantina Chremmou
3fb670a5f5 CA-311238 refix: when creating a session from another Session object, copy over its properties.
Also, removed unused private static constructor.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-01 17:42:42 +01:00
RoryBG
80333d5aa4 CP-29310 & CP-30765: added support for the new xxHash-based VM imports and exports (#2411)
* added support for the new xxHash-based VM imports and exports
* added xxHash to the legal notices
* added Citrix copyright notice
* removed redundant code and made use of unused variable

Signed-off-by: Rory Bertuzzi-Glover <rory.bertuzzi-glover@citrix.com>
2019-03-26 16:06:25 +00:00
Darren Matthews
3e4108cef8 L10N : translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-03-26 12:08:55 +00:00
Konstantina Chremmou
b33e08b73e CP-30918: Show warnings if GFS2 SRs are not used with multipath.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-25 06:48:41 +00:00
Konstantina Chremmou
8bdc8816c3 CA-309152: Remote logging is offered in addition to local and not instead of it (#2405)
* The radiobuttons local-remote gave the impression the two types of logging
were mutually exclusive. Use a checkbox instead to make it obvious that
the logs are directed to a remote server in addition to being stored locally.

* Updated log destination display on the General TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-21 13:35:26 +00:00
Konstantina Chremmou
dd6dd86f5d Use the 32x32 warning icon on the certificate warning dialogs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-20 16:58:02 +00:00
Konstantina Chremmou
cad6239c3d Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors
and removed static method creating the dialog from XenObject; the constructor
can be used for this purpose if the command's CantExecuteReasons are keyed
on IXenObjet instead of SelectedItem.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-20 16:58:02 +00:00
Konstantina Chremmou
24664dbd75 Enforce icon size 32x32 on ThreeButtonDialog. Compacted constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-20 16:58:02 +00:00
Konstantina Chremmou
66829d7a91 Refactoring to the MeddlingActionManager.
Removed unnecessary ITaskSpecification interface and its inefficient
implementations; compacted methods to make following the logic easier
and avoid duplicate dictionary lookups.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-18 13:26:48 +00:00
Aaron Robson
cdc8de930f CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358)
- On the dialog show the next run time in both the client's and the server's local time zone.
- On the VMSS frequency page allow the user to pick the schedule in the client's
  local time zone and show then next run time in both the client's and the server's local time zone.
- Refactoring to fix workflow and class design, reduce amount of code and simplify logic.
- Various layout improvements.

Signed-off-by: Aaron Robson aaron.robson@citrix.com
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-15 14:10:42 +00:00
Mihaela Stoica
97101ca2e8 CA-309844: Fix meddling actions
- Refactored MeddlingAction and Task classes: moved the logic for building a MeddlingAction outside the Task class and switched to using the vm_operations enum to identify which tasks are suitable for MeddlingAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-15 09:42:04 +00:00
Konstantina Chremmou
788421f3f8 Removed specific version example as it is outdated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
70b8002c0b Correction to tab indices and label alignment.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
799157a20b Changed small info icon to match the one used on other pages. Minor text and margin correction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
3c730a0c01 CA-310980: Show successful completed status on the patching page when no action is to be taken.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:58:24 +00:00
Darren Matthews
fdb14149f3 L10N : Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-03-13 11:06:42 +00:00
Mihaela Stoica
94ecd4f21c Fix RestartHostPlanAction
- if we decided to skip the host restart, then we should really skip it

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-12 11:22:04 +00:00
Mihaela Stoica
dc333963b6
Merge pull request #2406 from xenserver/master
Merge master into REQ-745
2019-03-12 09:41:39 +00:00
Mihaela Stoica
d9ea36b33d CP-30785: Replace xenserver.org links in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-08 10:22:41 +00:00
Mihaela Stoica
fd083584a9 Update API bingings (including the API version bump)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-08 10:08:00 +00:00
Mihaela Stoica
2d1d1fe5a7 CA-309758: Change the order of filters
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-04 11:06:59 +00:00
Mihaela Stoica
4abe4ddb30 CA-309758: Optimisations to the way we assert if Vms can be migrated to a destination pool in the Cross Pool Migrate wizard
- When asserting if a VM can be migrated to a pool we don't have to check all the hosts in the pool at this point, we can enable the pool when we find the first host where migration is possible; we will check the rest of the hosts only if that pool is selected.
- If the destination pool is older than the source, then we don't need to do any server calls because we know that migration to an older host is not allowed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-04 11:06:59 +00:00
Mihaela Stoica
0df39a9d83 CA-310766: Use a dictionary instead of multiple lists
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-26 17:38:37 +00:00
Ji Jiang
ea1cd77306 CA-310766: Fix format SR type bug in Hardware HBA new SR wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2019-02-26 17:38:37 +00:00
Darren Matthews
597813723d L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-26 11:54:11 +00:00
Konstantina Chremmou
2c884ea47f CA-311146: Copy the results of a linq query to a list to prevent
enumeration on modified collection (it also improves efficiency).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-26 11:18:53 +00:00