Commit Graph

4213 Commits

Author SHA1 Message Date
Mihaela Stoica
c061b0f57d CA-257574: Manage vApps dialog is unusable with a vApp containing a l… (#1664)
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs

- In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows.
- Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed.
- Also improve the way we update the VM startup options and HA restart priorities on a set of VMs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review

- reverted the changes to the AssignVMsToGroup actions that added the additional constructor
- changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently
- added code to deregister PropertyChanged events on VM_appliances
- removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 17:32:46 +01:00
Mihaela Stoica
94f3650c16 Merge pull request #1662 from GaborApatiNagy/CA-257553
CA-257553: Unexpected error on the Memory tab while running an "Instant VM create" action
2017-06-26 12:39:01 +01:00
Cheng Zhang
283a80997f CA-187179: Refine error message when pool auth disable (#1663)
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2017-06-23 11:23:38 +01:00
Gabor Apati-Nagy
10e2aff2e4 CA-257553: Unexpected error on the Memory tab while running an "Instant VM create" action
Calling Rebuild() from the event thread now

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-22 15:49:15 +01:00
Vetrivel Chinnasamy
1fce4298e5 L10N: Fix CA-255548 & translation updates (#1660) 2017-06-22 09:19:58 +01:00
Mihaela Stoica
15d748925a Merge pull request #1641 from letsboogey/CA-220169
CA-220169 - Network heartbeat status initially shows 'Error' after en…
2017-06-21 17:02:36 +01:00
Mihaela Stoica
bfab94f923 Merge pull request #1653 from letsboogey/CA-177402
CA-177402 - XenCenter doesnt show migrate option on selecting multipl…
2017-06-21 10:11:45 +01:00
Mihaela Stoica
1feff2b08f Merge pull request #1659 from stephen-turner/lexica2
Fix several usage errors identified by Lexica
2017-06-20 16:12:28 +01:00
Letsibogo Ramadi
a579ac9196 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Enable CrossPoolMove for a single VM too

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 15:00:49 +01:00
Letsibogo Ramadi
c1635fba58 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Renaming and minor refactoring

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 14:56:26 +01:00
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Letsibogo Ramadi
1e07f7b1b1 Merge pull request #1640 from kc284/master3
Modified the help script used for downloading dependencies so that the domain…
2017-06-20 13:55:20 +01:00
Gabor Apati-Nagy
46edc78e50 Merge pull request #1654 from MihaelaStoica/CA-241298
CA-241298: Do not offer to install tools if the VM runs on a slave in…
2017-06-20 13:27:04 +01:00
Konstantina Chremmou
d88fc10e3f Merge pull request #1649 from letsboogey/CA-247333
CA-247333 - Remove rdpclient6 code after April 2017
2017-06-20 13:19:52 +01:00
Letsibogo Ramadi
a17063ec7d CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 12:29:03 +01:00
Mihaela Stoica
c49587090e Merge pull request #1650 from GaborApatiNagy/CA-243675
CA-243675: No Clear error message when proxy server which is configured is not running
2017-06-20 11:46:59 +01:00
Gabor Apati-Nagy
ee2f1ef920 Merge branch 'master' of https://github.com/xenserver/xenadmin into CA-243675
Conflicts:
	XenModel/Messages.resx
2017-06-20 11:40:03 +01:00
Letsibogo Ramadi
cca0ab5d89 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant
-Removed rdpControl because it is always identical to rdpClient9
-Renamed rdpClient9 to just rdpClient because we use only one
client so there is no need to distinguish, and it can easily be updated
to future versions.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 11:33:52 +01:00
Gabor Apati-Nagy
b155452309 CA-243675: Sorted Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-20 11:14:55 +01:00
Mihaela Stoica
3cf18fe757 Merge pull request #1655 from anoobs/vnc_improvements_v2
CA-256543: Added KP0-9 to keymap
2017-06-20 10:37:18 +01:00
Stephen Turner
910d2afed6 In New VM Wizard, on affinity page, state that memory is RAM not disk space 2017-06-20 09:08:07 +01:00
Stephen Turner
0b41f06e35 Fix several spelling mistakes found by Lexica 2017-06-20 08:57:58 +01:00
Mihaela Stoica
5783904d0a Merge pull request #1656 from stephen-turner/UpdateRoot
Remove case that is no longer hit, and that causes confusion because …
2017-06-19 13:38:24 +01:00
Anoob Soman
7ef553f0d0 CA-256543: Added KP0-9 to keymap
QEMU EXT_KEY_ENCODING expects keysyms to KP0-9 to be sent, inorder to
figure out if NumsLock was pressed when VncClient was out of focus.

Adding KP0-9 to keymap, makes XC send correct keysym.
2017-06-19 11:29:23 +01:00
Mihaela Stoica
410e77d94e CA-241298: Do not offer to install tools if the VM runs on a slave in a partial upgraded pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-16 16:49:06 +01:00
Konstantina Chremmou
8c85e77974 CA-257209: Missing right quotation mark broke the build.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-16 15:02:35 +01:00
Letsibogo Ramadi
ddd481fff0 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-16 14:38:22 +01:00
Gabor Apati-Nagy
71ed9d8955 Merge pull request #1651 from kc284/master
CA-257209: The VNCControl has been deprecated.
2017-06-16 14:12:41 +01:00
Mihaela Stoica
7cd7be6d03 Merge pull request #1648 from GaborApatiNagy/master_fixbuild
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-16 09:43:53 +01:00
Konstantina Chremmou
0a06c363bb Modified the help script used for downloading dependencies so that the domain
can be passed in as a parameter and authentication is not required. For this
purpose the artifactory download patterns had to be expanded so as to be
understood by wget.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-16 08:58:13 +01:00
Konstantina Chremmou
39f3e9ea1e CA-257209: The VNCControl has been deprecated. 2017-06-16 08:55:38 +01:00
Gabor Apati-Nagy
9806491863 CA-243675: No Clear error message when proxy server which is configured is not running
Mention proxy in the suggestion that is shown when a connection fails

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 17:54:27 +01:00
Gabor Apati-Nagy
c19ee0bf13 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Fixed build by removing unused fields that caused the Release build to fail. Removed more dead code.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:11:05 +01:00
Gabor Apati-Nagy
9b336ec3c6 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Put back code that shouldn't have been removed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:09:32 +01:00
Mihaela Stoica
cd71c4fe1c CA-249858: Fix build warning as error
(The member 'CanExecute()' does not hide an inherited member. The new keyword is not required)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-15 08:31:47 +01:00
Konstantina Chremmou
062938878d Merge pull request #1602 from GaborApatiNagy/master_CA-220047
CA-220047: Show proper precheck error when a VM cannot be migrated
2017-06-15 08:24:06 +01:00
Letsibogo Ramadi
5e458ac234 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant 2017-06-14 17:22:42 +01:00
Gabor Apati-Nagy
42b4076c5d CA-220047: Show proper precheck error when a VM cannot be migrated
Improved wording

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-14 15:40:17 +01:00
Letsibogo Ramadi
be6b2ebcb3 Merge pull request #1630 from kc284/master
One more take to CA-231518
2017-06-14 13:37:13 +01:00
Gabor Apati-Nagy
5fe4b8ba09 Merge pull request #1639 from GaborApatiNagy/CA-255547
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-14 10:02:36 +01:00
Letsibogo Ramadi
3a94992c10 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Correct spelling
2017-06-14 09:59:25 +01:00
Gabor Apati-Nagy
4e8541fb91 Merge pull request #1642 from MihaelaStoica/CA-249858
CA-249858: XenCenter gives different messages for migrate VM at diffe…
2017-06-13 16:53:19 +01:00
Mihaela Stoica
a79e156cf5 CA-249858: Moved the Trim call
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 16:47:43 +01:00
Mihaela Stoica
1d94fe3a99 Merge pull request #1645 from xenserver/CA-249084
CA-249084: Fixed Debug build Assert
2017-06-13 15:51:59 +01:00
Gabor Apati-Nagy
3a9c733ead CA-249084: Fixed Debug build Assert 2017-06-13 15:51:00 +01:00
Gabor Apati-Nagy
f413f814a7 Merge pull request #1643 from MihaelaStoica/telemetry
CP-22471: Add information on XenCenter help usage to the user settings
2017-06-13 14:14:08 +01:00
Mihaela Stoica
77b73c8d16 CP-22471: Add information on XenCenter help usage to the user settings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:42:26 +01:00
Mihaela Stoica
f815663376 Merge pull request #1635 from kc284/master2
Removal of obsolete code
2017-06-13 13:20:17 +01:00
Mihaela Stoica
8f6c345c66 CA-249858: XenCenter gives different messages for migrate VM at different screens when pool connected with vm-operator user
Expose the reasons why a cross pool migration command cannot execute.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:12:01 +01:00
Letsibogo Ramadi
f1d2dc2cf8 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Network HB initially shown as error because it takes time for the status to be
read from xha by xapi. This adds a delay to allow the status to be updated
before XC displays it.
2017-06-13 11:17:49 +01:00