Commit Graph

882 Commits

Author SHA1 Message Date
Danilo Del Busso
f2fdf31a5a
CP-36392: Avoid multiple enumerations in LicenseStatus.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-11-17 09:01:25 +00:00
Danilo Del Busso
47510f5b07
CP-36392: Reassign expiryGroups after ordering
regression from db2c00d5

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-11-16 11:39:50 +00:00
Danilo Del Busso
68b54682ae
CP-36392: Move param checks outside of RepairSRDialog.cs's constructor
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-11-15 10:05:08 +00:00
Danilo Del Busso
cc917e2a66
CP-36392: Simplify if and else if blocks to reduce nesting in AddServerDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-11-15 09:57:08 +00:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
2021-10-27 13:24:23 +01:00
Konstantina Chremmou
f2d81d5744
Merge pull request #2869 from danilo-delbusso/CP-36392
CP-36392: Address Security Features and Code Smells
2021-10-26 16:54:34 +01:00
Konstantina Chremmou
45fe1f436b CA-359795: Fixed issue whereby a double error was shown when a non-privileged user attempted to apply a licence.
Removed ApplyLicenseEditionCommand as it was unnecessary (there was no
button/menuitem calling it). Use the ApplyLicenseEditionAction instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-10-26 00:47:08 +01:00
Konstantina Chremmou
5c66471db0 CA-359793: Fixed stray label showing while entering maintenance mode.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.cs
2021-10-26 00:47:08 +01:00
Konstantina Chremmou
6b7cd1d9e5 Corrected calculation of datasource units (CA-359068). New/Edit Graph dialog enhancements.
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
  for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
  visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-10-12 12:28:42 +01:00
Danilo Del Busso
69722d93bd
CP-36392: Rename key constants in WlbReportSubscription.cs to avoid field clash
Names are amibguous
Also made the fields `const`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-05 11:56:15 +01:00
Danilo Del Busso
db2c00d54d
CP-36392: Cast operands of divisions to not lose precision
Cast to `decimal` or `float` to keep floating-point precision

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-04 16:22:29 +01:00
Danilo Del Busso
dcbaf5d1a4
CP-36392: Amend calls that generate unused return values
Mixture of correctly implementing `Trim()` calls, and removing calls that generate useless ephemeral variables.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-04 15:42:40 +01:00
Danilo Del Busso
408cf98add
CP-36392: Add miscellaneous null checks
Also tidy up code
Also remove method in `SnapshotTreeView.cs` that wasn't used, which necessitated a null check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-04 15:42:07 +01:00
Danilo Del Busso
df53a4cd98
CP-36392: Refactor useless null checks in actions constructors
Also remove useless `this` usage

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-04 15:41:59 +01:00
Danilo Del Busso
0623717627
CP-36392: Replace custom Utils method with direct calls
`ThrowIfEnumerableParameterNullOrEmpty` adds complexity

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-04 15:09:00 +01:00
Konstantina Chremmou
d59a61991e CP-36908: Remove support for xscontainer supp-pack from stockholm.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/PauseDockerContainerCommand.cs
#	XenAdmin/Commands/RestartDockerContainerCommand.cs
#	XenAdmin/Commands/ResumeDockerContainerCommand.cs
#	XenAdmin/Commands/StartDockerContainerCommand.cs
#	XenAdmin/Commands/StopDockerContainerCommand.cs
#	XenAdmin/Controls/DeprecationBanner.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/Utils/Helpers.cs
2021-09-23 10:44:43 +01:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:17 +01:00
Danilo Del Busso
4b0b83245f
CP-34231: Remove language with negative connotations (#2860)
* CA-34231: Replace negative language with `block list` in code and references

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `stop` in code and references

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `freezing` in code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run/ran` in code comments

Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
#	XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
#	XenAdmin/Dialogs/Wlb/WorkloadReports.cs

* CA-34231: Replace negative language with `run` in Command.cs Run method

Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/GeneralTabPage.cs

* CA-34231: Replace negative language with `run` in Command.cs CanRun method

Used Resharper rename utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DRConfigureCommand.cs
#	XenAdmin/Commands/DRDryrunCommand.cs
#	XenAdmin/Commands/DRFailbackCommand.cs
#	XenAdmin/Commands/DRFailoverCommand.cs
#	XenAdmin/Commands/DisasterRecoveryCommand.cs
#	XenAdmin/Commands/VMGroupCommand.cs

* CA-34231: Replace negative language with `run` in Command.cs RunCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in Command.cs

Also applied to related symbols. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in methods named CanRun

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/CrossPoolMigrateCommand.cs

* CA-34231: Replace negative language with `run` in remaining Run methods

Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in Commands folder

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder

Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
#	XenAdmin/Dialogs/Wlb/WorkloadReports.cs
#	XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs

* CA-34231: Replace all remaining negative language with `run` in code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/Controls/WlbRecommendations.cs
#	XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
#	XenModel/WLB/WlbScheduledTask.cs

* CA-34231: Replace negative language with `supporter` or `bond member` in code strings

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace remaining negative language with `supporter` in .resx files

Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in CFUValidator code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	CFUValidator/CFUValidator.cs

* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method

Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
#	XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs

* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`

Used ReSharper renaming utility. Excluded jp and zh resources

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.resx

* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`

Used ReSharper renaming utility. Excluded jp and zh resource files.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.resx

* CA-34231: Rename missing language references for change to `coordinator`

Misc files were not saved before last commits.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/HACommand.cs
#	XenAdmin/TabPages/AdPage.cs
#	XenModel/Actions/Network/CreateBondAction.cs
#	XenModel/Actions/Network/NetworkAction.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`

Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/AddHostToPoolCommand.cs
#	XenAdmin/Commands/HACommand.cs

* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/AddHostToPoolCommand.cs

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenSearch/Columns.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/Network/CreateBondAction.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
#	XenModel/Messages.resx

* CA-34231: Rename dialogs to replace negative connotations with `main`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`

Also updated its resx file. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs

* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Update class names in HelpManager.resx

Following renaming of main password dialog. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `Metadata.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`

Used ReSharper renaming

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`

Used ReSharper

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language in solution

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Remove commented out code in VNCGraphicsClient.cs

Code has only been improved partially as it's not strictly relevant to the PR

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend negative word replacement in XSVNCScreen.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Simplify debug call formatting in NewPoolDialog.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Add code mistakenly removed in MainWindow.cs

Removed as part of `f155f9c8`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Revert renaming of constant related to Windows' API

Considered external to CH Center

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`

Previous ALT+<key> hotkey was conflicting with CreatePool

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs

Not relevant to the PR, but the change is small enought to no need extra testing

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend typo in PoolJoinRules.cs

supporer -> supporter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`

Variables and methods XenAPI-Extensions were mistakenly skipped

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`

This is only used to format the string

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`

Done in order to fix merge conflict into master

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend misc negative language renaming typos

`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-31 11:31:16 +01:00
Danilo Del Busso
bcc5cf8166
CA-310974: Hide GPU page if the host has no GPU capability (#2847)
* CA-310974: Hide GPU page if the host has no GPU capability

* Hid GPU page in PropertiesDialog
* Hid GPU page in NewVMWizard

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Move GPU availability check to Helpers class

* Switch from field to method based check
* Update affected logic
* Remove rubric toggle in PopulatePage when GpuEditPage is shown
* Hide AddVGPUDialog when GpusAvailable returns false

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Remove missing GPUs strings in Messages.resx

* GPU_RUBRIC_NO_GPUS_POOL
* GPU_RUBRIC_NO_GPUS_SERVER

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Disable combobox in AddVGPUDialog when there are no GPUs

Avoids exception being thrown if user tries to select empty first item

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Amend position of GPU availability check

Moved since gpuCapability is used in the Finish method of the wizard

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Remove unecessary null checks in Helpers method

The Cache and its properties (e.g. GPU_groups) are readonly and initialised as empty.
The API object properties that are ref lists (g.PGPUs, g.supported_VGPU_types) are also initialised as empty and are demarshalled by the SDK as empty if they have no values.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-23 10:58:41 +01:00
CitrixChris
dbd5f0c344
CA-349435 - Fixed tooltip display on Options and Properties dialogs (#2841)
* CA-34935 ConnectionOptions invalid tooltip now dissappears when page changes or when the dialog moves

Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>

* CA-349435 modified IOptionsPage & IEditPage to include a Hide Tooltip method, implemented it in all relevant classes. Hooked up events in the options dialog & properties dialog to hide tooltips on tab change or dialog move

Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>

* CA-349435 removed duplicate pages that were added accidently/automatically

Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>
2021-08-23 10:34:46 +01:00
Danilo Del Busso
5a0094341b
CA-339590: Add conditional page control refresh in HA Wizard (#2846)
* CA-339590: Add conditional page control refresh in HA Wizard
* CA-339590: Remove remaining HA Wizard page control reloads
Removed PopulatePageControls method and used PopulatePage override instead.
Removed IsDirty implementation from AssignPriorities.
* CA-339590: Remove useless calls to IsDirty in AssignPriorities
Call did not serve any purposes after previous switch to PopulatePage method
* CA-339590: Remove `IsFirstLoad` check for SR scan in HAWizard
Check was not necessary for CA-339590

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-16 11:01:35 +01:00
Konstantina Chremmou
af832f23cf
Merge pull request #2848 from kc284/datasources
* DataSet field Uuid is not really a uuid. Renamed to Id to avoid misunderstandings.
* Renamed properties DataSet.Type and DataSourceItem.DataType to Category. The old name was not reflecting what they were.
* Renamed property DataSet.TypeString to DataSet.DataSourceName so it reflects better what it is.
* Renamed property DataSet.Name to DataSet.FriendlyName for clarity. Removed duplicate string.Format() call.
* The DataSourceItem.Uuid is not really a uuid. Renamed it to Id to avoid misunderstandings. Also, compacted DataSourceItem constructors.

* Removed unused and duplicate properties.
- DataKey.Hide was unused. Once removed, DataSet.Deselected was unused, hence was also removed.
- Dataset.Draw was duplicating DataSet.Show, hence was removed.
- DataSet.NeverShow is not necessary, DataSet.Hide can be used both for datasources
  that should not be shown at all as well as datasources that are wrong for this object.

* Made DataSet.FriendlyName a get-only property and compacted repetitive code.

* Use the Helpers regular expressions for assigning the datasource category.

* Removed id from the DataSet constructor parameters. It can be constructed from the XenObject and the datasource name.

* Compacted the code for readability (it was difficult to follow the build of the URIs).

Also, removed use of Helper.GetUuid to avoid the use of reflection. Minimised casts.

* CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name.

- Also, merged static method DataSet.Create into the DataSet constructor.
- Minor restructuring of the ArchiveMaintainer file (moved all private fields
  and properties closer together).
- Added new resource file so the units can be separated from Messages.
2021-08-10 14:43:05 +01:00
Konstantina Chremmou
2d356bef47
Merge pull request #2824 from kc284/wlb
Some code removal and workflow fixes around WLB reports (includes CA-339666).
2021-08-10 14:34:17 +01:00
Konstantina Chremmou
9eac324ed9 Renamed properties DataSet.Type and DataSourceItem.DataType to Category.
The old name was not reflecting what they were.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:13 +01:00
Konstantina Chremmou
461f180aaa Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/BugToolWizardFiles/BugToolPageRetrieveData.cs
#	XenModel/Actions/VM/ImportVmAction.cs
2021-07-25 15:25:32 +01:00
Konstantina Chremmou
e368d74330 DelegatedAsyncAction should only be used for simple API calls, hence created new class for retrieving WLB host evacuation recommendations.
This allows removal of DelegatedAsyncAction.ResultObject, which might lead to complicated implementations.
Also: some refactoring of the other WLB retrieve recommendations actions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-07-23 09:40:12 +01:00
Konstantina Chremmou
3251ddf495 CA-355018: Ensure disabled health check status is reflected in the cache before re-rerunning prechecks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-08 15:57:08 +01:00
Konstantina Chremmou
2defc1dbff Fixed workflow when loading the WorkloadReports dialog (includes CA-339666).
- Fixed exception handling in RetrieveWlbConfiguration action (exceptions of type
  other than Failure were silenced).
- CA-339666: Fixed control flickering when showing the WorkloadReports dialog.
- Retrieve the WlbConfiguration before attempting populating the controls.
- If the dialog was launched requesting a certian report to be run, the report
  was not selected on the list.
- Some refactoring to simplify the code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-27 15:39:52 +01:00
Konstantina Chremmou
393e041c4f Removed commented out and dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-27 11:30:58 +01:00
Konstantina Chremmou
3082745c85 Tidied up WLB report files:
- Moved the business logic classes to XenModel close to their base class.
- Moved WorkloadReports dialog close to the other WLB dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-26 17:54:53 +01:00
Konstantina Chremmou
33295bfc1b CA-354879, CA-354877: Branding and version corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-26 00:37:25 +01:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Joey
a56a383ec0
CP-35687: Detach update mechanism from update wizard (#2812)
* CP-35687: Detach update mechanism from update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-35687 part 2: Removed updates mechanism.
* Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 15:13:45 +01:00
Konstantina Chremmou
88c923b11c Removed colour settings for unsupported windows versions.
Note that OS.Version.Major=6 covers up to and including the supported Win8.1 and
WS2012, but there is not point in using earlier windows colour schemes for them.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
0fc835a194 Removed BlueBorderPanel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
75b05f81a2 CP-35350: Moved WLB server icon to the branding folder. Use different arrow files on the WLB credentials dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
2dff51f4cc CA-353426: Button text was truncated in Japanese.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:44 +01:00
Konstantina Chremmou
b116c4713d CA-353524: Full copy of VM on the same SR is allowed.
Moving and copying a VM should be treated differently, hence we need a different
SrPickerItem subclass for each operation. Minor logic simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:27 +01:00
Konstantina Chremmou
6d8ad062f8 CA-353070: Corrected wizard title. Fixed navigation with the Tab key.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-08 17:28:48 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
e5bee7be6a Added Events in progress to the outlook-style status labels of the main window.
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:30 +01:00
Konstantina Chremmou
35e1d68afa CA-352901: Fixed window title and translations for window title and menu item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-01 11:30:54 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-17 15:30:59 +00:00
Mihaela Stoica
96956dbc81 CA-352663: Fix button action on Custom Field deletion confirmation dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-16 00:13:06 +00:00
Konstantina Chremmou
0c572a1d6d Normalised usage of the UpsellDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-03 13:50:29 +00:00
Konstantina Chremmou
79d8b00de8 Replaced AllowUpdatesDialog with a ThreeButtonDialog.
For reasons of code reduction and also because the look and feel of this dialog
was slightly different from the usual application pop-ups.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-03 13:50:29 +00:00
Konstantina Chremmou
51dedff3c4 Rebrand Branding.resx instead of the BrandManager.cs. Sorted variables alphabetically and removed unused variable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-03 13:50:29 +00:00
Konstantina Chremmou
a109f5f22d Pascal-cased method name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Darren Matthews
a8988276be L10n : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2021-03-02 09:44:29 +00:00