Commit Graph

5264 Commits

Author SHA1 Message Date
Darren Matthews
c8ff108fef L10N: Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-25 09:32:42 +01:00
Aaron Robson
1e7b99c5c3 CA-299065: Duplicate host name in error message resolving in the Patching Wizard as well.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-24 14:25:24 +01:00
Aaron Robson
1a0a1f6359 CA-299065: Duplicate host name in error message in the RPU and Patching wizards. 2018-10-24 14:25:24 +01:00
Mihaela Stoica
fe359cc3f9 CA-300368: Move dictionary outside of the method
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-24 13:43:05 +01:00
Mihaela Stoica
41d6764b1c CA-300368: Sanitize fields values when loading a xapi xml database in XenCenter
This fixes the bug where importing a xapi database to xencenter fails with "This server version is incompatible with XenCenter" due to the product brand containing a space character.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-24 13:43:05 +01:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
f1d5abb7a5 Replaced duplicate events ItemSelectionNull and ItemSelectionNotNull with SrSelectionChanged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0fe584cdba Removed unnecessary method and replaced it with the field it returns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0eef02fc3b Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Aaron Robson
312ed10b80 CA-293814: If there are no VMs running, immediately start entering Ma… (#2253)
* CA-293814: If there are no VMs running, entering Maintenance Mode without showing Dialog.

* CA-293814: Refreshing the view after shortcutting entering the mainenance view (no running VMs so no window shown) in the same way as the rest of the updates are managed.
Please see: https://github.com/xenserver/xenadmin/pull/2264

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-24 11:42:13 +01:00
Aaron Robson
97cd8286b9 CA-203431: Host name is repeated twice in multipathing alert message in XC (#2272)
* CA-203431: Removed prefix comma and space from the start of the list of hosts in the multipathing alert message.

* CA-203431: Removed duplicate Host names from multipathing alert message.

* CA-203431: Unit tests for MessageAlert.FindHostUuids with tweaks to allow it to handle a null input as if it was an empty enumeration.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-23 14:50:28 +01:00
Aaron Robson
1ef23f393f CA-298921: End of error message in XenCenter is cut off when failed t… (#2273)
* CA-298921: End of error message in XenCenter is cut off when failed to start VM, word wrapping on the Reason column (and top aligning the other columns) for consistency.

* CA-298921: Adjusted the padding of the icon.

* CA-298921: Removed null Bitmap from .resx.

* CA-298921: Resolving text alignment issues with single line (i.e. short) Reasons.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-23 13:06:02 +01:00
Aaron Robson
525034d233 CP-14807: Delete OEM in ServerVersion (#2270)
* CP-14807: Delete OEM in ServerVersion

* CP-14807: Removing unused IgnorePatchAction and IgnoreServerAction classes (moving their constants to the Updates class).

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-22 14:34:31 +01:00
Konstantina Chremmou
e8ff04d671 Removed HostMaintenanceModeCheck; simplified logic by having the HostLivenessCheck
verify, if required, whether the host is enabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Konstantina Chremmou
0d0aa34f37 CA-299356: If there are any broken SRs, show all of them when running prechecks
instead of finishing the precheck after the first one is found.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Mihaela Stoica
8c5e08294c CA-299946: Resolve the VM before locking it
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-22 13:46:03 +01:00
Darren Matthews
176624e029 L10N: Translation updates and resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-21 13:53:09 +01:00
Mihaela Stoica
ea7d522cf7 Fix the tests after changes in commit b6420b6c
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-19 10:25:54 +01:00
Konstantina Chremmou
90589a30c9 Modified treeview and toolbar updates (#2264)
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed.

* Removed some duplicate calls to RefershTreeView and UpdateToolbars because
they are called within the action's Complete event handler.
Also, normalise the way the treeview refresh is requested by the various actions the
commands are launching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Removed some explicit calls to refresh the treeview since this is done by
the connection result handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* The toolbars and tabs should be updated every time the treeview is refreshed.

This should happen when the refresh event is handled rather than calling
UpdateToolbars explicitly after a treeview refresh is requested; also, it is
the treeview refreshes that should be throttled and not the toolbar and
tab updates (the throttling mechanism may need correction).
Also, removed unnecessary Invoke as we are already on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Simplified UpdateManager.Update event declaration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-16 16:24:54 +01:00
Mihaela Stoica
01e8e3feed
Merge pull request #2251 from kc284/disk
CA-289948: allow VDI of a stopped VM to be moved on unlicensed pools
2018-10-16 13:27:36 +01:00
Darren Matthews
5645cb9596 L10N: resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-16 12:38:36 +01:00
Aaron Robson
d8a2c9b82e CP-29657: Create message for HOST_LOW_MEMORY in XenCenter. (#2263)
* CP-29657: Create message for HOST_LOW_MEMORY in XenCenter.
Includes an update to the latest XenModel API.

* CP-29657: Included rebuilt FriendlyErrorNames designer.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-15 09:51:58 +01:00
Konstantina Chremmou
2b9bc8e3b6 Renamed resource to fix Visual Studio warning. Stop copying stray images into
the build output folder and removed one of them as it's now unused. Included
some left out images into the project. Updated README.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-15 09:44:06 +01:00
Konstantina Chremmou
41e6c6b3ca Reworked commit c0af621167 as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-12 16:20:17 +01:00
Konstantina Chremmou
c0af621167 A couple of random corrrections on error handling (#2265)
* Correct out of range percentage and throw an assertion instead of silently
logging it so we can fix the causes of it. Compacted method logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Exception handling: prevent InvalidOperationException if the health check service
is not found on the computer (installation is optional).
Do not throw exception and handle if the task handle is invalid, but rather
throw it only for other cases of task.status being failure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-12 13:36:44 +01:00
Darren Matthews
877f656d15 L10N: Translations updates (#2258)
* L10N: Translations updates
* L10N : Updated Ja homepage link

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-11 10:41:58 +01:00
=
e62096da26 CP-29106: XenCenter should disable the automatic check of VDIs
integrity and scare the user if it is turned on.

Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@citrix.com>
2018-10-11 08:13:56 +01:00
Darren Matthews
a8e03537a5 L10N : Translation updates and ReSync resx files
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-09 12:26:51 +01:00
Mihaela Stoica
4a9f2c1c11 Update credits
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-09 12:19:54 +01:00
Aaron Robson
6517403aa2 [aaf84eec] CA-298693: Using enum for memorymode to replace magic numbers.
Refactoring the memory spinner visibility logic for clarity in the New VM wizard.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Aaron Robson
3bd0a489f2 CA-298693: Going back to the Template tab of the NewVM wizard should not cause a different template to be selected, even if the template was selected outside of the form it should only initially set it.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Aaron Robson
edbf616ef8 CA-298693: Making the Static Maximum visible explicitly (with memory mode of 3) in the New VM wizard.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Michael Z
865bfc1b33 CA-298954: Match server branding and version.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-10-09 10:41:03 +01:00
Darren Matthews
5fd030d873 L10N: Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-08 13:08:41 +01:00
Konstantina Chremmou
f2a45442f8 CA-208682: Some layout corrections to make localisation for the CertificateChangedDialog
easier. Also, launch dialogs within a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 13:06:40 +01:00
Konstantina Chremmou
ca0f4ce1d4 CA-238884: Some layout corrections to ease localisation for the PvsPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 13:06:40 +01:00
Aaron Robson
c1c368070a CA-299063: Prevent the Network Interfaces from disappearing when the VM is Locked due to a Storage Deveice being deleted.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-08 12:59:55 +01:00
Konstantina Chremmou
9bd27f8915 Minor layout corrections and button reordering on the storage tab for VMs,
Hosts, and SRs, so that all three tab pages look the same.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:05 +01:00
Konstantina Chremmou
988db0cbba Separated the MoveVirtualDiskDialog from the MigrateVirtualDiskDialog so it
is easier to understand which one is called from which command.
Removed superfluous TableLayoutPanel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Konstantina Chremmou
b6420b6c12 CA-289948: If migration of individual VDIs is not allowed due to licensing restrictions,
do not show the upsell dialog; the user should be able to move the VDIs without
having to detach them first.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Konstantina Chremmou
3f2c1ea204 If a disk image import failed, XenCenter did not release its handle on the directory containing the image.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Ji Jiang
6a421173cc CP-29276: Implement update/supp pack application in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 12:32:01 +01:00
Ji Jiang
539d1850d0 CA-298913 + CA-297215: Fix KeyNotFoundException
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 11:12:50 +01:00
Konstantina Chremmou
2c328c086d Homogenised error handling in Invoke functions.
Renamed method IsExiting to IsInvokable to better describe its contents.
Added null check in it (previously only one of the four Invoke methods was
checking for null).
Added null check when we set the TestExceptionString in automated test mode.
Added logging to exception handling.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
e2d828a33b Removed some redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
9236bbc0e3 CA-298592: Check the licenseStatus is not null when accessing its properties.
There can be cases when we have logged in a session, events are fired
causing the tab pages to be refreshed, however we may abort the connection,
for example, due to brand mismatch. In this case the licenseStatus has not
been initialized, however the refreshing general tab tries to access its
properties resulting to a crash.
Also some method tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
365889a018 Compacted overload of method EndConnect.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
c3fcffa236 When we end the connection call OnConnectionClosed instead of OnConnectionStateChanged.
This avoids firing the ConnectionClosed event explicitly after EndConnect;
it also avoids refreshing explicitly the tree as the main Window handles the
ConnectionClosed event which requests a refresh.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
be0176afe0 When the connection is refused, create the failed action before showing the
pop-up, otherwise the UX is slightly strange if the failure appears on the
status bar only after the user has closed the pop-up.
Also, improved failure message shown on the History page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
7e6f0bb10c Removed explicit call of UpdateToolbars immediately after the first RequestRefreshTreeView.
Due to the delay interval between refreshes, this UpdateTolbars was called
before any root nodes were added to the tree, hence the only new tab to
add was Search, which got selected  (previously this did not happen,
because it was taken for granted that the root node was added by the constructor).
Immediately afterwards the treeview was refreshed, the root node was selected and the
home page was added, but the selected Search tab was erroneously preserved.
Also removed extra RequestRefreshTreeView because the tree will be refreshed,
if required, by the handlers of the connection events.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00