1
0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-12-25 03:39:52 +01:00
Commit Graph

35 Commits

Author SHA1 Message Date
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Gabor Apati-Nagy
a1a411b9df CA-214628: .NET Image limit causes exception
Further changes

* implemented similar logic for the Commands too as those are keep on getting updates so affected
* moved these static fields to a class (at Images)
* used the same casing as in Resources once they have been moved

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-11 13:56:45 +00:00
Gabor Apati-Nagy
5a117334af CA-214628: .NET Image limit causes exception
Changed code at a a few places where it made sense to limit how many times XenCenter asks the Resource Manager for a new instance(*1) of the same(*2) image.
*1: RM returns a new object each time
*2: they are the same as we don't change the locale of a thread and also we don't localise these images - by design

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 13:57:50 +00:00
Konstantina Chremmou
2e6b2d8995 CA-145890: added new Page to the options dialog where the user can configure how
confirmations are displayed. Added checkboxes to the dialogs requesting confirmation
of dismissal of notifications so the user can opt to skip this step.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-17 13:35:31 +00:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
598356fe86 CA-147164: Filter by status doesn't notice changes of status
Fixed the bug by subscribing to events of all actions and not only to the
ones that are displayed in the grid.
Besides this, the visibility of the row is being used instead of removing and
re-adding rows on status changes.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-05-19 15:36:56 +01:00
Mihaela Stoica
a4fe507adf CA-147941: Fixed the RPU wizard hang in "Reconnecting Storage" and connecting action stuck in progress state
In some cases calling Control.Invoke() from a background thread causes that thread to go in a "sleep, wait, or join" mode, while waiting for Invoke to happen, although the UI thread is running normally.
If the Control is the MainWindow, it works as expected, but we've seen it happening while connecting or disconnecting from a large pool, on calling Invoke on controls like NavigationView, AlertSummaryPage, HistoryPage, etc.
To fix this, we call the Invoke on the MainWindow in all the places where we've seen the issue.

With this changes, the previous fix for CA-148245 (call RequestRefreshTreeView on CacheClearing event) is not needed anymore, so I removed that call.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-10-10 13:16:50 +01:00
Gabor Apati-Nagy
7ea996f9bd CA-148374: Progress action disappears in Events on Dismiss all
-Also fixed the Dismiss Selected button

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-10-10 11:35:21 +01:00
Gabor Apati-Nagy
bc3c2fae15 CA-148374: Progress action disappears in Events on Dismiss all
-Added a where clause to filter out non-completed actions in this case

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-10-09 19:24:16 +01:00
Mihaela Stoica
8faf672959 CA-141101: XenCenter filters not changeable after dismiss all - FIXED
- In the Events view, offer a choice only to dismiss the visible ones instead of all
- Keep the filter buttons always enabled. This applies to all Notification views (Alerts, Updates & Events)
- Also refined the confirmation messages displayed when dismissing events

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-31 09:39:16 +01:00
Konstantina Chremmou
8d5bc0920a CA-123737: Do not rebuild the alerts/updates/events pages unless they are visible.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-04-28 15:04:23 +01:00
Konstantina Chremmou
04bfd89a9d [CA-115418], [CA-123574]: Fixed issue where the Dismiss item on each alert row
was available for non-dismissible alerts. Fixed wrong enabled state of the top
ToolStripSplitbutton Dismiss on the alerts and the events page. Refactored code
calculating dismissability of alerts and dismissing them. Events list should be
multi-selectable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-09 13:57:41 +00:00
Konstantina Chremmou
bae0d9ab8f Added Copy item to the actions drop down on the Events page. Aesthetic: made the
actions split button look more like a button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-10 11:29:31 +00:00
Konstantina Chremmou
1669c4250d CP-6093: Further corrections to the enabled state of the top ToolStripButtons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-05 10:56:11 +00:00
Konstantina Chremmou
58d0599bdc CP-6093: Filter by Location ToolStripDropDownButton: only add ShowAll item if there
are actually items to show. Button enablement on Events page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-25 08:42:17 +00:00
Konstantina Chremmou
ad3cfc7f98 CP-6093: Disable filter buttons on the Alert and Events pages when the lsit is empty.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 08:25:02 +00:00
Konstantina Chremmou
9917801cc3 CP-6093: Implemented "GoTo..." and "Dismiss Selected" actions on the Events page.
Preserve last selected node when switching between views. Added labelling to the
unit tests run post-build. Minor tidy.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-18 14:31:00 +00:00
Konstantina Chremmou
94aa7ac531 CP-6093: Set a lcoation for the connection events. Fixed refresh problem on the
Events page location filter. Added help ids for the Notification views.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-05 14:40:16 +00:00
Konstantina Chremmou
fb74297cbb CP-6093: Updated test to reflect changes in the View menu. Ignore temporarily flaky
test. Fixed broken action cancellability.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-10-09 13:33:06 +01:00
Konstantina Chremmou
620e268a6b CP-5750: Avoid creating new ToolstripMenuItems every time an action is updated,
but choose instead which ones to display.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-19 13:17:33 +01:00
Konstantina Chremmou
b2ddebef49 CP-5750: Updated existing LogTab tests to reflect gui changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-16 12:57:39 +01:00
Konstantina Chremmou
f9a9fb122c CP-5750: Separated Cancelled from Failed actions. Fixed control invoke issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 17:08:04 +01:00
Konstantina Chremmou
2a1d8893ab CP-5750: Added label to indicate when filters are on/off. Changed the order of
the items on the actions split button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 11:04:08 +01:00
Konstantina Chremmou
67d15dcca5 CP-5750: Moved capping of event numbers to a more relevant place and corrected logic
to remove the oldest items first and fire an event when doing so.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 10:52:15 +01:00
Konstantina Chremmou
86c6950aeb CP-5750: Implemented event filtering by status, location and date.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 10:15:52 +01:00
Konstantina Chremmou
427ecd49ac CP-5750: Implemented ability to sort events. Set vertical scrollbars for the gridview.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-12 14:00:29 +01:00
Konstantina Chremmou
c2333b03b1 CP-5750: Initial implementation of the new Events DataGridView.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-10 12:29:36 +01:00
Konstantina Chremmou
23d10bd513 CP-5750: Do not filter the Log tab entries according to the selection on the treeview.
For the time being show all entries. New filtering according to the entry location
will be implemented in a future commit.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:41 +01:00
Konstantina Chremmou
16ba4699db CP-5750: Removed Clear button. Initial implementation of top ToolStrip and
DismissAll/DismissSelected split button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:39 +01:00
Konstantina Chremmou
62586ef89c CP-5750: Removed ActionType; the actions should be categorised by status (in progress,
succeeded, failed; cancelled at the moment counts as failed, we may need to distinguish
in future). As a consequence the filter checkboxes from the top of the Log tab
were removed and some temporary changes were made to the drawing of action rows
(the controls will change completely in a subsequent commit).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:38 +01:00
Konstantina Chremmou
38ab6b8ffa CP-5750: When a License warning is generated, create an alert rather than an Action.
Removed ActionType.Alert. Removed Alerts checkbox from the Log tab.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:36 +01:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00