Commit Graph

5612 Commits

Author SHA1 Message Date
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
6f0a9cae6a CA-293784: updated plugins to use the XenServerPSModule as the snap-in has been retired.
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
6bae7380a2 Property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
e9d2da082d Prevent XenCenter from crashing if starting it by double-clicking a license file.
Also, fixed hotkeys and info message on the PasswordRequest dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Konstantina Chremmou
73d457ec16 CA-328086: Prevent XenCenter from crashing when started from the cli without enough parameters for connecting to a server.
Also, compacted the code parsing command line parameters; removed class
and cli option MessageBoxTest as it adds to code complexity, plus that
the application is not meant to be used as testing infrastructure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
91e2ec3bbe CP-32101: Allow the application to seek help relevant to its release instead of always pointing to help for the latest CR.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
eed06a6b4a Fixed unlocalised message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
b46d9fda92 Throw specific NotImplementedException instead of generic exception. Some property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
441734be82 CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool.
Also, corrected the RBAC permission check after stopping using the conversion plugin.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 13:25:26 +01:00
Konstantina Chremmou
3d92246607 The GpuConfiguration list should not be editable. Resize GpuShinyBar Edit button when the text changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-23 13:39:54 +01:00
Konstantina Chremmou
ceccfcbe79 CA-325439: Pre-populate download locations. Validation corrections on the server status report wizard.
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-19 14:06:28 +01:00
Mihaela Stoica
0e47725ceb CP-32137: Updated alert message + sorted Messages.resx
Also rewrote the IsAlertNeeded() function, for better readability

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
43dd9d4b4d CP-32137: Add alert for versions approaching EOL
The Approaching EOL alert will be shown when the EOL date is known, but the hotfix-eligibility flag is not yet set to "none".

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
4832c7f5e6 CP-32139: Add text regarding the supportability for versions that have reached EOL
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
b7738d1d81
Merge pull request #2511 from kc284/CA-272770
CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
2019-09-13 13:50:08 +01:00
Mihaela Stoica
3ea93a9bd4
Merge pull request #2517 from kc284/feature/REQ-756
Merge master into feature/REQ-756
2019-09-13 13:46:53 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
a3a7b93b8d CP-32097: Added help ids for the conversion dialog and wizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:48:48 +01:00
Konstantina Chremmou
bf1cdb67ec Change case to match the help files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:48:48 +01:00
Konstantina Chremmou
2c59ca255e CP-30364: Facilitate overriding the help files location for testing purposes
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:00:56 +01:00
Konstantina Chremmou
d52008aaf9 CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
Also, minor layout correction, and usability enhancement: do not disable
the controls under the radio button when the latter is deselected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-12 23:05:15 +01:00
Konstantina Chremmou
d2db181872 CA-314721: Fixed parsing of nvidia gpu metrics names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 14:23:48 +01:00
Konstantina Chremmou
d5d32baa88 CA-326611: Improved connecting to the conversion VM.
- Poll for the appliance version because the service may take a while to
  start after an IP address is obtained.
- More flexible IP address look up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Konstantina Chremmou
8701641e47 CA-326609: Ensure the conversion wizard offers only SRs that can be seen from all hosts in the pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Mihaela Stoica
57741506b4 CP-32070: Fix icon visibility + some improvements
- make the info messages icon+text instead of clickable icons. Some rearrangements of the controls on the dialog to accommodate them.
- in the "Assign To Snapshot Schedule" dropdown item, do not add a separator if there are no suitable policies listed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-07 01:35:46 +01:00
Konstantina Chremmou
61f6f89c25
Merge pull request #2510 from xenserver/feature/REQ-775
Merge REQ-775 into master
2019-09-06 12:08:23 +01:00
Ji Jiang
2565b09e80 CP-32135: Add hfx eligibility notif tests to CFUValidator
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2019-09-06 10:02:27 +01:00
Mihaela Stoica
b7c64bddb2 CA-326341: Refresh the hotfix eligibility alerts after a check for updates is completed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-04 14:40:03 +01:00
Konstantina Chremmou
6cd1ef1c52 Stop generating installer tars. Removed ISO files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-04 13:37:33 +01:00
Konstantina Chremmou
57689f7498 Some spelling corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-04 13:37:33 +01:00
Konstantina Chremmou
830b979813 Obsolete class (possible CP-4813 leftover).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-04 13:37:33 +01:00
Mihaela Stoica
fca17a7ef5 Fix menu and dialog title inconsistencies for Snapshot schedules.
Also, use an info (instead of warning) icon on the message for Disk and memory snapshot

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 09:44:59 +01:00
Mihaela Stoica
3f5125b293 CA-325846: Do not display invalid data in the hotfix eligibility warnings and alerts
- if a hotfix eligibility date field is invalid, then the hotfix eligibility warning does not include any reference to this date.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Mihaela Stoica
e4305ecb15 CA-325822: Refresh existing hotfix eligibility alerts when the license status changes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Mihaela Stoica
661eee069c CP-32070: Add a warning on the Scheduled snapshots properties page
The warning is visible for vss scheduled snapshots on Quebec or newer hosts (these would be snapshots created before the host has been upgraded).
Also corrected a typo in a function name.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:18:19 +01:00
Mihaela Stoica
224f398307 CP-32070: Hide the quiesce checkbox based on the version of the server
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:18:19 +01:00
Mihaela Stoica
2a15b62f86 CA-322529: Do not add nulls to the sub-actions list for a multiple action
- This fixes the issue where we create a multiple action to delete the update installation files, but the sub-actions list contains null values because the connection to the host has been lost

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-02 11:21:23 +01:00
Konstantina Chremmou
1a88c3713d Activate the conversion VPX and get the service IP address without employing the conversion plug-in.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-02 10:34:58 +01:00
Konstantina Chremmou
629e2f641a CA-326161: Check for null before accessing the ManualTextInstructions
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-02 08:05:48 +01:00
Konstantina Chremmou
f46c9ea8d6 CP-30890/XSI-284: Support import of gzipped XVAs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 15:30:01 +01:00
Konstantina Chremmou
6066de3ae2 Corrections and enhancements. (#2496)
* Corrections and enhancements.

Fixed version compatibility check. Added context menu to the conversion list.

* Exclude templates and snapshots when looking for the conversion VM.

* Further corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 14:57:36 +01:00
Mihaela Stoica
f00ff744ba CP-31527: Correction to the date displayed in the alert message
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-08-27 08:58:46 +01:00
Konstantina Chremmou
aab9df208a Further improvements.
- Added textual description of the conversion status in the Details panel.
- Merged status detail and error message.
- Added initial sort order.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-27 07:52:38 +01:00
Konstantina Chremmou
d22b212afa Renamed property as there are clashes with a child class (will have to be refactored in future). Treat warnings as errors in all projects.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 14:03:30 +01:00