Commit Graph

2333 Commits

Author SHA1 Message Date
Danilo Del Busso
d41cd94baf CA-339273: Mention source Host/Pool in VM clone action
Also removed useless `this` calls and tidied code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-10 15:21:04 +01:00
Danilo Del Busso
72a9979506 CA-339273: Mention source and destination Hosts in VM move action
Also removed unused `this` calls, and updated one constructor override.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-10 15:21:04 +01:00
Danilo Del Busso
a78b1541e7 CA-339273: Mention source SR in VDI actions Description
Also changed description to reflect the status of the action

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-10 15:21:04 +01:00
Konstantina Chremmou
e368d74330 DelegatedAsyncAction should only be used for simple API calls, hence created new class for retrieving WLB host evacuation recommendations.
This allows removal of DelegatedAsyncAction.ResultObject, which might lead to complicated implementations.
Also: some refactoring of the other WLB retrieve recommendations actions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-07-23 09:40:12 +01:00
Konstantina Chremmou
92cf9572bc CA-355655: Throttle the number of parallel downloads of server status report data in a pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:25:24 +01:00
Konstantina Chremmou
f63003fb27 CA-353748 second issue: At the end of polling, the RelatedTask is destroyed; make a note of it for later use
Also: make a get_record where more than one object fields need to be queried.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-17 09:11:39 +01:00
Konstantina Chremmou
858ab54950 CA-353748: VM imported as an XVA won't start automatically.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-17 14:46:57 +01:00
Konstantina Chremmou
e3e73c8a0a
Merge pull request #2807 from xenserver/feature/legacy-partition
Merge feature/legacy-partition to master
2021-05-04 13:06:16 +01:00
Konstantina Chremmou
b116c4713d CA-353524: Full copy of VM on the same SR is allowed.
Moving and copying a VM should be treated differently, hence we need a different
SrPickerItem subclass for each operation. Minor logic simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:27 +01:00
Konstantina Chremmou
ca8e53e0ba CA-294901: Improved message on the CrossPoolMigrateWizard.
Also, NoTargetServerPoolItem class should be private to the SelectMultipleVMDestinationPage
because it is not used anywhere else.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-28 11:28:28 +01:00
Konstantina Chremmou
735896fdca CA-340976: Corrected disabled reason for IP address configuration button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-27 00:18:47 +01:00
Mihaela Stoica
a75e8fca4f
Merge branch 'master' into feature/legacy-partition 2021-04-23 14:37:05 +01:00
Darren Matthews
7e39749091 L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2021-04-20 12:34:17 +01:00
Konstantina Chremmou
3f4737c57a Upgraded log4net to 2.0.12.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-09 09:16:01 +01:00
Konstantina Chremmou
6d8ad062f8 CA-353070: Corrected wizard title. Fixed navigation with the Tab key.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-08 17:28:48 +01:00
Konstantina Chremmou
5a91f615b2 Added null checks where missing and reduced use of try-catch blocks in favour of TryParse() methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
e5bee7be6a Added Events in progress to the outlook-style status labels of the main window.
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:30 +01:00
Konstantina Chremmou
7985befde6 CA-352946: Account for the cases when the task result is not xml.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-01 11:30:54 +01:00
Konstantina Chremmou
35e1d68afa CA-352901: Fixed window title and translations for window title and menu item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-01 11:30:54 +01:00
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-17 15:30:59 +00:00
Konstantina Chremmou
f05b16eff7 Do not use the task description as the AsyncAction description because in most cases it is not localised.
Also, do not poll if the RelatedTask is null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-16 10:27:55 +00:00
Konstantina Chremmou
47d9146ce3 CA-352455: Parse the task result as xml document instead of using a regex.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-16 10:27:55 +00:00
Edwin Török
eaf6bb7507 Update DEFAULT_NUM_VBDS_ALLOWED to 255
All currently supported versions of the product support 255 VBDs,
see https://docs.citrix.com/en-us/xenserver/7-0/downloads/config-limits.pdf

When a VM is imported through XCM it may not have recommendations,
and XenCenter falls back to the default, which is 16.
Then adding another disk shows an error that the maximum number of disks was reached,
which contradicts our support statement of 255 disks.

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
2021-03-16 00:12:50 +00:00
Mihaela Stoica
c6710b7ffd CP-35471: Refactor HostNotSafeToUpgrade classes to avoid code repetition.
Also:
- added count check when generating the prechecks
- message correction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-11 09:30:52 +00:00
Mihaela Stoica
9f6ce35a04 CP-35471: Change the SafeToUpgrade check to show a problem when upgrading to the next version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-11 09:30:52 +00:00
Mihaela Stoica
b0dd36d1b3 Add branding and helper function for the next version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-11 09:30:52 +00:00
Konstantina Chremmou
6e5cb325f3 CP-35899, CP-36202: Show the driver domain console tab on the corresponding SR.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Konstantina Chremmou
29f3f9cd33 CP-35898: Do not show SMAPIv3 SRs as of unknown type if the type can be inferred from the SM plugin.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Konstantina Chremmou
a109f5f22d Pascal-cased method name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Darren Matthews
a8988276be L10n : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2021-03-02 09:44:29 +00:00
Konstantina Chremmou
5e76a3cae8 CA-352022: Fixed broken retrieval of polling result.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-18 10:33:18 +00:00
Konstantina Chremmou
eb3662aa88 CA-345342: Cope with optional parameters in the HTTP_actions.
- Removed wrapper delegates; call the http_actions directly.
- In case of failure or cancellation of the http_action, poll the related task
  ignoring any exceptions thrown, so that any clean up code within the http_action's exception handling can run.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
bc92cf793d Removed class TaskPoller and moved its code to AsyncAction.
This simplifies the code since the TaskPoller cannot be perceived without an AsyncAction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
145483b193 Minor corrections on Task extensions:
- Stop rethrowing exceptions.
- Added some checks.
- Renamed method XenCenterUUID to GetXenCenterUUID to match the methods
  SetXenCenterUUID and RemoveXenCenterUUID.
- Replaced check via static string list with a string switch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
b0eafcf1d1 Code design issue: do not override DestroyTask. Minor refactoring in VMSnapshotCreateAction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:45:23 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed.
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Konstantina Chremmou
75f9127e27 Move files to a better location.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-19 10:37:35 +00:00
Konstantina Chremmou
be010e1c39 CA-350406: Exclude the Tools SR when plugging PBDs after a host reboot during an update process.
Also, try plugging PBDs only for the host in question (other hosts are not necessary,
as the PBDs are re-checked for any previously evacuated VMs before repatriation).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-12 12:15:12 +00:00
Konstantina Chremmou
9a5c664eb0 CA-350574: Corrections to signing an appliance.
Also, removed listing of CryptoServiceProviders from the settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-12 12:14:31 +00:00
Konstantina Chremmou
501cca2ffb CA-350410: Ensure we set the certificate before checking it's null.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-04 16:23:11 +00:00
Konstantina Chremmou
542a329a27 Fixed failure to start a VM after it was imported as an XVA package.
Regression introduced by the changes for CA-64500. Since we initiate a VMStartAction
we need to ensure that the VM object passed to the action has a non-null Connection.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file.
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
e325548a75 CA-349836: Reworked handling of manifest and signature for appliance import/export.
- Moved the code to the ExportApplianceAction so it's easier to modify the
  action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
  OVF package was ignored.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
8d004401fb CA-343280: Removed metadata entry.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
6286f96cb1 CA-343280: Extended proxy authentication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
3e0d982631 CA-347849: No need to keep track of the VIF.device numbers across all VMs of the imported appliance.
Reset to 0 for each VM.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:00 +00:00
Konstantina Chremmou
84d0a2b8ae Bad application of the code reusability principle in VMDestroyAction.
Destroying a VM does not disrupt the connection, hence the use of the BestEffort
method is not warranted. After this correction, BestEffort is only used in the
DestroyedBondAction, hence I removed it completely and replaced it with simpler
exception handling in the latter class's Run method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-03 14:56:11 +00:00
Konstantina Chremmou
94024f99a9 CA-347481: Clean up the disks of the destroyed VM if import is interrupted due to cancellation or failure.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-03 14:55:38 +00:00