Commit Graph

2554 Commits

Author SHA1 Message Date
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports.
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-14 16:00:58 +01:00
Konstantina Chremmou
46cd8308be CP-38582: Corrected version check - last_software_update was added in xapi 22.20.0
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 13:08:59 +01:00
Konstantina Chremmou
3d313f2d31 Updated C# SDK (xapi 22.20.0-1.xs8).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 10:49:06 +01:00
Konstantina Chremmou
6898148466
Merge pull request #3021 from kc284/remove-updates-tab
CP-39817: Removed updates tab page.
2022-06-21 10:48:46 +01:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:47:54 +01:00
Konstantina Chremmou
b79eda2d4b Removed unused code around restoring dismissed updates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:43 +01:00
Konstantina Chremmou
fc925ba047 Removed unused CfuAvailabilityCheck class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:43 +01:00
Konstantina Chremmou
414eff9c2f CP-39817: Removed the option to check for server new versions since it is not relevant any longer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:42 +01:00
Konstantina Chremmou
e5d090d614 CP-39817: Removed the updates tab page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:42 +01:00
Danilo Del Busso
2798315b46
Merge pull request #3017 from danilo-delbusso/task/last-updated_CP-38583
CP-38582: Show `Last updated` field in General `TabPage`
2022-06-15 13:32:36 +01:00
Konstantina Chremmou
8beae03d35 CP-38583: suggested modifications. (And a couple of code smells).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-15 13:05:11 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622
REQ-622: Citrix Hypervisor Center quick-update mechanism
2022-06-13 14:57:15 +01:00
Konstantina Chremmou
c66a23f314 CP-39952: Do not ask the user to uninstall the container management supp-pack.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-08 14:01:04 +01:00
Konstantina Chremmou
fd627e687f CP-39933: Show the names of the PV guests preventing upgrade if any are detected.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-08 14:01:04 +01:00
Danilo Del Busso
6d6b0ce5fc
CP-38582: Show Last updated field in General TabPage
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-30 09:36:39 +01:00
Konstantina Chremmou
2889b1678d Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:36:08 +01:00
Konstantina Chremmou
cc4d3d9ee7 Extended product version checker to cope with RPM versions. Use xapi_build instead of xapi for version comparisons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:36:02 +01:00
Konstantina Chremmou
df35684586 Moved version checking methods to a separate file. Use C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DragDropCrossPoolMoveHaltedVMCommand.cs
#	XenAdmin/Commands/DragDropMigrateVMCommand.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/Filters/CrossPoolMigrateCanMigrateFilter.cs
2022-05-25 11:35:47 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:29:25 +01:00
Konstantina Chremmou
afa21f16a9
Merge pull request #3011 from kc284/CA-366140
CA-366140: Reverted original solution. Handled error thrown when retrieving datasources.
2022-05-25 11:04:51 +01:00
Konstantina Chremmou
76738ad91f
Merge pull request #3003 from kc284/drag-drop-3
CA-294370: Rewrote logic calculating if migration is allowed + some other fixes.
2022-05-25 11:04:26 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed."
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
2022-05-19 11:18:52 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
2022-05-17 10:51:10 +01:00
Konstantina Chremmou
8af0184030 Replaced dismiss button with release notes button. Show the application name in the update button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-16 14:08:02 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002)
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-05-10 12:22:28 +01:00
Konstantina Chremmou
eca6f1d2a4 CA-294370: Rewrote logic calculating if migration is allowed:
Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:37 +01:00
Konstantina Chremmou
d0fdc5360b
Merge pull request #2980 from danilo-delbusso/bug/rdp-gray_CA-322672
CA-322672: Do not stop polling for RDP capabilities on VMs
2022-05-09 15:15:39 +01:00
Konstantina Chremmou
ae7df535c2 Some layout and logic changes so the page looks and behaves more like the other wizard pages with progress bars.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:37:54 +01:00
Konstantina Chremmou
9b7d502e74 CA-329538: Tell the user to ensure tools are installed if a VM cannot be migrated via drag-and-drop.
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:37:16 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:36:49 +01:00
Konstantina Chremmou
4496d4571d CA-365905 (XSI-1215): Create a temporary file in the target download folder if the latter is in a different drive from the default temporary folder.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-25 17:06:17 +01:00
Konstantina Chremmou
1928cf3db7 CA-366139: Specify which VM lacking the feature could not be migrated during RPU.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-25 17:06:01 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-22 14:32:14 +01:00
Danilo Del Busso
d17b99e6b0
CA-322672: Improve comments around RDP status checks
`data/ts` indicates the VM has RDP enabled

`feature-ts2` is the feature flag indicating that `data/ts` is valid.

`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)

the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-20 12:39:47 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube
CP-36392: Improvement of sonarqube score
2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-14 11:45:21 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986)
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988)
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-12 12:09:44 +01:00
Konstantina Chremmou
558897740d Reworked instantiation of dummy actions that complete immediately.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 19:43:09 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973)
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 10:11:33 +01:00
Konstantina Chremmou
04ac8249a6 CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:35 +01:00
Konstantina Chremmou
d2548ae4c0 CP-36392: Do not create an action for changing the master password.
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
84ad7054ea Compacted the ActionBase constructors and renamed file to match the class name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method.
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
492cd4dc88 CP-36392: Do not use a loop for only one iteration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-04 21:07:09 +01:00
Konstantina Chremmou
acc5ed0210 CP-38542: Remove option to disable live patching.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:17:22 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page:
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:07:43 +01:00