Commit Graph

3152 Commits

Author SHA1 Message Date
Callum McIntyre
d83a9cefb5 CP-18417 review changes: Improved PatchRequiresReboot logic. Introduced a new bool someHostMayRequireRestart, passed as an out parameter into both the guidance string builder methods, and the Build method they both use. In that Build method the parameter is set to true if any restartHost guidance is seen - this check is done before live checks exit for consistency.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 17:19:47 +01:00
Callum McIntyre
5d53ab3db3 CP-18417 review changes: Simpler other_config key, added a pool extension method to check for it, moved the check on the Select Servers page to be the first check, simpler logic toggling the automatic/manual buttons. Still need to rework the PatchRequiresReboot part
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 16:37:37 +01:00
Callum McIntyre
31941eb71e Remove unwanted files from first commit
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-14 10:41:57 +01:00
Callum McIntyre
b22618ef5c Merge remote-tracking branch 'upstream/master' into CP-18417 2016-09-14 10:30:52 +01:00
Mihaela Stoica
91ef745b9c Merge pull request #1162 from stephen-turner/one-comment-v2
Comment on the VM.IsWindows method
2016-09-13 16:23:29 +01:00
Stephen Turner
a8c6e81ceb Comment on the VM.IsWindows method 2016-09-13 12:16:55 +01:00
Mihaela Stoica
4f46345b96 Merge pull request #1160 from GaborApatiNagy/master_CA-220599
CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
2016-09-13 10:11:47 +01:00
Gabor Apati-Nagy
fdb32cf579 CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
Fixed regression caused by 5555709337.
Supplemental packs can now be installed again in automatic mode.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-12 17:07:59 +01:00
Konstantina Chremmou
f4dfbe83b4 Merge pull request #1155 from MihaelaStoica/CA-220613
CA-220613: Truncation on the Migration Network page of the Cross Pool…
2016-09-12 09:02:28 +01:00
Callum McIntyre
129330c326 CP-18417: Modify the hotfix wizard to make it work for hosts that can't auto-update/restart from XC
Adjusted messages, and added a tooltip to the Automatic restart radio when it's disabled. Also now support standalone hosts in addition to pooled.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-09 15:45:38 +01:00
Callum McIntyre
9a8cb87e29 Pull down + merge master (which has changes to update wizard in live patching etc). Automerged. 2016-09-09 12:40:07 +01:00
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
Mihaela Stoica
8bf507e634 CA-220613: Truncation on the Migration Network page of the Cross Pool Migration wizard
Fixing regression introduced in commit 3a5444ceb2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-08 12:01:56 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Mihaela Stoica
4623d65a4d Merge pull request #1138 from kc284/master
CA-215575: Top connection bar on full screen console was not listening to server events
2016-09-06 10:53:35 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Mihaela Stoica
a8b907716d Merge pull request #1152 from GaborApatiNagy/master
CA-220040: Fix for unit tests
2016-09-05 13:42:22 +01:00
Gabor Apati-Nagy
7d4524196b CA-220040: Fix for unit tests
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-05 13:32:33 +01:00
Gabor Apati-Nagy
b12f488ffd Merge pull request #1147 from MihaelaStoica/CA-220040
CA-220040: Patching wizard shows reboot required where it is not expected
2016-09-05 12:05:12 +01:00
Gabor Apati-Nagy
6065465a52 Merge pull request #1148 from MihaelaStoica/CA-220049
CA-220049: Non-livepatch hotfix installation is failing
2016-09-05 12:05:06 +01:00
Gabor Apati-Nagy
531613b037 Merge pull request #1149 from MihaelaStoica/CA-220171
CA-220171: Configure HA dialog incorrectly states failover tolerance …
2016-09-05 12:02:06 +01:00
Mihaela Stoica
7764a6bf9f Merge pull request #1145 from mcintyre94/CA-140338
CA-140338: Truncation on New Search Page with long Custom Field Filters name
2016-09-02 11:25:59 +01:00
Mihaela Stoica
8755126e8d Merge pull request #1144 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-09-02 11:17:55 +01:00
Mihaela Stoica
8e077e1e78 CA-220171: Configure HA dialog incorrectly states failover tolerance would be 0
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-02 10:46:33 +01:00
Mihaela Stoica
24d67cca10 Fix an error in ParallelAction with no subactions
- Immediately complete the ParallelAction when there are no subactions to be executed, to avoid on infinite lock while waiting for the actions to be completed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:42:07 +01:00
Mihaela Stoica
12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00
Mihaela Stoica
b1728ee125 CA-220049: Non-livepatch hotfix installation is failing
This fixes the NullReferenceException that occurs when trying to evacuate a host after a non-livepatch update (that requires reboot) has been installed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:14:21 +01:00
mcintyre94
8ba08bc899 Merge pull request #1146 from MihaelaStoica/resurrect-CP-18011
Resurrect CP-18011: [XenCenter] Add live patching checkbox
2016-09-01 15:14:13 +01:00
Callum McIntyre
c36f160327 CA-140338: Truncation on New Search Page with long Custom Field Filters name
Accidentally left an extra piece of ellpising in the wrong place, now removed.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-01 15:03:43 +01:00
Callum McIntyre
3295dc845d CA-140338: Truncation on New Search Page with long Custom Field Filters name.
The truncating of the custom field name by space (instead of ellipsising) seems to be a Windows default, but it's not ideal. This change edits the text displayed in the dropdown when an item is selected so that if a custom field is selected it is ellipsised to an appropriate length. It doesn't affect the dropdown itself, which continues to display the full custom field name.
2016-09-01 15:00:06 +01:00
Mihaela Stoica
b758e0660a Resurrect CP-18011: [XenCenter] Add live patching checkbox
(reverting  8a10351c5d: Revert "Cp 18011: [XenCenter] Add live patching checkbox")

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 14:59:37 +01:00
Callum McIntyre
df9410ac6a CA-112317: Sorting on SR storage tab is incorrect
Making the requested changes: Name is now sorted by the generic CompareTo method (which uses name with opaque ref as tiebreaker), and Description also uses opaque ref as tiebreaker for consistency.
2016-08-31 16:42:01 +01:00
Gabor Apati-Nagy
d5bb5d96bc Merge pull request #1139 from mcintyre94/CA-107341
CA-107341:  Truncation issue occurred on rolling pool upgrade window.
2016-08-30 16:01:01 +01:00
Gabor Apati-Nagy
b510dbe8c7 Merge pull request #1140 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-08-30 15:57:47 +01:00
Gabor Apati-Nagy
e374ac2d12 Merge pull request #1143 from GaborApatiNagy/master
CP-18014: Fixed PatchingWizardModeGuidanceBuilderTests
2016-08-26 18:16:22 +01:00
Gabor Apati-Nagy
7680d3160f CP-18014: Fixed PatchingWizardModeGuidanceBuilderTests
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 18:15:14 +01:00
Gabor Apati-Nagy
d99cb8b06e Merge pull request #1142 from xenserver/CAR-2197
Merge CAR-2197 into Master
2016-08-26 16:50:47 +01:00
mcintyre94
9acf3950fd Merge pull request #1141 from GaborApatiNagy/CP-18014
CP-18014 + Merge master
2016-08-26 16:45:08 +01:00
Gabor Apati-Nagy
d7a94c1684 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Fixed flickering

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:41:12 +01:00
Gabor Apati-Nagy
15f69ef584 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Improving AvoidRestartHost usage/interface

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:04:28 +01:00
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
a548c21120 CP-18417: Simplifying the automatic enabled/disabled logic.
Automatic is disabled if any pool forbids auto restart (per Neptune), and reboot is required. It's also disabled if the update type isn't one of the three in the switch statement. If it's enabled it is checked by default.
2016-08-26 14:45:24 +01:00
Callum McIntyre
8639660562 Move the check to stop Neptune servers being selected into the IsInAutomaticMode checks 2016-08-26 14:24:24 +01:00
Callum McIntyre
1cc960860b CA-112317: Sorting on SR storage tab is incorrect
Change the sorting on the Name and Description columns to use StringUtility.NaturalCompare, which correctly sorts strings with numbers at the end (eg name, name0, name1, name2, name10 will now sort correctly while alphabetic sorting is incorrect). Also added a tie break on uuid to make sorting behave predictably with duplicates in these columns.
2016-08-26 10:06:30 +01:00
Callum McIntyre
c41602085d CA-107341: Truncation issue occurred on rolling pool upgrade window.
Truncated pool and host names on the Ready to Upgrade page to 64 characters, which resolves the layout problem from extremely long names.
2016-08-25 16:48:39 +01:00
Konstantina Chremmou
9b7f90ccb4 CA-215575 plus refactoring: The connection bar does not need to manipulate anything
other than strings. Moved settings of the FullScreenForm from the VNCTabView to
the former class. The FullScreenFormof the VNCTabView is only initialised as
FullSCreenFrom so no casts are necessary. The FullScreenForm is responsible for
updating the connection bar text with the value obtained from the vncScreen everytime
the name of the connection changes. Also reduced visibility of certain members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 13:51:50 +01:00
Gabor Apati-Nagy
6cf7865290 Merge pull request #1137 from mcintyre94/CAR-2197
CP-18618: If live patching fails, warn the user
2016-08-24 13:37:57 +01:00
Konstantina Chremmou
a9a1cd6b9c Tidied up: the vncScreen should notify the parent vncTab when the rdp warning needs
to be shown. It is complicated to have the one control call a method in the other
which checks the state on the first control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 11:48:42 +01:00