Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Because if these are protected by a master password, the application shows
all tabs it constructed with while the password dialog is open.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
It's not worth increasing the complexity of the already complex main form
in order to avoid repeating the setting's name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Do not dispose of the activeView when pausing the console (which happens
when we move away from the console tab.
- When setting a new source, remove and re-add the activeView only when
it has changed.
- Dispose an unneeded view immediately instead of starting a timer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
`data/ts` indicates the VM has RDP enabled
`feature-ts2` is the feature flag indicating that `data/ts` is valid.
`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)
the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove changes in string capitalisation
Move capitalisation invariance to checks only
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add remaining `ToLowerInvariant()` calls
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366115: Release the installer when cancelling the installation because of pending tasks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-366116: Use always the same filename for the temporary downloaded installer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Allow to cancel while retrying to download the installer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* Further modifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-39382 adds back in messages lost in merge conflict resolution
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The body of the setter never proceeds before the first line because value==_state
and the child's level has just been increased and is zero or greater.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
