Commit Graph

5403 Commits

Author SHA1 Message Date
Darren Matthews
e5e82b5496 L10N: Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-06 09:24:50 +00:00
Mihaela Stoica
39d95be2e0 CA-304476: We shouldn't log the duplicate session out, as the duplicate sessions are just separate streams, not separate logins
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-04 11:19:17 +00:00
Konstantina Chremmou
a3731ecef7 Removed empty resource files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:24:28 +00:00
Konstantina Chremmou
fc69887281 CA-168861: Corrected margins for labels and comboboxes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:24:28 +00:00
Konstantina Chremmou
7836717a56 CA-308212: The prepare_host_upgrade plugin should be called on each
of the hosts to be upgraded and not only on the first one in the list.
For this purpose, the test has been moved to the prechecks, and the
failures are now shown as a non-fixable problem.
Further, specification of the network location of the installer files
has moved closer to the upgrade mode selection.
Also, moved the hotfix and upgrade related checks immediately after the
host liveness check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:04:03 +00:00
Mihaela Stoica
e0567387cd
Merge pull request #2375 from xenserver/feature/REQ-602
Merge feature/REQ-602 into master
2019-01-29 10:25:50 +00:00
Mihaela Stoica
df534e3f70 CP-30335: Make all warnings in prechecks non-fixable, to avoid opening a modal dialog (for more info) or an URL when Resolve all is pressed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 17:44:12 +00:00
Konstantina Chremmou
544bcb4978 CP-29923: Provide user friendly descriptions for errors thrown by the host upgrade plugin.
Moved these errors to the FriendlyNames, which is reserved for resources with
keys coming verbatim from the server.
Some code efficiency corrections to the page's workflow.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Konstantina Chremmou
7a4d5719c7 Renamed class and file PropertyManager to FriendlyNameManager to avoid confusion,
because it only manages friendly names; moved it closer to the relevant resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Mihaela Stoica
6d44fd0350 CP-30335 - Part 2: Add a new precheck + Part 3: Enhance the error message displayed in case of migration failure during the RPU (#2371)
* CP-30335: Fix RPU wizard tests

* CP-30335: Add abstract class WarningWithMoreInfo and use it for two of the existing Warnings

* CP-30335: Add a new precheck which produces a warning if the Dom0 memory after the upgrade will be increased.

- if the Dom0 memory after the upgrade is known, then a warning is shown if this is higher than the current memory, regardless of the version of the upgrade
- if the Dom0 memory after the upgrade is not known (e.g. because the rpu plugin does not have the function that returns this), then a warning is shown if upgrading from a pre-Naples version

* CP-30335: Add a more detailed error message if the host evacuation fails due to not enough memory in the RPU and Patching wizards

* CP-30335: Add branding variable for version 8.0

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 14:44:58 +00:00
Mihaela Stoica
b1dba44197
Merge pull request #2373 from xenserver/master
Merge master into REQ-602
2019-01-25 15:17:48 +00:00
Mihaela Stoica
5613a866c0 New certificate thumbprints
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-25 10:46:46 +00:00
Mihaela Stoica
d52ee7ad13 CP-30335: Update RPU wizard page title and text
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Mihaela Stoica
cd393c50e9 CP-30335: Sort Messages.resx
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Mihaela Stoica
e67e5eb644 CP-30335: Rearrange the RPU wizard pages
- Moved Install Location (RollingUpgradeWizard_SelectInstallMethod) page immediatelly after the Upgrade Mode page (and before the Prechecks page)
- Added a new page, called Extras, which contains the updates and supp pack installation options. These options have been moved here from the "Upgrade Mode" and "Ready To Upgrade" pages. This page is also inserted before the Prechecks
- There is no "Ready To Upgrade" page anymore. So the wizard pages are:
   - when automatic mode is selected: Before You Start, Select Pools, Upgrade Mode, Installer Location, Extras, Prechecks, Apply Upgrade.
   - when manual mode is selected: Before You Start, Select Pools, Upgrade Mode, Extras, Prechecks, Apply Upgrade.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Mihaela Stoica
60e2b61bb7 CP-30335: Rename class
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Darren Matthews
7271a59ad9 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-21 10:27:48 +00:00
Konstantina Chremmou
70f1c88881 Further attempt to fix unstable test.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-16 01:34:34 +00:00
Konstantina Chremmou
db6b00265b CA-292363: Provide the user the option to reconsider cancellation of the update
or upgrade process (either when cancelling the wizard itself or when exiting
the application). Rephrased confirmation message for clarity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
749518e94c CA-303195: Provide the user the option to reconsider wizard cancellation
(either when cancelling the wizard itself or exiting the application).
Implemented in the first instance for compiling the server status report.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
b66f11a1e8 CA-303195: Rewrote the logic for compiling and retrieving server status data. The changes include:
- removal of the SystemStatusAction launching the individual SingleHostStatusActions,
because the connection was set incorrectly to the last one of the selected
connections and, if an error occurred to that connection, the data collection
for all of them failed.
- proper handling of HTTP.CancelledExceptions.
- replacement of the FlickerFreeListBox by the more versatile DataGridViewEx.
- corrections to reporting progress for individual hosts as well as page totals.
- made collection of client side data more obvious.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
b94274949e Removed unnecessary call to the base class method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
67a0980318 Brought the Select/Clear All buttons closer to the bottom of the server list
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
5f7407a4bf Wait for RPU wizard to focus after closing the manual upgrade prompt.
Fixed copy paste error.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 12:14:37 +00:00
Konstantina Chremmou
0567d838df Do not set the owner form within the NewDiskDialog constructor; it should be
set by the caller. Test corrections so they don't time out due to blocking
open dialogs. Some tidying up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 09:45:13 +00:00
Konstantina Chremmou
58b65f8a8a Enforce failure if MWWaitFor times out without a message, ortherwise failures
are swallowed. Use optional parameters instead of method overloads. Some other
modernisations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 09:45:13 +00:00
Darren Matthews
1bf47e47df L10N : Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-13 01:06:04 +00:00
Darren Matthews
0f6f7c0ec4 L10N: Translation updates and resx resync (#2363)
L10N: Translation updates and resx resync

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-10 14:03:27 +00:00
Mihaela Stoica
0a5c4c76c5 CA-306864: Allow adding hosts to a pool where the cluster network is a VLAN on top of a bond
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-10 13:46:27 +00:00
minli1
dba6fe1c9e CA-30405: Change/remove message to generic for VM.suspend with VGPU
Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
minli1
25d99ed98e CP-30405: Change/remove message to generic for VM.checkpoint with VGPU
Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
minli1
3f4cf82a13 CP-30405: Refine conditions when creating VM scheduled snapshots.
Since we support checkpoint of Nvidia VGPU dedicated VMs, the conditions
text when new a VMSS needs to be refined.Note that Intel and AMD dedicated
GPUs VMs still be blocked for checkpoint.

Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
Konstantina Chremmou
ada6f7dac7 CA-296490: Upload single update to multiple pools in parallel. (#2338)
* Simplification: use auto-properties.

* Removed unnecessary null check. Converted private methods to linq method chain.

* Removed unused file. Added null check.

* Corrected property names as it was difficult to distinguish between the alert,
the patch and the filepath.

* Removed duplicate lock.

* CA-296490: Rewrote the logic uploading single updates so as to facilitate uploading to multiple pools in parallel.

* Corrections as per code review.

* Account for the case of uploading from disk legacy updates that do not correspond to an update alert.
Removed unfriendly error messages (the failure is written out in the logs anyway).

* Wizard test corrections and some modernising:
- Only call cancel on the last page if the test allows us to.
- Do finish the UpdatesWizard test.
- Finish the RunWizardKeyboardTests using key strokes instead of button clicks.
- Ensure the Cancel/Previous buttons do not have focus when sending an Enter stroke.
- Use optional parameters in the WizardTest constructor and string interpolation.

* Renamed badly named property.

* Improved code cloning VMs by assigning new opaque_refs to cloned VBDs.
Compacted test object provider: use optional parameters instead of method overloads.

* Modifications to prevent multiple update of enabled state and ensure the wizard
buttons are updated last.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-10 13:24:42 +00:00
Konstantina Chremmou
7a0658c908 Reduced accessibility of controls to private. Moved some of the wizard cancelling
logic to the last wizard page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
1789abb901 Reduced accessibility of controls to private. Minor refactoring. Typo. Removed
unnecessary event handler. Removed event that was fired but never subscribed to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
cd2c2f6ea7 Reduced accessibility of controls to private. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
033b7579ef Reduced accessibility of controls to private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Mihaela Stoica
42054964cd
Merge pull request #2361 from xenserver/feature/REQ-396
Merge feature/REQ-396 to master
2019-01-08 10:48:36 +00:00
Konstantina Chremmou
e59019858c Ensure we never attempt getting the file size if file is null
Fixes https://github.com/xenserver/xenadmin/issues/2356
Also, some code modernising.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-07 14:19:02 +00:00
Mihaela Stoica
b4b8d1183c
Merge pull request #2360 from xenserver/feature/REQ-715
Merge feature/REQ-715 to master
2019-01-07 11:28:21 +00:00
Konstantina Chremmou
e99dcc4459
Merge pull request #2359 from kc284/feature/REQ-715
Merging from master
2019-01-04 18:24:50 +00:00
Konstantina Chremmou
01369b4af1 Merge remote-tracking branch 'upstream/master' into feature/REQ-715
# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenModel/InvisibleMessages.Designer.cs
2019-01-04 18:21:55 +00:00
Konstantina Chremmou
46faf191c5 Enforce focus on the radio button so when Enter is hit the wizard proceeds.
Otherwise, the focus may randomly go on the link opening the NewSR wizard; once
the latter is open the test times out.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-04 17:31:48 +00:00
Konstantina Chremmou
e32e67cd02 Added missing copyright notice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-02 12:54:08 +00:00
Konstantina Chremmou
87c50088ea
Merge pull request #2349 from MihaelaStoica/feature/REQ-396
CP-30251: Check version and feature flag to determine UI state
2019-01-02 11:25:23 +00:00
Aaron Robson
dc25f9f53a CP-29875: Remove HelpHelper putting ProduceUrl into HelpManager.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+1 squashed commits)

Squashed commits:

[170a204c] CP-29875: Campaign/Version number should have underscores as separators not points.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+1 squashed commits)

Squashed commits:

[ead4af87] CP-29857: Ensure that the help URL is fully lower case.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+2 squashed commit)

Squashed commit:

[0350c0a6] CP-29875: Include campaign, medium and source in the help URLs.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>

[1e1c1c1c] CP-29875: Refactor and unit test current help URL behavior.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-12-27 12:57:20 +00:00
Aaron Robson
970148e629 CA-305383: Do not save unchanged Snapshot Schedule information. (#2352)
* Updated API bindings to include fix for CA-305383 (Do not save unchanged Snapshot Schedule information). Added unit tests for corrected Helper.AreEqual2 which now considers identical, though not reference equal, generic lists or dictionaries to be equal.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-12-24 13:24:33 +00:00
Darren Matthews
6733649868 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-20 11:06:41 +00:00
Konstantina Chremmou
361de2dc22 Added missing Roaming attribute to ShowUpdatesByServer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 13:05:18 +00:00
Konstantina Chremmou
44d70e6867 Suggested UX enhancement: store the user's preferred updates view; note that
option to change this on the Options dialog has not been provided as deemed
unnecessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00