Commit Graph

2844 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
eb5b01bc83 CP-17282: Unit tests to validate the Update Sequence logic
More tests following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 13:45:36 +01:00
Gabor Apati-Nagy
9337663adb CP-17282: Unit tests to validate the Update Sequence logic
Unit tests to test GetUpdateSequence

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 12:49:53 +01:00
Gabor Apati-Nagy
ee08e06f52 CA-214566: Upload succeeded, but Pool_patch hasn't been found
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-27 19:43:41 +01:00
Gabor Apati-Nagy
5494c19da4 CP-17282: Unit tests to validate the Update Sequence logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-24 10:11:59 +01:00
Gabor Apati-Nagy
1ef1a6615a CP-17282: Unit tests to validate the Update Sequence logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 15:33:18 +01:00
Gabor Apati-Nagy
a8445d5ed8 Fixed warning as an error in build
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 10:27:16 +01:00
Gabor Apati-Nagy
587c2b5f5d CA-214077: Typo in Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 14:43:22 +01:00
Gabor Apati-Nagy
39109d30a4 CA-214062: REQ-156 Batch Updates: In progress actions shown as done
Fixed trivial bug where in progress actions had done shown as their statuses

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 11:07:12 +01:00
Gabor Apati-Nagy
7a84b305ef CP-17699: Developer testing and improvements
for Batch Updating

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-17 14:15:59 +01:00
Gabor Apati-Nagy
ed5429b632 CA-213232: Helpers.OEMName(Host host) can throw NullReferenceException
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-16 11:00:47 +01:00
Gabor Apati-Nagy
546dbca6e1 CP-17444: Show minimal hotfixes on General tab
Changed heading from Recommended Updates to Required Updates following further discussions around wording

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 16:16:01 +01:00
Gabor Apati-Nagy
8692b4b0a6 CP-15790: Added a Debug.Assert
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 14:16:35 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Gabor Apati-Nagy
bd69aab6d2 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Changes following code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-03 15:08:30 +01:00
Gabor Apati-Nagy
d449b153b3 Merge remote-tracking branch 'github_xenadmin/REQ-156' into master_batch_new2 2016-06-03 13:31:00 +01:00
Gabor Apati-Nagy
9ea99ec91a Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-03 13:28:48 +01:00
Mihaela Stoica
f449d4e583 Merge pull request #1010 from GaborApatiNagy/master_CA-187187
CA-187187: Enable AD on pool failing when one of the hosts have failed
2016-06-03 10:55:16 +01:00
Gabor Apati-Nagy
5b37c036d8 CA-187187: Enable AD on pool failing when one of the hosts have failed
Calling disable as best effort. (We always call disable AD before enabling AD -  CA-48122)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-02 15:09:01 +01:00
Mihaela Stoica
00a57808cc Merge pull request #1009 from GaborApatiNagy/master_CA-209290
CA-209290: "Virtualization state" label displayed twice on General Tab of newly created VM
2016-06-02 13:46:17 +01:00
Gabor Apati-Nagy
725beacd4b CA-209290: "Virtualization state" label displayed twice on General Tab of newly created VM
Fixed duplicated headers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-02 12:03:26 +01:00
Gabor Apati-Nagy
81ec2af86b Merge pull request #1003 from MihaelaStoica/CA-208829
CA-208829: Unexpected error if connection lost while health check dia…
2016-06-01 14:01:47 +01:00
Mihaela Stoica
82a274571b Merge pull request #1002 from GaborApatiNagy/master_CA-208707
CA-208707: [SCTX-2316] XenCenter Incorrect pop-up error message displayed if SSL secure channel cannot be created
2016-06-01 14:00:50 +01:00
Mihaela Stoica
3b58dd1f07 Merge pull request #1008 from GaborApatiNagy/master_batch_CP-15714
CP-15714: UI: Change Select Servers Page
2016-06-01 13:50:56 +01:00
Mihaela Stoica
2b993a4a9c Merge pull request #1007 from Frezzle/vdi-attach-exception
CA-211418: Exception in XenCenter while attaching vdi to a VM on a p…
2016-06-01 13:46:58 +01:00
Gabor Apati-Nagy
3561155d03 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Some more on error handling, better displaying of errors

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-01 13:45:21 +01:00
Gabor Apati-Nagy
81a0bf20f9 CP-15714: UI: Change Select Servers Page
DownloadUpdatesXmlAction is called on PageLeave and not when the user selects Automatic Mode. This way we get the error message at the right time, also showing a progress dialog what makes the UX much better.
New tooltips for servers on the Select Server Page to to cover two more cases

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-31 19:00:35 +01:00
Frederico Mazzone
b21d87e6e6 [CA-211418] Exception in XenCenter while attaching vdi to a VM on a pool with an SR with 20,000 VDIs
Added back the event handler removal in BuildList function, as it can run more than once.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-31 11:23:31 +01:00
Frederico Mazzone
b401a11e76 [CA-211418] Exception in XenCenter while attaching vdi to a VM on a pool with an SR with 20,000 VDIs
All event handlers are now unsubscribed when AttachDiskDialog is closed, allowing its memory to be garbage collected.
Image for each VDI now references an existing image instead of creating a new object.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-25 16:37:31 +01:00
Gabor Apati-Nagy
76a709b11c Merge pull request #1001 from MihaelaStoica/CA-211417
CA-211417: Remove WLB.chm
2016-05-24 11:01:07 +01:00
Mihaela Stoica
67e4e2113f CA-208829: Unexpected error if connection lost while health check dialog open
- Invoke on the main thread

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-23 14:11:03 +01:00
Gabor Apati-Nagy
9d2a204bb7 CA-208707: [SCTX-2316] XenCenter Incorrect pop-up error message displayed if SSL secure channel cannot be created
My commit fixes the error message so the dialog will show "Could not create SSL/TLS secure channel." instead of "An unknown error occurred". This text is localised.
Unfortunately we see only a WebException with Status=SecureChannelFailure with no other details - couldn't provide an improved error message

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-23 12:48:01 +01:00
Mihaela Stoica
0527164425 CA-211417: Remove WLB.chm
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-23 11:42:33 +01:00
Mihaela Stoica
f2e1f166ec Merge pull request #1000 from Frezzle/ad-awareness
CP-17415: XC: Add awareness of new AD feature flag
2016-05-23 11:30:52 +01:00
Frederico Mazzone
797f9e1283 [CP-17415] XC: Add awareness of new AD feature flag
Added Chinese tranlations to AD upsell tab.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-23 10:36:33 +01:00
Mihaela Stoica
6919a50c95 Merge pull request #999 from Frezzle/ad-awareness
CP-17415: XC: Add awareness of new AD feature flag
2016-05-20 14:53:08 +01:00
Frederico Mazzone
8954c2e038 [CP-17415] XC: Add awareness of new AD feature flag
Added AD-related strings to japanese and chinese resource files; still need translation.
Changed F1/Help mapping of the AD upsell tab to go to the 'Managing Users' help page.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 14:30:39 +01:00
Frederico Mazzone
9a729e2547 [CP-17415] XC: Add awareness of new AD feature flag
Added awareness; basic license now shows upsell tab and premium license shows full feature tab.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 13:01:51 +01:00
Gabor Apati-Nagy
73d67f407d CP-15719: UI: Implement error handling/reporting on Upload & Install page
Implemented error handling.
If there has been an error in a pool, we stop executing actions in that pool immediately, and report the error once every other actions have finished. Error in one pool will not affect the upgrade process of other pools.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-18 13:43:34 +01:00
Gabor Apati-Nagy
5ba776d0bf Merge pull request #996 from Frezzle/lost-scrollbar
[CA-208810]: I18n:JA/SC:  Lost Scrollbar for the long strings...
2016-05-18 13:32:51 +01:00
Frederico Mazzone
781fcba141 [CA-208810]: I18n:JA/SC: Lost Scrollbar for the long strings...
Made textbox bigger in health check policy dialog.
Made textbox bigger in the 'Authentication with Citrix Insight Services'
section of the health check enrollment dialog.
Adjusted some control properties to correct the position of OK/Cancel
buttons.
Changed 'User name:' labels to 'Username:' in health check enrollment
dialog.
Changed Chinese and Japanese resource files to match English changes.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-16 14:29:21 +01:00
Allen Wu
acc010dfd9 CA-210638: Modify alert message to make it consistent for WLB. (#994)
Signed-off-by: Allen Wu <allen.wu@citrix.com>
2016-05-16 11:06:47 +01:00
Mihaela Stoica
a81bb46282 Merge pull request #991 from sriharshak/master
L10N: Xencenter:Help Update
2016-05-16 09:46:52 +01:00
CITRITE\sriharshak
0da47aa988 L10N: Xencenter:Help Update 2016-05-16 09:04:45 +05:30
Mihaela Stoica
8656692014 Merge pull request #989 from MihaelaStoica/CA-210984
CA-210984: XenCenter build fails in the secure environment while gett…
2016-05-13 13:57:50 +01:00
Mihaela Stoica
16270af4d4 CA-210984: XenCenter build fails in the secure environment while getting RPU hotfixes from artifactory
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-13 12:31:55 +01:00
Mihaela Stoica
9fed9630f4 Merge pull request #987 from MihaelaStoica/master
Fix re-branding of the product version
2016-05-13 00:43:42 +01:00
Mihaela Stoica
ed393b5800 Fix re-branding of the product version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-13 00:40:35 +01:00
Mihaela Stoica
abfa51a64f Fix Unbound variable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-13 00:39:24 +01:00
Mihaela Stoica
3f7f33fc40 CA-210732: XenCenter VM properties GPU always shows "None" (#983)
* CA-210732: XenCenter VM properties GPU always shows "None"

The error occurs when there is a gpu group with only one vgpu type: When setting the selected item in the vGPU combobox, XenCenter tries to select the group header instead of the vGPU type; because the group header is not selectable, we then default to "None".
With this fix, we ensure that two items are not equal if one is a group header and the other is a subitem.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Changes following code review: Added the reverse case in the Equals function

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-12 13:44:16 +01:00