Commit Graph

3193 Commits

Author SHA1 Message Date
Konstantina Chremmou
f1a43abbf0 Refactoring: it's not a good idea to set virtual members in constructors; thus
the MenuText can stay a getter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:44 +01:00
Konstantina Chremmou
4bf04e6279 In Move mode the text on the destination page should read "move the VMs" and not migrate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:37 +01:00
Konstantina Chremmou
55f1a03224 Fixed wrong images in the following cases:
- the image for resume suspended VM on non-home server should be connected-server,
not vm-being-migrated.
- the image for a server where a running VM cannot be migrated to should be connected-server,
not disconnected-server (it is disabled anyway). Also, simplified the logic to obtain
the cannot-execute-reasons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:30 +01:00
Konstantina Chremmou
6833722992 Renamed command so it's more obvious what it does and made some corrections to its checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:23 +01:00
Konstantina Chremmou
97278e88ad Refactoring: normally we create the actions in the wizard class obtaining the parameters
from the page properties; removed unnecessary field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:04 +01:00
Mihaela Stoica
0b2f63461a Merge pull request #1181 from xenserver/GaborApatiNagy-CA-223082
CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
2016-09-26 13:33:47 +01:00
Gabor Apati-Nagy
ccaeed67cb CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
Replace PATCH_PRECHECK_LIVEPATCH_MISSING to PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE due to changes in XAPI
Note: if XAPI change gets active before this change we will see UNKNOWN instead of PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE in XenCenter what will make no difference
2016-09-23 13:35:02 +01:00
Mihaela Stoica
c6eab65fdf Merge pull request #1154 from kc284/master
Some corrections on VMStorage page and disk move/migrate/detach
2016-09-22 15:21:48 +01:00
Mihaela Stoica
8ea8c71f74 Merge pull request #1164 from kc284/master2
Did some work on the SrStoragePage:
2016-09-22 14:12:59 +01:00
Mihaela Stoica
502f436b03 Merge pull request #1180 from mcintyre94/CA-218260
CA-218260: Reverting to Snapshots causes VM to go back to parent host
2016-09-22 14:12:05 +01:00
Callum McIntyre
336e4d8149 CA-218260: Reverting to Snapshots causes VM to go back to parent host
Move the test for whether we can boot the VM on the previous host into the VmSnapshotRevertAction, and run it using the Session of the action.
2016-09-22 13:36:43 +01:00
Callum McIntyre
d30ff533fd CA-218260: Correcting nesting
The else if (vm.power_state == vm_power_state.Suspended) block had been incorrectly moved out an indent level to the outer if.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-21 17:45:42 +01:00
Callum McIntyre
502e386e53 CA-218260: Reverting to Snapshots causes VM to go back to parent host
Where we have a host the VM is running on (ie vm.resident_on is not null) at the time it is reverted, attempt to start/resume on that host if possible, instead of the home server of the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-21 17:39:03 +01:00
Konstantina Chremmou
03639d35b5 Added missing hotkey to the delete toolstripmenuitem; changed the hotkey on the move
toolstripmenuitem so it's the same as the button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 23:12:54 +01:00
Mihaela Stoica
1b8566e149 Merge pull request #1178 from xenserver/revert-1169-master_batch
Revert "CP-18925: Hide batch hotfixing option in XenCenter"
2016-09-20 15:03:58 +01:00
Gabor Apati-Nagy
b09de72f83 Revert "CP-18925: Hide batch hotfixing option in XenCenter" 2016-09-20 15:00:06 +01:00
Mihaela Stoica
a04e8dbccf Merge pull request #1123 from GaborApatiNagy/CA-150816
CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
2016-09-20 14:02:18 +01:00
Mihaela Stoica
e5eeb29e55 Merge pull request #1170 from kc284/master3
CA-100083 (part of): Set minimum width of the main window's tab contr…
2016-09-20 13:57:39 +01:00
Konstantina Chremmou
6bb71ffd23 Merge pull request #1124 from GaborApatiNagy/CA-174979
CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
2016-09-20 13:15:36 +01:00
Konstantina Chremmou
2aa8d956c0 Fixed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 13:10:02 +01:00
Mihaela Stoica
963d5211d6 Merge pull request #1174 from mcintyre94/CA-217821
CA-217821: Renaming home server to target server in VM migration wizard
2016-09-20 11:43:24 +01:00
Konstantina Chremmou
a7afe39b90 Merge pull request #1175 from MihaelaStoica/CA-218242
CA-218242: Don't assign values outside the range in the memory spinne…
2016-09-20 11:26:56 +01:00
Gabor Apati-Nagy
6742d72461 CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Removed a no longer used string from Messages.resx

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-20 10:43:05 +01:00
Mihaela Stoica
37da772c2d Merge pull request #1172 from GaborApatiNagy/master_CA-222118
CA-222118: CentOS 7 VM's  XenServer Tools installation message is mis…
2016-09-19 23:34:30 +01:00
Mihaela Stoica
a4ffaf239f CA-218242: Don't assign values outside the range in the memory spinner control
- The value of the spinner control is rounded to the nearest, while the minimum is rounded up and the maximum down (or, in some cases, min and max are not rounded at all).
In most cases this is fine, but if the current value (in bytes) is equal to one of these ranges, by rounding this way we might end up with a value that is outside of the control's ranges (causing ArgumentOutOfRange exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-19 23:14:26 +01:00
Gabor Apati-Nagy
d12481fa0f CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Leaving the new pool's name field empty, forcing user to enter a name before the Next button is enabled.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 18:15:44 +01:00
Gabor Apati-Nagy
93a7c3c7c7 CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
Changed the text to be more meaningful as agreed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 17:50:10 +01:00
Callum McIntyre
0c5eaef042 CA-217821: Renaming home server to target server in VM migration wizard
We already renamed the column to target server, this changes the message in the case where the user doesn't choose a server on this page to also use target server.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-19 17:00:02 +01:00
Gabor Apati-Nagy
9b383054af CA-222118: CentOS 7 VM's XenServer Tools installation message is misleading in Notifications
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 14:10:21 +01:00
Konstantina Chremmou
2fdf033b25 Merge pull request #1150 from mcintyre94/CA-149965
CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog.
2016-09-19 12:22:48 +01:00
Mihaela Stoica
65db5e3320 Merge pull request #1171 from mcintyre94/CA-219777
CA-219777: Bad progress dialog message
2016-09-19 12:03:57 +01:00
Callum McIntyre
6136f70d13 CA-219777: Bad progress dialog message
The bad message was in the dialog created in the BugToolWizard after selecting servers. Since this method is the only one using the ActionProgressDialog(String) constructor, I've modified that ctor to hide the subaction label - which makes sense because there is no action in that ctor (to set a subaction) and no other appropriate label.
2016-09-19 11:31:48 +01:00
Callum McIntyre
c9dc5af32d CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog
Shorten the ellipsise to the first 40 characters instead of 45, which allows the ellipsis, quotation and question marks to fit correctly onto the line.
2016-09-19 10:37:48 +01:00
Mihaela Stoica
db9eea0cf6 Merge pull request #1168 from sriharshak/master
L10N: Ely:Translation check-ins
2016-09-18 07:12:27 +01:00
Konstantina Chremmou
565f95291d CA-100083 (part of): Set minimum width of the main window's tab control to 40% to
avoid buttons on the console tab overlapping. Removed some panels from the console
tab to reduce control nesting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-17 01:23:55 +01:00
Mihaela Stoica
90cdd85ad7 Merge pull request #1169 from GaborApatiNagy/master_batch
CP-18925: Hide batch hotfixing option in XenCenter
2016-09-16 14:19:50 +01:00
Gabor Apati-Nagy
bd7d6bcc9c CP-18925: Hide batch hotfixing option in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-16 14:04:10 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Mihaela Stoica
6c61c0d026 Merge pull request #1158 from kc284/CA-219461
CA-219461: A new disk requires VM shutdown-restart in order to appear…
2016-09-15 09:52:29 +01:00
Gabor Apati-Nagy
00a4927f6b Merge pull request #1167 from stephen-turner/CA-220440
CA-220440: Remove CLM link from XenCenter home page
2016-09-14 15:54:41 +01:00
Stephen Turner
3154a0bd92 CA-220440: Remove CLM link from XenCenter home page 2016-09-14 15:31:21 +01:00
Konstantina Chremmou
9a26b3cb2e Did some work on the SrStoragePage:
- show/hide the context menu items instead of creating and adding new ones each time the context menu opens
- right click menu with rescan/add was not available for empty list or when empty space was clicked
- the condition for the edit button was slightly different from the edit toolstripmenuitem
- improved button layout (part of CA-100083)
- tidied up button event handlers and renamed one or two class members
- removed unused parameter in constructor and method of VDIRow

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-14 09:06:19 +01:00
Mihaela Stoica
91ef745b9c Merge pull request #1162 from stephen-turner/one-comment-v2
Comment on the VM.IsWindows method
2016-09-13 16:23:29 +01:00
Stephen Turner
a8c6e81ceb Comment on the VM.IsWindows method 2016-09-13 12:16:55 +01:00
Mihaela Stoica
4f46345b96 Merge pull request #1160 from GaborApatiNagy/master_CA-220599
CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
2016-09-13 10:11:47 +01:00
Konstantina Chremmou
0f9c6fbc2f Did some work on the VM storage page:
- fixed issue where the context menu with add/attach items was not available
for empty list or when empty space was clicked; in the latter case I also clear
the selections
- added ability to launch the context menu by using the windows properties button
- moved context menu to the designer; changed code to show/hide the relevant menu
items instead of adding new ones each time the context menu opens
- added icon to the context menu item Properties
- fixed button layout (part of CA-100083), then removed separators between buttons
because when they wrap it looks a bit strange
- fixed some weird cross-threading exception (could not reproduce reliably)
- renamed one or two class members and tidied up the button event handlers

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-13 01:29:47 +01:00
Gabor Apati-Nagy
fdb32cf579 CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
Fixed regression caused by 5555709337.
Supplemental packs can now be installed again in automatic mode.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-12 17:07:59 +01:00
Konstantina Chremmou
c6004b664b CA-219461: A new disk requires VM shutdown-restart in order to appear, not VM reboot.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-12 14:34:57 +01:00
Konstantina Chremmou
f4dfbe83b4 Merge pull request #1155 from MihaelaStoica/CA-220613
CA-220613: Truncation on the Migration Network page of the Cross Pool…
2016-09-12 09:02:28 +01:00
Konstantina Chremmou
6298a7e885 Do not calculate twice the VMs to move or migrate. Text improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-09 18:52:38 +01:00