Mihaela Stoica
f2a5b1936c
CA-293316: Add latest XenAPI bindings to XenCenter
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-03 10:46:53 +01:00
Jisheng Xing
b6e1ad6b83
fix typos and rename a function
2018-06-21 14:54:47 +01:00
Jisheng Xing
538e6f90a1
fix some comments
2018-06-21 14:54:47 +01:00
Jisheng Xing
cb1da504fd
CA-289627: SR-IOV on NIC tab is confusing
...
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-21 14:54:47 +01:00
Konstantina Chremmou
d9ee664d53
CA-289629: launch confirmation dialog within a using block.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-18 21:59:38 +01:00
jishengx
cf20ac13c4
CA-289629: prompt host may need to be rebooted to enable SR-IOV ( #2092 )
...
CA-289629: prompt host may need to be rebooted to enable SR-IOV
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-18 12:36:12 +01:00
Ji Jiang
88224df214
CA-290316: Skip hotfix homogeneity precheck in mixed pool
...
Because we couldn't control user's selected combination from
a mixed pool, and the version compatibility precheck exists already,
here just simply skip the precheck and issue a warning.
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-08 11:17:41 +01:00
Konstantina Chremmou
1b4a862fd0
Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
20d74a64c9
Unregister handlers when leaving or cancelling the page and invoke on the current
...
control instead of the main window (may cure CA-289721).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
b36993228c
Moved index retrieval in Invoke and corrected index sanity check. Update the combobox
...
and unregister item event in a try-finally block (may cure CA-289721); suspend-resume
layout when updating the datagridview.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
3f8feb4bdd
Removed invocations where we are already on the UI thread.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2e07781e6b
Simplify the logic toggling the enabled state of the Next button depending on the selection.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
621fce4d70
Fixed regression whereby the vm-host mapping was lost when proceeding to the next page and returning to the destination selection page.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
355621f183
Simplified event signature.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
1d905fc18c
Simplified logic when fetching the failure reason; capitalised constant names so they're more visible.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2c3c4bf5ca
Renamed methods so it's more obvious what they do.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
57ab2ced2b
CA-289335: If there is no other network available, pick the management network for the migration of VDIs.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-06 16:06:41 +01:00
Konstantina Chremmou
14aa3f3f5d
CA-289335: Do not check the NetworkComboBoxItem can be selected unless it has been added to the ComboBox.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-06 16:06:41 +01:00
Alexander Schulz
a294c61bd0
Remove shortcut definition from MainWindow resx files, Shortcut is already defined in Commands\NewVMCommand.cs
...
https://github.com/xenserver/xenadmin/pull/2078
2018-06-05 11:15:18 +01:00
Alexander Schulz
c26de212da
Use "Control+N" instead of "Ctrl+N" to be buildable on non-english operation systems
2018-06-05 11:15:18 +01:00
Jisheng Xing
7034973ae1
CA-287651: Precheck shows SR broken on both hosts but it is only broken on one
...
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-05 05:45:57 +01:00
Jisheng Xing
b85c6d9f60
CA-289618: Clear the created network after enabling SR-IOV failed
...
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-04 12:06:40 +01:00
Mihaela Stoica
c2b42fa107
CA-289335: Refactoring to avoid setting the SelectedItem twice
...
- also avoids iterating through the combobox items again to determine which item to select
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Mihaela Stoica
54b134a2eb
CA-289335: Show empty selection if the cluster network cannot be resolved
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Mihaela Stoica
a74ee3a793
CA-290064: Make the FibreChannelProbeAction an AsyncAction, because the PureAsyncAction throws an exception when collecting the API methods for RBAC checks.
...
An exception is thrown by the ProcessXml function if the result is an empty string, which is the case when the action is run with the RbacCollectorProxy to collect the API calls
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 13:00:05 +01:00
Mihaela Stoica
5d0b760a96
CA-288751: Fix the RBAC checks for probe_ext
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 13:00:05 +01:00
Ji Jiang
9ddb253ec0
CP-26866: Add a specific warning when creating a bond on cluster network
...
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-05-23 16:47:59 +01:00
serenc
29d82b1498
CP-28229: Update XenCenter to remove Cluster.network
2018-05-18 16:40:59 +01:00
Konstantina Chremmou
9a7fcde66e
CA-289948: Do not show the upsell dialog if migration is not permitted due to licensing restrictions; launch the move VM dialog instead.
...
Also, removed unused constructor.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-18 16:37:12 +01:00
Konstantina Chremmou
2f2a533b46
Fixed some column sizing issues on the VM, SR and physical storage pages as well as a regression in the selection mode of the last one.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-17 15:45:50 +01:00
Mihaela Stoica
01c8a7ed83
CA-289150: Use a local variable to avoid calculating DistinctHosts twice
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:33:31 +01:00
Mihaela Stoica
2dab045441
CA-289150: Use a lock object to ensure that the hosts and connections lists are safely accessed from separate threads
...
This change fixes the crash with IndexOutOfRangeException in XenServerUpdateAlert
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:33:31 +01:00
Mihaela Stoica
5ad2aa302e
CA-289959: Add null checks when resolving the updates which require reboot
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:24:51 +01:00
Mihaela Stoica
171284ff34
CP-28094: Rationalise device-config keys with SMAPIv1
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-16 17:18:12 +01:00
Konstantina Chremmou
c475861941
CA-248353: Refactoring to avoid referencing cells with hardcoded index numbers,
...
which makes them undiscoverable and breaks if the columns are rearranged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
81115674e7
Removed DataGridView grid because we normally don't use one. Renamed columns
...
to make them more discoverable. Removed unused class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
085b4d4f6e
CA-248353: Do not use a hardcoded string or integer to reference DataGridView columns or ToolStripMenuItems.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
7cc1402099
CA-248353: Do not use a hardcoded string to find the status image column as
...
the code will break if the column on the LicenceManager is renamed. Also, do
not create the new cell before the index checks pass.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
6a36bf37ff
The designed class should be the first one in the file, otherwise VisualStudio's designer breaks.
...
In this case, the CheckableDataGridViewRowEventArgs are very specialised and can be nested in the CheckableDataGridView.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
79684617eb
CA-248353: Reference the column object directly instead of trying to retrieve it using a hardcoded string as a key.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
0d8f61fbb0
CA-289182: Corrections to sorting (clearer handling of null cases, non-XenObjects, logic path inconsistencies).
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-14 14:56:42 +01:00
Konstantina Chremmou
fd2ee1922a
CA-286291: Missing copyright.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-14 13:37:40 +01:00
Mihaela Stoica
8992e55141
CA-286291: Add the additional menu items immediately after the first item, so we don't have to wait for the WLB recommendations to be
...
retrieved.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-14 12:30:40 +01:00
Mihaela Stoica
ba8a612c01
CA-286291: Remove the ToolTip from the VMOperationTollStripManuSubItem, as the reason why the item is disabled is already included in the items's MenuText
...
This change improves the performance of the drop-down menu considerably, as it avoids the server calls from the Command.ToolTipText
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-14 12:30:40 +01:00
Mihaela Stoica
025e92bc7d
CA-286291: Some more refactoring in VMOperationToolStripManuItem
...
(including the removal of the HostListUpdater class)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-14 12:30:40 +01:00
Mihaela Stoica
7ba8546929
CA-286291: Refactoring in VMOperationToolStripManuItem
...
- added an action for the API call that retrieves the WLB VM recommendations
- removed the thread used for updating the menu items, so that we always access the menu items on the UI thread and do only the server calls on separate threads (for WLB, getting the recommendations now is done on the new action, for non-WLB we have the `workerQueueWithoutWlb`)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-14 12:30:40 +01:00
Jisheng Xing
79f91ce2b4
CA-288188: correct the NICPage status when SR-IOV logical pif unplugged
...
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-05-14 12:14:22 +01:00
Konstantina Chremmou
0c3298fd8b
CA-289153: Do not attempt updating the licence status for disconnected hosts. ( #2072 )
...
Also, no need to trigger an event when the host is null or when get_servertime
fails only to double-log it in the handling class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-11 16:38:46 +01:00
Konstantina Chremmou
8ae3ceeea1
CA-289718: Refine the storage connections precheck to allow the installation of an update that has been uploaded to a local SR ( #2071 )
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-11 14:38:44 +01:00
Konstantina Chremmou
f9a7e64086
Merge pull request #2068 from xenserver/release/kolkata/master
...
Merge release/kolkata/master into master
2018-05-10 13:46:53 +01:00