Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,203 Commits 11 Branches 48 Tags 186 MiB
f5075e8eac
Commit Graph

6203 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
f5075e8eac Sorted string prior to merging from master (where there are sorted). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-30 15:00:27 +01:00
Danilo Del Busso
893f42d831 CP-39114: Add CHCUpdates.xml and dev-CHCUpdates.xml generation to build script 
dev-CHCUpdates.xml contains a placeholder value for the destination URL
- Add existence check for `pdb` files in build script
 This prevents script from stopping if MSBuild didn't generate any `pdb` files in `packages`
- Insert placeholders for pipeline and branding in Jenkinsfile
- Remove existence check for package `pdb`s in build script
 Also simplify MSI checksum extraction from `sha356sum` call

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-30 13:59:17 +01:00
Danilo Del Busso
ccf7fbe01a CP-39128: Make UPDATES_URL a branded string 
- Add VS Enterprise as option for building project
 Also add to `re-branding.sh` replacement list
- Bump branding version to v4.3
- Add default `UPDATES_URL` to `branding.sh`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-30 13:59:17 +01:00
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959) 
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 15:25:32 +01:00
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968) 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-03-10 14:16:13 +00:00
Konstantina Chremmou
ff76729940 Hide the client update button by default. Added null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-21 15:56:06 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953) 
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
 2022-02-18 10:24:33 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch. 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments. 
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
c1c8c3d1c3 Adds updates check started/completed event handlers 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction 
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
CitrixChris
05cbae25ce
CP-32667 Added download action to CHC (#2912) 
Added the interface option to download and install updates for client updates. Disabled by default until CP-31587 does the proper checks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-12-16 10:34:00 +00:00
Konstantina Chremmou
eef4e5f995 CP-38427 issue 1: Do not allow enabling TLS verification during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-30 22:46:43 +00:00
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898) 
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-11-22 12:02:26 +00:00
Konstantina Chremmou
c2f92aa02a
Merge pull request #2903 from danilo-delbusso/CP-36392-Bugs 
CP-36392: Address statically flagged trivial issues that can cause bugs
 2021-11-17 11:36:48 +00:00
Danilo Del Busso
f2fdf31a5a
CP-36392: Avoid multiple enumerations in LicenseStatus.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-17 09:01:25 +00:00
Danilo Del Busso
3e861411db
CP-36392: Invert if statements to reduce nesting in HostMemoryControls and changeControlDomainMemoryCommand 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:42:18 +00:00
Danilo Del Busso
47510f5b07
CP-36392: Reassign expiryGroups after ordering 
regression from db2c00d5

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:39:50 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
 2021-11-15 15:49:39 +00:00
Danilo Del Busso
e791b70ba7
CP-36392: Move return to new line in Search.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:39 +00:00
Danilo Del Busso
11e90940e0
CP-36392: Simplify Equals method in QueryTypes.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:08 +00:00
Danilo Del Busso
f66216bf7b
CP-36392: Improve readability in Name method of Network's xapi extension 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:18:32 +00:00
Danilo Del Busso
9b4f960336
CP-36392: Check for whitespace-only values in GEtPerfmonDefinitions 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:15:29 +00:00
Danilo Del Busso
cfff0722c7
CP-36392: Limit ex-readonly public lists to {get;} usages only 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:11:41 +00:00
Danilo Del Busso
6f7faefce1
CP-36392: Replace complex method with single LINQ calls in DRFailoverWizardStoragePage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:09:11 +00:00
Danilo Del Busso
68b54682ae
CP-36392: Move param checks outside of RepairSRDialog.cs's constructor 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:05:08 +00:00
Danilo Del Busso
31702c9e43
CP-36392: Add null checks for ControlDomainMemoryDialog's constructor params 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:00:50 +00:00
Danilo Del Busso
cc917e2a66
CP-36392: Simplify if and else if blocks to reduce nesting in AddServerDialog.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:57:08 +00:00
Danilo Del Busso
1acce3638c
CP-36392: Move vms null and Count checks outside of WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

damni

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:52:06 +00:00
Danilo Del Busso
396bcb0e35
CP-36392: Make type field readonly in QueryElement.cs 
field is used in `GetHashCode`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:46:12 +00:00
Danilo Del Busso
494f78966d
CP-36392: Address logic issue in FilterLocationToolStripDropDownButton.cs 
As suggested during review:

> The check after the `&&` should go in a nested if block: if we are in a split second where the cache has not been populated yet, there should be no item added, however, this code will add a `p` item.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:43:50 +00:00
Danilo Del Busso
02439d5303
CP-36382: Replace _nameCell with ad-hoc _xenObject readonly field 
To ensure that the field in the `GetHasCode` call is `readonly`
Also remove unused constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:36:42 +00:00
Danilo Del Busso
5d5d971c74
CP-36329: Remove redundant verbatim in WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:21 +00:00
Danilo Del Busso
47884376a3
CP-36392: Fix typo in VNCTabView.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:19 +00:00
Danilo Del Busso
caf608344e
CP-36392: remuve redundant iteration in ResumeVMOnHostToolStripMenuItem.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:24:17 +00:00
Danilo Del Busso
5f117e90c5
CP-36392: Add null check in EnableHostAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:21:25 +00:00
Danilo Del Busso
b6a70e2ffc
CP-36392: Add null check for _vmOptList in WlbOptimizePoolAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:55 +00:00
Danilo Del Busso
45512b4cde
CP-36392: Add removed null check in WlbOptiomizePool.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:09 +00:00
Danilo Del Busso
6ce0a4b49d
CP-36392: Remove repetitive count and null check 
Check is performed within the constructor of `WlbRecommendations`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 16:07:36 +00:00
Danilo Del Busso
2978f60f8a
CP-36392: Improve readability of latest changes 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:23:21 +00:00
Konstantina Chremmou
688fe99e3e CA-359969: Do not rebuild the list if the scanning of the SRs has not finished yet. Removed unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-02 16:53:48 +00:00
Danilo Del Busso
6f6c768913 CP-38424: Bump dotnet-packages build location 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-27 15:18:47 +01:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
 2021-10-27 13:24:23 +01:00
Konstantina Chremmou
c44f6496df CA-360011: Allow full disk copy only if all VDIs of the snapshot/custom template allow it. 2021-10-26 16:55:18 +01:00