The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs
* CA-359965: Fix miscellaneous formatting issues
* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.
* Use slightly more intuitive name for property; also inverted its logic.
* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.
* Re-arranged classes in file.
* Refactored SrPickerItem:
- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
so that the correct size can be used for each storage (thin vs. non-thin provision).
* Correction as per code review and some tweaks to make the checks clearer and more efficient.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Resetting the clip so that on the next render we don't hide labels and title.
Also moved logic outside `LineRenderer.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Do not dispose of the activeView when pausing the console (which happens
when we move away from the console tab.
- When setting a new source, remove and re-add the activeView only when
it has changed.
- Dispose an unneeded view immediately instead of starting a timer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The body of the setter never proceeds before the first line because value==_state
and the child's level has just been increased and is zero or greater.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Sharp turns in the graph can result in the line being drawn outside of the box.
This change makes sure the line is only rendered within the input rectangle.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode
Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-36392: Add several `null` checks
All were flagged by SonarQube
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Specify `namespace` for `SettingsUpdate`
Added to `XenAdmin`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Collapse useless condition check
Also use pattern matching for type cast
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Specify `namespace` for `ProduceConsumerQueue`
Add to `XenAdmin.Actions`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Add explicit `null` check
While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Replace useless self-assignment with ad-hoc method
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Fix minor formatting issues
Add newline at end of file, and reformat content of if statement
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Tidy up latest flagged bugs changes
- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Tidy up setter in `ChangeableList.cs`
Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
As suggested during review:
> The check after the `&&` should go in a nested if block: if we are in a split second where the cache has not been populated yet, there should be no item added, however, this code will add a `p` item.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
To ensure that the field in the `GetHasCode` call is `readonly`
Also remove unused constructor
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
