xenadmin/XenAdmin/Controls
Danilo Del Busso 77bd034e8d
CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028)
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs

* CA-359965: Fix miscellaneous formatting issues

* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.

* Use slightly more intuitive name for property; also inverted its logic.

* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.

* Re-arranged classes in file.

* Refactored SrPickerItem:

- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
  to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
  so that the correct size can be used for each storage (thin vs. non-thin provision).

* Correction as per code review and some tweaks to make the checks clearer and more efficient.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-11 09:26:54 +01:00
..
AD CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
Ballooning Renamed methods so they describe better what they do. 2022-03-03 14:36:06 +00:00
CheckableDataGridView CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
ComboBoxes CP-36392: Refactor getter so that it doesn't clash with private field 'selectedCD' 2021-09-20 09:35:22 +01:00
Common CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
ConsoleTab CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
CustomDataGraph CA-368958: Reset clip region once performance lines are drawn 2022-07-21 14:28:43 +00:00
CustomGridView Code style fixes. Removal of unused code. 2022-04-11 22:57:08 +01:00
CustomListPanel CP-36392: Inherit IDisposable to avoid confusion 2022-02-24 11:53:44 +00:00
DataGridViewEx CP-36382: Replace _nameCell with ad-hoc _xenObject readonly field 2021-11-15 09:36:42 +00:00
Folders CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
GPU CA-359744: Do not add a host label if the host has disappeared from the cache. 2021-10-26 00:47:08 +01:00
MainWindowControls Fixed some code smells. 2022-06-16 11:21:42 +01:00
NetworkingTab L10N : Resx resync and Translation Updates 2022-01-05 11:38:40 +00:00
SummaryPanel L10N : Resx resync and Translation Updates 2022-01-05 11:38:40 +00:00
Tags CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
TreeViews Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 2021-10-27 13:24:23 +01:00
Wlb Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads. 2022-02-03 11:59:17 +00:00
XenSearch CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 2022-04-06 13:11:33 +01:00
AffinityPicker.cs Fixes issue where the Finish page of the NewVM wizard was not showing the selected home server correctly. 2022-10-07 09:19:10 +01:00
AffinityPicker.Designer.cs Fixes issue where the Finish page of the NewVM wizard was not showing the selected home server correctly. 2022-10-07 09:19:10 +01:00
AffinityPicker.ja.resx L10N : Translation Updates 2019-06-09 17:04:28 +01:00
AffinityPicker.resx CA-107915: Fixed radiobutton text truncation on the AffinityPicker by providing 2013-09-27 13:33:57 +01:00
AffinityPicker.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
BondDetails.cs CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
BondDetails.Designer.cs Reduced accessibility of controls to private. Moved some of the wizard cancelling 2019-01-08 12:01:46 +00:00
BondDetails.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
BondDetails.resx CA-188553: [PAR-80] Creating a VLAN with MTU 9000 should be disabled 2015-12-21 18:09:48 +00:00
BondDetails.zh-CN.resx L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
BootOrderListBox.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
ChevronButton.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
ChevronButton.Designer.cs CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button. 2016-07-20 00:04:06 +01:00
ChevronButton.ja.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
ChevronButton.resx CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button. 2016-07-20 00:04:06 +01:00
ChevronButton.zh-CN.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
ChevronToggleButton.cs CP-20425: Use static images everywhere an image is assigned programmatically. 2020-07-18 07:49:27 +01:00
ColorsHelper.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
ColorsHelper.Designer.cs
ColorsHelper.ja.resx L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
ColorsHelper.resx
ColorsHelper.zh-CN.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
ConnectionWrapperWithMoreStuff.cs CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
ConsolePanel.cs Modifications around VncView disposal: 2022-04-21 11:28:18 +01:00
ConsolePanel.Designer.cs Fixed issue where the error message was not displayed if connection to the host console was not possible. 2016-07-03 17:45:49 +01:00
ConsolePanel.ja.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
ConsolePanel.resx Fixed issue where the error message was not displayed if connection to the host console was not possible. 2016-07-03 17:45:49 +01:00
ConsolePanel.zh-CN.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
CustomTreeNode.cs CP-36392: Removed unnecessary statement: 2022-04-06 13:11:35 +01:00
CustomTreeView.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
CustomTreeView.Designer.cs
CustomTreeView.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
CustomTreeView.resx
CustomTreeView.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DataGridViewDropDownSplitButtonCell.cs CP-20425: Use static images everywhere an image is assigned programmatically. 2020-07-18 07:49:27 +01:00
DataGridViewEnableableComboBoxCell.cs Fixed issue whereby VS kept toggling between SubType Component and User Control 2018-11-09 16:23:29 +00:00
DataGridViewTextAndImageCell.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
DateTimeMinutes15.cs CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358) 2019-03-15 14:10:42 +00:00
DecentGroupBox.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
DeprecationBanner.cs Use the DEPRECATION_URL as the default value for the Details link of the DeprecationBanner 2021-09-23 10:44:43 +01:00
DeprecationBanner.Designer.cs Use the DEPRECATION_URL as the default value for the Details link of the DeprecationBanner 2021-09-23 10:44:43 +01:00
DeprecationBanner.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DeprecationBanner.resx
DeprecationBanner.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DiskSpinner.cs CA-339384: Take account of thin provisioning when placing a disk on a target SR. 2020-11-18 09:24:45 +00:00
DiskSpinner.Designer.cs CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage. 2019-10-14 09:24:36 +01:00
DiskSpinner.ja.resx CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage. 2019-10-14 09:24:36 +01:00
DiskSpinner.resx Corrected message and tab indices. 2019-10-14 09:24:36 +01:00
DiskSpinner.zh-CN.resx CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage. 2019-10-14 09:24:36 +01:00
DoubleBufferedListView.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
DoubleBufferedPanel.cs Fixed issue whereby VS kept toggling between SubType Component and User Control 2018-11-09 16:23:29 +00:00
DoubleBufferedPanel.Designer.cs
DropDownButton.cs CP-20425: Use static images everywhere an image is assigned programmatically. 2020-07-18 07:49:27 +01:00
DropDownButton.Designer.cs
DropDownButton.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DropDownButton.resx
DropDownButton.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
EmptyPanel.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
EmptyPanel.Designer.cs
FilterDatesToolStripDropDownButton.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
FilterLocationToolStripDropDownButton.cs CP-36392: Address logic issue in FilterLocationToolStripDropDownButton.cs 2021-11-15 09:43:50 +00:00
FilterSeveritiesToolStripDropDownButton.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
FilterStatusToolStripDropDownButton.cs Corrections and enhancements. (#2496) 2019-08-28 14:57:36 +01:00
FlickerFreeListBox.cs CA-359969: Do not rebuild the list if the scanning of the SRs has not finished yet. Removed unused code. 2021-11-02 16:53:48 +00:00
FlickerFreePanel.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
FlickerFreePanel.Designer.cs
GradientPanel.cs Removed colour settings for unsupported windows versions. 2021-05-18 11:12:11 +01:00
HaNtolControl.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
HaNtolIndicator.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
HaNtolIndicator.Designer.cs CA-294292: Layout modifications to fix error message truncation issues. 2018-09-27 12:43:04 +01:00
HaNtolIndicator.ja.resx L10N: Translation updates along with Interface resync 2018-09-28 14:00:14 +01:00
HaNtolIndicator.resx CA-294292: Layout modifications to fix error message truncation issues. 2018-09-27 12:43:04 +01:00
HaNtolIndicator.zh-CN.resx L10N: Translation updates along with Interface resync 2018-09-28 14:00:14 +01:00
HaNtolIndicatorSimple.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
HaNtolIndicatorSimple.Designer.cs
HaNtolIndicatorSimple.ja.resx L10N : Resx resync and Translation Updates 2022-01-05 11:38:40 +00:00
HaNtolIndicatorSimple.resx CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders. 2021-03-31 11:50:32 +01:00
HaNtolIndicatorSimple.zh-CN.resx L10N : Resx resync and Translation Updates 2022-01-05 11:38:40 +00:00
HelpButton.cs CP-20425: Use static images everywhere an image is assigned programmatically. 2020-07-18 07:49:27 +01:00
HelpButton.Designer.cs
HelpButton.ja.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
HelpButton.resx
HelpButton.zh-CN.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
ListViewColumnSorter.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
ListViewEx.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
LunPerVdiPicker.cs CP-36392: Amend calls that generate unused return values 2021-10-04 15:42:40 +01:00
LunPerVdiPicker.Designer.cs
LunPerVdiPicker.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
LunPerVdiPicker.resx
LunPerVdiPicker.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
MenuStripEx.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
MultipleDvdIsoList.cs CP-36392: Remove duplicate field in MultipleDvdIsoList.cs 2021-09-20 09:35:19 +01:00
MultipleDvdIsoList.Designer.cs Fixes to the OO design of ISODropDownBox and CHChanger classes. Register template events on the Page_InstalaltionMedia. 2021-05-21 00:39:03 +01:00
MultipleDvdIsoList.ja.resx L10N : CA-207272 truncation issue fix 2019-07-23 11:27:21 +01:00
MultipleDvdIsoList.resx Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the 2016-07-06 08:55:28 +01:00
MultipleDvdIsoList.zh-CN.resx L10N : CA-207272 truncation issue fix 2019-07-23 11:27:21 +01:00
NativeConstants.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
NonReopeningContextMenuStrip.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
PanelNoFocusScroll.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
PanelWithBorder.cs Removed colour settings for unsupported windows versions. 2021-05-18 11:12:11 +01:00
PDSection.cs Merge remote-tracking branch 'upstream/master' into feature/REQ-403 2021-09-01 14:43:23 +01:00
PDSection.Designer.cs General TabPage layout modifications (includes CA-164372). (#2439) 2019-05-21 11:58:26 +01:00
PDSection.ja.resx L10N : translation update and Resx resync 2019-05-28 21:53:56 +01:00
PDSection.resx General TabPage layout modifications (includes CA-164372). (#2439) 2019-05-21 11:58:26 +01:00
PDSection.zh-CN.resx L10N : translation update and Resx resync 2019-05-28 21:53:56 +01:00
PoolHostPicker.cs CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
PoolHostPicker.Designer.cs CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
PoolHostPicker.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
PoolHostPicker.resx
PoolHostPicker.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
PvsCacheStorageRow.cs Further corrections to the DiskSpinner's rounding behaviour. 2019-10-14 09:24:36 +01:00
PvsCacheStorageRow.Designer.cs CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use 2016-12-13 11:09:23 +00:00
PvsCacheStorageRow.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
PvsCacheStorageRow.resx CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use 2016-12-13 11:09:23 +00:00
PvsCacheStorageRow.zh-CN.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SectionHeaderLabel.cs CP-36392: Cast operands of divisions to not lose precision 2021-10-04 16:22:29 +01:00
SectionHeaderLabel.Designer.cs
ShadowPanel.cs CP-20425: Use static images everywhere an image is assigned programmatically. 2020-07-18 07:49:27 +01:00
ShadowPanel.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
ShadowPanel.resx
ShadowPanel.zh-CN.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SimpleProgressBar.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
SimpleProgressBar.Designer.cs
SmartScrollTextBox.cs CA-293683: Prevent automatic scrolling when setting text in SmartScrollTextBox 2022-05-16 15:33:52 +01:00
SnapshotTreeView.cs CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
SnapshotTreeView.designer.cs
SnapshotTreeView.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SnapshotTreeView.resx
SnapshotTreeView.zh-CN.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SpinnerIcon.cs Various fixes on the EvacuateHostDialog (includes CA-292642, CA-284126, CP-34862). 2020-10-06 11:27:32 +01:00
SRListBox.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
SrPicker.cs CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028) 2022-10-11 09:26:54 +01:00
SrPickerItem.cs CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028) 2022-10-11 09:26:54 +01:00
ToolStripEx.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
ToolTipContainer.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
ToolTipContainer.Designer.cs
ToolTipContainer.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
ToolTipContainer.resx
ToolTipContainer.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
TransparentPanel.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
TransparentTrackBar.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
TransparentTrackBar.Designer.cs
TransparentTrackBar.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
TransparentTrackBar.resx
TransparentTrackBar.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
UpsellPage.cs CA-349435 - Fixed tooltip display on Options and Properties dialogs (#2841) 2021-08-23 10:34:46 +01:00
UpsellPage.Designer.cs CP-15401: Move hidden check out of designer 2016-01-22 17:02:59 +08:00
UpsellPage.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
UpsellPage.resx
UpsellPage.zh-CN.resx L10N : Translation Update and Resync 2019-11-11 15:23:40 +00:00
VerticalTabs.cs CP-36392: Use value in empty setters 2022-02-24 11:53:44 +00:00
VisualMenuItem.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
XenTabControl.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
XenTabControl.Designer.cs
XenTabControl.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
XenTabControl.resx
XenTabControl.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
XenTabPage.cs Typos. 2021-09-07 11:12:56 +01:00
XenTabPage.Designer.cs
XenTabPage.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
XenTabPage.resx
XenTabPage.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30