7469 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Aliaksandr Valialkin	f673039e86	lib/storage: follow-up for 4b8088e377 ... - Clarify the bugfix description at docs/CHANGELOG.md - Simplify the code by accessing prefetchedMetricIDs struct under the lock instead of using lockless access to immutable struct. This shouldn't worsen code scalability too much on busy systems with many CPU cores, since the code executed under the lock is quite small and fast. This allows removing cloning of prefetchedMetricIDs struct every time new metric names are pre-fetched. This should reduce load on Go GC, since the cloning of uin64set.Set struct allocates many new objects.	2024-01-16 22:38:57 +02:00
Aliaksandr Valialkin	84f11a9e6d	app/vmselect/promql: simplify the code after 388d020b7c ... Add a test, which verifies the correct sorting of float64 slices with NaNs. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5506 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509	2024-01-16 22:35:51 +02:00
Hui Wang	2f40ed3aac	exit vmagent if there is config syntax error in scrape_config_files when -promscrape.config.strictParse=true (#5560)	2024-01-16 22:35:18 +02:00
hagen1778	343176438e	deployment/alerts: add job label to DiskRunsOutOfSpace alerting rule ... So it is easier to understand to which installation the triggered instance belongs. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 22:21:34 +02:00
Aliaksandr Valialkin	6ba2fd3312	app/vmselect/promql: follow-up for ce4f26db02 ... - Document the bugfix at docs/CHANGELOG.md - Filter out NaN values before sorting as suggested at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509#discussion_r1447369218 - Revert unrelated changes in lib/filestream and lib/fs - Use simpler test at app/vmselect/promql/exec_test.go Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5506	2024-01-16 22:13:13 +02:00
Zongyang	cb37df5723	FIX bottomk doesn't return any data when there are no time range overlap between timeseries (#5509) ... * FIX sort order in bottomk * Add lessWithNaNsReversed for bottomk * Add ut for TopK * Move lt from loop * FIX lint * FIX lint * FIX lint * Mod log format --------- Co-authored-by: xiaozongyang <xiaozngyang@kanyun.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2024-01-16 22:12:49 +02:00
Aliaksandr Valialkin	015c0a4d1a	app/vmselect/promql: consistently sort results of a or b query ... Previously the order of results returned from `a or b` query could change with each request because the sorting for such query has been disabled in order to satisfy https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4763 . This commit executes `a or b` query as `sortByMetricName(a) or sortByMetricName(b)`. This makes the order of returned time series consistent across requests, while maintaining the requirement from https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4763 , e.g. `b` results are consistently put after `a` results. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5393	2024-01-16 22:12:15 +02:00
Aliaksandr Valialkin	825cfdb5ef	app/vmstorage: expose proper types for storage metrics when -metrics.exposeMetadata command-line flag is set ... This is a follow-up for 326a77c697	2024-01-16 22:03:31 +02:00
Aliaksandr Valialkin	724223fad4	lib/prompbmarshal: move WriteRequest proto definition to the correct place	2024-01-16 21:57:03 +02:00
Artem Navoiev	55a03ff454	docs: vmanomaly fix image size ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:56:25 +02:00
Artem Navoiev	83287bde1c	vmanomly: guide add diagramm ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:55:59 +02:00
Artem Navoiev	f3364bbd8b	docs: vmanomaly fix formatting and remove unnecessary elements ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:55:42 +02:00
Artem Navoiev	6370ae2d88	vmanomaly - models a bit pretify docs (#5618) ... * vmanomaly - models a bit pretify docs Signed-off-by: Artem Navoiev <tenmozes@gmail.com> * typi Signed-off-by: Artem Navoiev <tenmozes@gmail.com> * fix formatting Signed-off-by: Artem Navoiev <tenmozes@gmail.com> --------- Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:54:33 +02:00
Artem Navoiev	a90c9bf8c9	vmanomaly guides - fix formating, add missing piece, clarify statement, use common languagefor VM ecosystem (#5620) ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:53:59 +02:00
Artem Navoiev	44ff8b3647	clarify cluster multitenacy in vmanomaly docs (#5619) ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:53:30 +02:00
Artem Navoiev	f032f4347e	docs: fix markdown in how-to-monitor-k8s ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 21:52:59 +02:00
Aliaksandr Valialkin	0196902b2e	lib/promscrape/discovery/hetzner: fix golangci-lint warnings after 03a97dc678 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5550	2024-01-16 21:51:48 +02:00
Roman Khavronenko	c69d5041bb	docs: mention requirements for latest backups (#5614) ... Add docs to explain that `latest` backup folder can be accessed more frequently than others. Hence, it is recommended to keep it on storages with low access price. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 21:28:27 +02:00
Aliaksandr Valialkin	9b449dfadf	app/vmstorage: deregister storage metrics before stopping the storage ... This prevents from possible nil pointer dereference issues when the storage metrics are read after the storage is stopped. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548	2024-01-16 21:26:03 +02:00
Aliaksandr Valialkin	9e5e514faf	lib/pushmetrics: wait until the background goroutines, which push metrics, are stopped at pushmetrics.Stop() ... Previously the was a race condition when the background goroutine still could try collecting metrics from already stopped resources after returning from pushmetrics.Stop(). Now the pushmetrics.Stop() waits until the background goroutine is stopped before returning. This is a follow-up for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5549 and the commit fe2d9f6646 . Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548	2024-01-16 21:18:22 +02:00
Aliaksandr Valialkin	fce76b2fb0	vendor/github.com/VictoriaMetrics/easyproto: update from v0.1.3 to v0.1.4 ... This fixes vet error for 32-bit architectures: https://github.com/VictoriaMetrics/VictoriaMetrics/actions/runs/7521709384/job/20472882877	2024-01-16 21:14:03 +02:00
Aleksandr Stepanov	3a6e3adc7d	vmagent: added hetzner sd config (#5550) ... * added hetzner robot and hetzner cloud sd configs * remove gettoken fun and update docs * Updated CHANGELOG and vmagent docs * Updated CHANGELOG and vmagent docs --------- Co-authored-by: Nikolay <nik@victoriametrics.com>	2024-01-16 21:13:20 +02:00
Roman Khavronenko	d562d772a8	lib/storage: properly check for storage/prefetchedMetricIDs cache expiration deadline (#5607) ... Before, this cache was limited only by size. Cache invalidation by time happens with jitter to prevent thundering herd problem. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 21:08:59 +02:00
rbizos	62db64e71b	Handling negative index in Graphite groupByNode/aliasByNode (#5581) ... Handeling the error case with -1 Signed-off-by: Raphael Bizos <r.bizos@criteo.com> Co-authored-by: Nikolay <nik@victoriametrics.com>	2024-01-16 20:55:27 +02:00
Aliaksandr Valialkin	d566aa7d78	lib/prompbmarshal: switch to github.com/VictoriaMetrics/easyproto	2024-01-16 20:48:30 +02:00
Aliaksandr Valialkin	063ea8c773	app/vmalert/remotewrite: properly calculate vmalert_remotewrite_dropped_rows_total ... It was calculating the number of dropped time series instead of the number of dropped samples. While at it, drop vmalert_remotewrite_dropped_bytes_total metric, since it was inconsistently calculated - at one place it was calculating raw protobuf-encoded sample sizes, while at another place it was calculating the size of snappy-compressed prompbmarshal.WriteRequest protobuf message. Additionally, this metric has zero practical sense, so just drop it in order to reduce the level of confusion.	2024-01-16 20:47:13 +02:00
Aliaksandr Valialkin	f7b589e38a	lib/prompb: switch to github.com/VictoriaMetrics/easyproto	2024-01-16 20:43:09 +02:00
Aliaksandr Valialkin	7d40506744	lib/prompb: change type of Label.Name and Label.Value from []byte to string ... This makes it more consistent with lib/prompbmarshal.Label	2024-01-16 20:41:37 +02:00
Aliaksandr Valialkin	8cb138e8df	lib/protoparser/datadogv2: simplify code for parsing protobuf messages after 0597718435 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5094 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4451	2024-01-16 20:35:17 +02:00
Aliaksandr Valialkin	f8ae2abd88	lib/protoparser/opentelemetry: use github.com/VictoriaMetrics/easyproto for protobuf message unmarshaling and marshaling ... This reduces VictoriaMetrics binary size by 100KB. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2570 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2424	2024-01-16 20:34:18 +02:00
Aliaksandr Valialkin	9eef72bce9	lib/protoparser/datadogv2: add support for reading protobuf-encoded requests at /api/v2/series endpoint ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4451 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5094	2024-01-16 20:32:15 +02:00
Dmytro Kozlov	b95d6f5f5e	app/vmctl: add insecure skip verify flags for source and destination addresses for native protocol (#5606) ... https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5595	2024-01-16 20:29:41 +02:00
Zakhar Bessarab	178d64cc51	docs: explicitly mention "delete_series" endpoint accepts any HTTP method (#5605) ... See: #5552 Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>	2024-01-16 20:14:04 +02:00
hagen1778	af47f96177	docs: make docs-sync ... Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 20:12:47 +02:00
Artem Navoiev	e1005209ba	docs: mention staleNaN handling during deduplication ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5587 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 20:11:45 +02:00
Dan Dascalescu	59ab3efc2b	docs: fix English in keyConcepts.md, add instant query use case (#5547)	2024-01-16 19:54:09 +02:00
Fred Navruzov	2b372de326	docs: vmanomaly chapter hotfixes (#5583) ... * update link to book a demo for AD & RCA * fix invalid refs in components/model * - fix staging -> prod links - replace capitalized FAQ headers - change the section order on main page - replace :latest tag with current stable	2024-01-16 19:53:25 +02:00
Fred Navruzov	99c545bff8	- fix 404 in /guides page (#5582) ... - change back AD section title	2024-01-16 19:50:01 +02:00
Artem Navoiev	821ac6e374	docs: properly close diff ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 19:48:36 +02:00
Denys Holius	74c99549d6	docs/anomaly-detection/guides/README.md: fixed markdown link to the vmanomaly guide (#5578)	2024-01-16 19:12:50 +02:00
Artem Navoiev	54723fc94e	docs: vmanomaly add list of guides to guides page ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 19:12:04 +02:00
Artem Navoiev	77570d83ee	docs: change sorting of anomaly deteciton ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 19:10:56 +02:00
Fred Navruzov	2b404742e2	docs: vmanomaly part 1 (#5558) ... * add `AD` section, fix links, release docs and changelog * - connect sections, refactor structure * - resolve suggestions - add FAQ section - fix dead links * - fix incorrect render of tables for Writer - comment out internal readers/writers - fix page ordering to some extent * - link licensing requirements from v1.5.0 to main page --------- Co-authored-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 19:09:37 +02:00
Denys Holius	c9b7452a86	CHANGELOG.md: fixed wrong links to vmalert-tool documentation page (#5570)	2024-01-16 19:07:35 +02:00
Artem Navoiev	9152f91f49	docs: specify right link to grafana operator docs ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 17:45:21 +02:00
hagen1778	bcc3c9c12e	docs: fix typo in VictoriaLogs upgrading procedure ... Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 17:43:59 +02:00
hagen1778	583bbed48e	docs: docs-sync after 52692d001a ... Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 17:42:48 +02:00
hagen1778	14b9f7d71f	docs: add link to sandbox to the Grafana section ... Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 17:36:11 +02:00
Aliaksandr Valialkin	0114ade5eb	docs/keyConcepts.md: clarify which values can be stored in VictoriaMetrics without precision loss ... This is a follow-up for 43d7de4afe Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5485 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5503	2024-01-16 15:50:28 +02:00
hagen1778	f301dc5cfb	lib/uint64: remove accidentally added test ... Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-09 13:32:22 +01:00