If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
Do not leave out bytes if the number read is odd, which can happen if the file is smaller than the buffer used.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Compacted code deciding whether to show an SR on the picker.
- Removed code sorting the disabled SRs because it repeats partially the
SR checks without reflecting exactly the disabled reason and probably
causes confusion when compared with the main treeview.
- Renamed property.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, compacted the code parsing command line parameters; removed class
and cli option MessageBoxTest as it adds to code complexity, plus that
the application is not meant to be used as testing infrastructure.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, corrected the RBAC permission check after stopping using the conversion plugin.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The Approaching EOL alert will be shown when the EOL date is known, but the hotfix-eligibility flag is not yet set to "none".
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
Also, minor layout correction, and usability enhancement: do not disable
the controls under the radio button when the latter is deselected.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
