Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-20 15:29:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,486 Commits 12 Branches 48 Tags 186 MiB
7144528f6b
Commit Graph

2560 Commits

Author SHA1 Message Date
Konstantina Chremmou
7018c866c5 CP-36125: Extended interface for inspection of certificates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-23 15:29:53 +01:00
Konstantina Chremmou
f2eb3fa973 CP-35632: Support for new alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-23 15:29:53 +01:00
Konstantina Chremmou
f4e17109c8 CP-36124: Check and enable TLS verification on first connection. Also, PascalCased some methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-23 15:29:53 +01:00
Konstantina Chremmou
a3b4ad0de6 Temporary hack to fix the SDK. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-23 15:29:53 +01:00
Konstantina Chremmou
eb85c8113a Updated C# SDK (xapi 1.303.0-1.xs8) 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-23 15:29:53 +01:00
Konstantina Chremmou
92cf9572bc CA-355655: Throttle the number of parallel downloads of server status report data in a pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-23 15:25:24 +01:00
Konstantina Chremmou
f63003fb27 CA-353748 second issue: At the end of polling, the RelatedTask is destroyed; make a note of it for later use 
Also: make a get_record where more than one object fields need to be queried.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-17 09:11:39 +01:00
Konstantina Chremmou
1df1083a2d Use more generic names for client version updates, checks, alerts etc. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-09 15:52:10 +01:00
Konstantina Chremmou
dce5a0d1c1 CA-355163: Check the client branding matches the new client version alert. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-09 15:52:10 +01:00
Konstantina Chremmou
3251ddf495 CA-355018: Ensure disabled health check status is reflected in the cache before re-rerunning prechecks. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-08 15:57:08 +01:00
Konstantina Chremmou
36beaa5180 CA-355166: Updated help links. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-06-08 15:56:29 +01:00
Konstantina Chremmou
2defc1dbff Fixed workflow when loading the WorkloadReports dialog (includes CA-339666). 
- Fixed exception handling in RetrieveWlbConfiguration action (exceptions of type
  other than Failure were silenced).
- CA-339666: Fixed control flickering when showing the WorkloadReports dialog.
- Retrieve the WlbConfiguration before attempting populating the controls.
- If the dialog was launched requesting a certian report to be run, the report
  was not selected on the list.
- Some refactoring to simplify the code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-27 15:39:52 +01:00
Konstantina Chremmou
393e041c4f Removed commented out and dead code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-27 11:30:58 +01:00
Konstantina Chremmou
3082745c85 Tidied up WLB report files: 
- Moved the business logic classes to XenModel close to their base class.
- Moved WorkloadReports dialog close to the other WLB dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-26 17:54:53 +01:00
Konstantina Chremmou
33295bfc1b CA-354879, CA-354877: Branding and version corrections. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-26 00:37:25 +01:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2021-05-25 15:51:42 +01:00
Konstantina Chremmou
5676334c8d CP-36917: Updated server version. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-24 09:56:20 +01:00
Joey
a56a383ec0
CP-35687: Detach update mechanism from update wizard (#2812) 
* CP-35687: Detach update mechanism from update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-35687 part 2: Removed updates mechanism.
* Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-21 15:13:45 +01:00
Konstantina Chremmou
d21f6dda5a CA-340735: Re-write to fix workflow issues and simplify the code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-21 00:39:03 +01:00
Konstantina Chremmou
858ab54950 CA-353748: VM imported as an XVA won't start automatically. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-17 14:46:57 +01:00
Konstantina Chremmou
e3e73c8a0a
Merge pull request #2807 from xenserver/feature/legacy-partition 
Merge feature/legacy-partition to master
 2021-05-04 13:06:16 +01:00
Konstantina Chremmou
b116c4713d CA-353524: Full copy of VM on the same SR is allowed. 
Moving and copying a VM should be treated differently, hence we need a different
SrPickerItem subclass for each operation. Minor logic simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-05-04 13:05:27 +01:00
Konstantina Chremmou
ca8e53e0ba CA-294901: Improved message on the CrossPoolMigrateWizard. 
Also, NoTargetServerPoolItem class should be private to the SelectMultipleVMDestinationPage
because it is not used anywhere else.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-28 11:28:28 +01:00
Konstantina Chremmou
735896fdca CA-340976: Corrected disabled reason for IP address configuration button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-27 00:18:47 +01:00
Mihaela Stoica
a75e8fca4f
Merge branch 'master' into feature/legacy-partition 2021-04-23 14:37:05 +01:00
Darren Matthews
7e39749091 L10N : Translation Updates 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2021-04-20 12:34:17 +01:00
Konstantina Chremmou
3f4737c57a Upgraded log4net to 2.0.12. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-09 09:16:01 +01:00
Konstantina Chremmou
6d8ad062f8 CA-353070: Corrected wizard title. Fixed navigation with the Tab key. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-08 17:28:48 +01:00
Konstantina Chremmou
5a91f615b2 Added null checks where missing and reduced use of try-catch blocks in favour of TryParse() methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-07 10:04:47 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-07 10:04:47 +01:00
Konstantina Chremmou
e5bee7be6a Added Events in progress to the outlook-style status labels of the main window. 
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-07 10:04:30 +01:00
Konstantina Chremmou
7985befde6 CA-352946: Account for the cases when the task result is not xml. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-01 11:30:54 +01:00
Konstantina Chremmou
35e1d68afa CA-352901: Fixed window title and translations for window title and menu item. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-01 11:30:54 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-31 11:50:32 +01:00
Konstantina Chremmou
c4b076bd97 Removed unused code alongside strings in need of branding. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-31 11:50:32 +01:00
Ji Jiang
c1ec145cf7 Fix some messages 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-22 23:32:09 +00:00
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-17 15:30:59 +00:00
Ji Jiang
96c3d5e1c0 CP-35345: Add pre-cloud connection warning 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-17 10:32:17 +00:00
Konstantina Chremmou
f05b16eff7 Do not use the task description as the AsyncAction description because in most cases it is not localised. 
Also, do not poll if the RelatedTask is null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-16 10:27:55 +00:00
Konstantina Chremmou
47d9146ce3 CA-352455: Parse the task result as xml document instead of using a regex. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-16 10:27:55 +00:00
Edwin Török
eaf6bb7507 Update DEFAULT_NUM_VBDS_ALLOWED to 255 
All currently supported versions of the product support 255 VBDs,
see https://docs.citrix.com/en-us/xenserver/7-0/downloads/config-limits.pdf

When a VM is imported through XCM it may not have recommendations,
and XenCenter falls back to the default, which is 16.
Then adding another disk shows an error that the maximum number of disks was reached,
which contradicts our support statement of 255 disks.

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
 2021-03-16 00:12:50 +00:00
Mihaela Stoica
c6710b7ffd CP-35471: Refactor HostNotSafeToUpgrade classes to avoid code repetition. 
Also:
- added count check when generating the prechecks
- message correction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-11 09:30:52 +00:00
Mihaela Stoica
9f6ce35a04 CP-35471: Change the SafeToUpgrade check to show a problem when upgrading to the next version 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-11 09:30:52 +00:00
Mihaela Stoica
b0dd36d1b3 Add branding and helper function for the next version 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-11 09:30:52 +00:00
Konstantina Chremmou
0c572a1d6d Normalised usage of the UpsellDialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Konstantina Chremmou
79d8b00de8 Replaced AllowUpdatesDialog with a ThreeButtonDialog. 
For reasons of code reduction and also because the look and feel of this dialog
was slightly different from the usual application pop-ups.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Konstantina Chremmou
a469dae95b Removed obsolete or unused messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Konstantina Chremmou
40440f5f98 Moved several more brand related and untranslatable strings to Branding.resx. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Konstantina Chremmou
51dedff3c4 Rebrand Branding.resx instead of the BrandManager.cs. Sorted variables alphabetically and removed unused variable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Ji Jiang
7b63b58622 Disallow CHC connection with Havana 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-03 13:49:45 +00:00
Konstantina Chremmou
6e5cb325f3 CP-35899, CP-36202: Show the driver domain console tab on the corresponding SR. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-02 11:57:50 +00:00
Konstantina Chremmou
29f3f9cd33 CP-35898: Do not show SMAPIv3 SRs as of unknown type if the type can be inferred from the SM plugin. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-02 11:57:50 +00:00
Konstantina Chremmou
a109f5f22d Pascal-cased method name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-02 11:57:50 +00:00
Joey
5a29a8fd9b
CP-35838: Add health check precheck into RPU wizard (#2778) 
* CP-35838: Add health check precheck into RPU wizard
* CP-35838: Add disable Health Check in RPU precheck warning

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-02 09:53:21 +00:00
Darren Matthews
a8988276be L10n : Resx resync and translation update 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2021-03-02 09:44:29 +00:00
Konstantina Chremmou
5e76a3cae8 CA-352022: Fixed broken retrieval of polling result. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-18 10:33:18 +00:00
Konstantina Chremmou
11ce488062 Merge branch 'master' into feature/hyperman 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Jenkinsfile
#	scripts/xenadmin-build.sh
 2021-02-17 14:51:13 +00:00
Ji Jiang
7b362e5cd6 CP-35479: Allow connection to certain product versions 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-02-11 13:35:43 +00:00
Konstantina Chremmou
eb3662aa88 CA-345342: Cope with optional parameters in the HTTP_actions. 
- Removed wrapper delegates; call the http_actions directly.
- In case of failure or cancellation of the http_action, poll the related task
  ignoring any exceptions thrown, so that any clean up code within the http_action's exception handling can run.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
bc92cf793d Removed class TaskPoller and moved its code to AsyncAction. 
This simplifies the code since the TaskPoller cannot be perceived without an AsyncAction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
145483b193 Minor corrections on Task extensions: 
- Stop rethrowing exceptions.
- Added some checks.
- Renamed method XenCenterUUID to GetXenCenterUUID to match the methods
  SetXenCenterUUID and RemoveXenCenterUUID.
- Replaced check via static string list with a string switch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
b0eafcf1d1 Code design issue: do not override DestroyTask. Minor refactoring in VMSnapshotCreateAction. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed. 
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Konstantina Chremmou
75f9127e27 Move files to a better location. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-19 10:37:35 +00:00
Konstantina Chremmou
be010e1c39 CA-350406: Exclude the Tools SR when plugging PBDs after a host reboot during an update process. 
Also, try plugging PBDs only for the host in question (other hosts are not necessary,
as the PBDs are re-checked for any previously evacuated VMs before repatriation).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-12 12:15:12 +00:00
Konstantina Chremmou
9a5c664eb0 CA-350574: Corrections to signing an appliance. 
Also, removed listing of CryptoServiceProviders from the settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-12 12:14:31 +00:00
Konstantina Chremmou
501cca2ffb CA-350410: Ensure we set the certificate before checking it's null. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-04 16:23:11 +00:00
Konstantina Chremmou
33e668c0c4 Removed obsolete class XSVersionAttribute. Some refactoring of the usage of Program.Version. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-24 01:23:47 +00:00
Konstantina Chremmou
542a329a27 Fixed failure to start a VM after it was imported as an XVA package. 
Regression introduced by the changes for CA-64500. Since we initiate a VMStartAction
we need to ensure that the VM object passed to the action has a non-null Connection.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file. 
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
e325548a75 CA-349836: Reworked handling of manifest and signature for appliance import/export. 
- Moved the code to the ExportApplianceAction so it's easier to modify the
  action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
  OVF package was ignored.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
8d004401fb CA-343280: Removed metadata entry. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
6286f96cb1 CA-343280: Extended proxy authentication. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
3e0d982631 CA-347849: No need to keep track of the VIF.device numbers across all VMs of the imported appliance. 
Reset to 0 for each VM.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:00 +00:00
Konstantina Chremmou
84d0a2b8ae Bad application of the code reusability principle in VMDestroyAction. 
Destroying a VM does not disrupt the connection, hence the use of the BestEffort
method is not warranted. After this correction, BestEffort is only used in the
DestroyedBondAction, hence I removed it completely and replaced it with simpler
exception handling in the latter class's Run method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-03 14:56:11 +00:00
Konstantina Chremmou
94024f99a9 CA-347481: Clean up the disks of the destroyed VM if import is interrupted due to cancellation or failure. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-03 14:55:38 +00:00
Konstantina Chremmou
2469c947c9 Increased precision in displaying progress of transferred disk data. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 12:07:13 +00:00
Konstantina Chremmou
719d6b5e45 CA-347487: Fixed error formatting. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 12:07:13 +00:00
Konstantina Chremmou
07ae413e15 CA-349194: Prevent crash when initialising a disk image import. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 11:03:49 +00:00
Konstantina Chremmou
d7512d14c7 CA-347479: Added more cancellation points. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 11:03:49 +00:00
Konstantina Chremmou
60fb141e57 CA-339384: Take account of thin provisioning when placing a disk on a target SR. 
Also, set the required disk size to zero when the disk spinner value is invalid.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-18 09:24:45 +00:00
Konstantina Chremmou
80119e9411 CP-15790: Implementation improvement aimed to make manual testing easier. 
- Ensure we read the updates.xml location anew from the registry, otherwise the
application has to be relaunched to pick a registry change. Look in both hives
HKCU and HKLM. To avoid performance impact on the UI, move the operation into
the action's Run() body.
- Some refactoring to improve OOP design and fix XmlReader leak.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-12 11:04:33 +00:00
Konstantina Chremmou
0b0819b0aa Moved files to a better location. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-12 11:04:33 +00:00
Konstantina Chremmou
c1375c51ed CA-347407: Handle exceptions when failing to unprotect saved proxy credentials. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
fbb25c7970 Minor modifications to task polling: 
- Consolidated Action.PollToCompletion overloads, among others, to reduce precision loss.
- Logging the environment's stack trace is not very useful in the case of an API failure.
- Log the task's opaque_ref so it's easier to trace errors in the server side logs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 15:02:31 +01:00
Konstantina Chremmou
e895bc4168 CA-339353: SrProbeAction should run its RBAC checks explicitly instead of inheriting from PureAsyncAction. 
The fix for CA-337280 moved the parsing of the probe result in the Run body of
the action, causing it to fail when the dry-run for the RBAC checks is performed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 15:02:31 +01:00
Konstantina Chremmou
4f564979e1 CA-345349: Verify the exported disk using DiscUtils and fail the whole export if one disk export failure occurs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
d23c40c543 CA-324350: When the OVF files are compressed, create manifest and signature on the final package after the compression. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
f24a81bd28 CA-89896: Enabled cancellation during OVA packaging/extraction and file compression/decompression. 
Also removed some more unused methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
38c88b5692 CA-64500: Offer the option to start the vApp or VM automatically after an OVF/OVA import. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
54e8347a5c CP-34826: Upgraded DiscUtils to version 0.11. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Darren Matthews
a9016bc14e L10N : Translation Update and RESX resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-10-13 13:56:55 +01:00
Konstantina Chremmou
1e6197022e
CA-339233: Do not allow selection of networks while they're locked. (#2733) 
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
  private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:34:03 +01:00
Konstantina Chremmou
6f44821e40 Import refactoring 4: Simplifications and corrections, including: 
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
42b06251bc Export refactoring 4: Some improvements to progress reporting (CA-65894). Added some logging. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
23892df15d Moved the OVF actions to XenModel and removed what was left from XenOvfTransport. 
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
317f66758d Removed Settings file. It is not meant for storing constants and most entries were obsolete anyway. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
18c407d992 Removed controls for Transfer VM configuration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
6e2c45bcd5 CP-34221: Basic implementation of export/import using the API's http actions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
bf9f5b1308 Ensure all the CommandLib classes are defined in this namespace so as to avoid conflicts with homonymous classes from other namespaces. 
- Automatic indentation fix as a consequence.
- Use proper xml doc for the various methods and classes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3d6db3a80 Removed support for long retired XVA v1 packages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
25b61ea129
CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874. (#2730) 
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.

- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
  without really offering useful information.

* Correction as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 14:51:14 +01:00
Konstantina Chremmou
d93e40065a Various fixes on the EvacuateHostDialog (includes CA-292642, CA-284126, CP-34862). 
- CP-34862: Do not allow nomination of new master if a pool secret rotation or
  other pool operations are in progress.
- CA-292642: Fixed button enablement after resolving VM problem.
- CA-284126: Added button to rescan running VMs on the server.
- Removed annoying, focus stealing, modal action progress dialog. When scanning
  for VMs show a spinner on the control instead.
- Fixed crash when the host combobox was updated due to cache changes.
- Logging in an elevated session was happening on the UI thread.
- Show the role elevation dialog before launching the host evacuation dialog or
  we end up with showing the user an unpopulated control.
- Stop deriving from animated progress dialog because it makes it difficult to
  get the resizing right when adding more controls.
- Stop using the progress bar for the VM solution actions; rely simply on the
  action's description and the VM's icon in the gridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
b34a5d54cf CP-34862: Do not allow enabling HA when a pool secret rotation is pending. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
f3da384a6a Configuring HA on the TabPage should offer the same UX as when using the Menu Items. 
- Use CommandButtons on the HA TabPage for configuring/disabling HA.
- Added menu item to disable HA.
- There is no point in hiding the buttons on the HA TabPage when the corresponding
  menu items are available. They should rather offer the same user experience.
- Added RBAC page to the HaWizard to avoid unnecessary SR scanning only to be told
  that one cannot proceed.
- Show RBAC error dialog if the user does not have permission to launch the
  EditVmPriorities dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
db7582a397 CP-34862: Do not allow enabling clustering when a pool secret rotation is pending. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
cef3acaa6e CP-34862: Updated SDK to include the latest additions for REQ-819. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
aec6b395ff CA-343956: Fixed issues on the VM storage TabPage: 
- Disabled button tooltips did not disappear when the DataGridView selection was cleared.
- The disabled Activate/Deactivate button had no tooltip for template disks.
- Minor improvement to the tooltip of the Delete button.
- The Add button was using the enablement logic of the AttachVirtualDiskCommand.
- Use CommandButtons to avoid logic duplication.
- Hide the CommandButton.Command from the designer as it's mostly assigned programmatically.
- Increased the minimum width of the non-autosizable columns so they remain visible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-02 11:59:55 +01:00
Konstantina Chremmou
c4754c0251 Removed exception that was never thrown (referring to obsolete licensing restriction). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-09-08 10:34:08 +01:00
Konstantina Chremmou
cdd650d40e Fixed 3rd party library references in the solution project files. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-09-08 10:34:08 +01:00
Darren Matthews
c75ab40ef8 L10N : Translation Updates and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-09-01 14:26:40 +01:00
Konstantina Chremmou
822394597f Corrected button text. Fixed duplicate hotkey in the host right click menu. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-24 16:49:23 +01:00
Konstantina Chremmou
e3896239df CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues: 
- Use a plain list to store update alerts and, where possible, fire a collection
  change event only after a bulk change and not every time a single object is added
  or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
  pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-21 16:08:20 +01:00
Konstantina Chremmou
f05b512ca4 Tidy up event registration and deregistration on the MainWindow. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-21 16:08:20 +01:00
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
 2020-08-11 13:35:39 +01:00
Konstantina Chremmou
c244d8d4db CA-339584: Include CD VDI in the storage mapping for intra-pool migration 
Also: removed unused method; some property modernisation; removed class
LiveMigrateOptionsVmMapping which was rather complicating things.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-11 08:46:42 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701) 
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 11:29:01 +01:00
Konstantina Chremmou
ca3e9c0219 Removed unused SaveSessionCommand and consequently refactored SaveAndRestoreDialog constructor. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 11:27:29 +01:00
Konstantina Chremmou
8fb44a55cb Added flag VM.VirtualisationStatus.NOT_INSTALLED to replace value 0 for clarity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 10:42:20 +01:00
Konstantina Chremmou
2755f71dcf CA-341423: Added a new filter value for VMs with only the management agent installed so they can be easier to find. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 10:42:20 +01:00
Konstantina Chremmou
e30ea433c7 Refactoring to simplify the code and make calculations more efficient: 
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 10:42:20 +01:00
Konstantina Chremmou
5526a3f7d1 CP-34045: Removed max resolution and max displays columns. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-28 10:01:09 +01:00
Aaron Robson
05c8809539 CP-34000: decimal network and disk access rate unit calculations 
Though this was shown in units like kB/s and MB/s (decimal units) it was calculated in
binary terms i.e. 1MB/s was treated as 1024kB/s instead of the expected 1000kB/s.

Updated translations for the units to be of the form 'MB/s' instead of 'MBps'.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
 2020-07-18 07:55:34 +01:00
Konstantina Chremmou
d08f02cce2 CP-20425: Added test to ensure all Resource images have a static counterpart. 
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
9d7cf72c78 CP-33781: Added admin exit procedure warnings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-17 16:04:10 +01:00
Konstantina Chremmou
5c1a982659 CP-33771: Added an item to the pool menu for triggering a secret rotation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-17 16:04:10 +01:00
Konstantina Chremmou
a2596ec201
Merge pull request #2711 from xenserver/dotnet48 
Merge branch dotnet48 into master
 2020-07-07 12:10:46 +01:00
Konstantina Chremmou
6b168f0e6e CA-341778: Missing entries from distros treated as Linux. 
Also, moved the list to the VM class so it can be kept up to date when new guests are added.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-07 09:24:55 +01:00
Konstantina Chremmou
6bf1f7c23c Fixed broken tests and corrected assertion handling in the Jenkinsfile. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-02 09:27:26 +01:00
Konstantina Chremmou
0199e1e73e Latest SDK. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-29 12:41:24 +01:00
Konstantina Chremmou
f3c5e74dae CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-25 11:17:11 +01:00
Konstantina Chremmou
c14184919d Extended disk latency regex and added unit tests. 
Also made a small addition to a past test as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-23 08:51:41 +01:00
Konstantina Chremmou
db041099ef CA-339271: Improved action description. Also: 
Added cancelling ability to MoveVM action; made some simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-19 14:04:59 +01:00
Talons Lee
b09d3cb8e7 CP-33715: add gooroom os icon 
Signed-off-by: Talons Lee <xin.li@citrix.com>
 2020-06-15 22:37:50 +01:00
Konstantina Chremmou
d045d180a0
Merge pull request #2696 from xenserver/master 
Bring branch dotnet48 up to date with master
 2020-06-15 15:43:52 +01:00
Darren Matthews
00b6fdc8e3 L10N: Translation and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-06-11 13:57:12 +01:00
Konstantina Chremmou
acd3094b48 CA-314005: Proceed to setting the memory if the issued shutdown has been interrupted by a different shutdown task. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-10 23:48:54 +01:00
Konstantina Chremmou
c9449b9914 CP-33153: Added friendly title and description for GFS2_CAPACITY alert. Corrected scan action description. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:50:49 +01:00
Konstantina Chremmou
ec7fc14c18 Typo. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:48:54 +01:00
Konstantina Chremmou
797605d2e7 CA-339526: Updated API bindings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-29 14:53:54 +01:00
Konstantina Chremmou
cae3796887 CA-339526: Ignore classes that are present in the database but not exposed in the SDK. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-29 14:53:54 +01:00
Konstantina Chremmou
ffcc069aa1 CA-339526: New API bindings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-28 18:02:42 +01:00
Konstantina Chremmou
4f4217a2b1 CA-339685: Corrected calculation of completion percentage and added checks for division by zero. 
Also, some simplifications and removal of unused variables and fields.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-22 00:25:56 +01:00
Konstantina Chremmou
64aa4e730b CA-339237: Show more information in XenCenter's logs on why a patch or update may have failed to apply. 
Also, ensure the Failure.ErrorDescription property is always initialised.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-22 00:19:40 +01:00
Konstantina Chremmou
41afa2a753 CP-32921: Target .NET Framework 4.8 and build using VS2019 tools. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:10:41 +01:00
Konstantina Chremmou
166fe0ecc5 CA-333443: Use the master's address instead of the connection name when joining a pool. 
Also, moved code handling RBAC failure from the Failure class into the
PoolJoinAction because it is pretty specific to the latter action.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:03:45 +01:00
Konstantina Chremmou
d8cbf38cd8 CA-339306: Warn the user that removing a server from a pool removes also domain information. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 13:25:53 +01:00
Konstantina Chremmou
fc9d617f27 CA-338830: Pool join checks should not allow slave with enabled clustering to join. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 13:25:53 +01:00
Konstantina Chremmou
8a478011d9 CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 07:49:23 +01:00
Darren Matthews
1d74094e5a L10N : Translation and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-05-18 15:15:07 +01:00
Konstantina Chremmou
f05b502399 CA-339331: Skip uses deferred execution and needs enumeration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-15 11:38:23 +01:00
Konstantina Chremmou
bd04229d89 CA-339312: Explain why a host cannot be removed from the pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-12 15:27:12 +01:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299). 
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also: 
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
8d6686b63f CA-337280: Creation of GFS2 SRs with CHAP authentication is not supported. 
This is also a better fix for CA-335356.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard 
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
fd497a1370 Added outlook style status labels showing the number of various types of notifications. 
The labels are additionally clickable and navigate to the corresponding panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-30 08:30:30 +01:00
Konstantina Chremmou
0fa374313f Corrected dialog title. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-30 08:30:30 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
 2020-04-29 16:47:48 +01:00
Konstantina Chremmou
436ffe4a37 CA-338003: The action's Sessions is set once the action has started to run. Added missing help references. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-27 10:36:51 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
 2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests. 
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
 2020-04-24 15:37:01 +01:00
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats. 
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-24 14:30:32 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching 
Merge feature/read-caching branch to master
 2020-04-24 11:47:26 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 10:33:22 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 19:07:31 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811 
Merge feature/REQ-811 into master
 2020-04-20 18:39:37 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards. 
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Mihaela Stoica
66d192b1d8 CP-32985: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Mihaela Stoica
04dc8533e8 CP-32985: Use SM.features field 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-15 14:30:00 +01:00
Darren Matthews
bb560db1dc L10N : Resx resync and translation update 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-04-08 15:56:46 +01:00
Konstantina Chremmou
0188fdc69b Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64 Try handling a connection interruption. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
79bebdb816 Parse the certificate alert body as xml. Accept more ISO 8086 formats. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d CP-32699: New dialog for certificate installation on a server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
52369c9d0d Removed references to SSL certificates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2020-04-02 23:29:54 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
 2020-04-02 10:58:58 +01:00
Konstantina Chremmou
6c5edddda8 CP-32701: Show certificate expiry alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
fc944784b4 CP-32697: Show certificate metadata on the host's General TabPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
8c4af40cf2 Added command and menu item for launching the certificate installation dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
ec1b45cd56 New API class for certificates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
974ece8878 CA-337287: Skip legacy protocol and power-on iLO checks with a warning if the RPU hotfix is missing. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3a35a96530 CP-33294: Remove iLO power on option from XenCenter 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
5406b933fd CA-330308: Rewrote Power-On edit page to fix workflow issues: 
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
888a0555ab CA-337287: Skip vSwitch controller and PV guest checks with a warning if the RPU hotfix is missing. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-27 16:47:25 +00:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-04 12:40:20 +00:00
Konstantina Chremmou
a07c68a345 CA-334756: Allow detaching and reattaching all types of SRs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-03 09:30:00 +00:00
Konstantina Chremmou
00cc547aaf Warning and error corrections. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
d3c5769a70 CP-32844: Check and warn if DVSC is configured when updating or upgrading a pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
4ff42f51f3 Modifications on the NewNetwork wizard (includes CA-192746). 
- NetworkDetails page: reworked it to fix NumericUpdown validation and messages (CA-192746).
- SelectNetworkType page: moved warnings closer to the corresponding network types,
  fixed wrong label enabled state and made enablement logic more explicit.
- All pages: property modernisation and control layout tweaks (mostly margins).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Darren Matthews
57cbf560d5 L10N : Scientific Notation Updates 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-02-28 14:46:07 +00:00
Konstantina Chremmou
7aeb17272b CP-32844: Check and warn if legacy SSL mode is enabled when updating or upgrading a pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Konstantina Chremmou
a36b4062b8 Derive BrokenSR from HostProblem. Removed obsolete classes. Some code modernisation and consolidation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Konstantina Chremmou
bbc826264a Put controls on a TableLayoutPanel. Corrected warning text for standalone host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Darren Matthews
7925bcae27 L10N : Translation and resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-02-26 08:24:06 +00:00
Konstantina Chremmou
1b35a6898f Spelling corrections, mostly for consistency with the docs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-14 14:43:22 +00:00
Konstantina Chremmou
3869d9654d New bindings (includes CP-29452, CA-75634, CA-280976). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-14 14:43:22 +00:00
Konstantina Chremmou
1bcec343f1 Merge remote-tracking branch 'upstream/feature/REQ-803' 2020-02-13 11:43:17 +00:00
Mihaela Stoica
2b0822f3d3 CP-32931: Stop sending licensing information to the licensing server 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-02-11 08:35:42 +00:00
Darren Matthews
07d475b6cd L10N : Translation update and resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-02-03 13:51:15 +00:00
Konstantina Chremmou
24605a3459 Latest C# SDK (defines stockholm release). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-29 12:46:21 +00:00
Konstantina Chremmou
f7391e991b
CA-156873, CP-31105 (partial): Apply common branding and versioning to assemblies; branding refactoring 
Added brand management files and refactored the following brand variables:
* BRANDING_XENSERVER_UPDATE_URL
* BRANDING_PERF_ALERT_MAIL_LANGUAGE_DEFAULT
* BRANDING_SEARCH
* BRANDING_UPDATE
* BRANDING_BACKUP
* BRANDING_LEGACY_PRODUCT_BRAND
* ISO
* BRANDING_VERSION_5_6
* BRANDING_VERSION_6_2
* BRANDING_VERSION_6_0
* BRANDING_VERSION_6_5
* BRANDING_VERSION_7_0
* BRANDING_VERSION_7_1_2
* BRANDING_VERSION_8_0
* BRANDING_VERSION_8_1
* BRANDIND_COPYRIGHT
* BRANDING_COPYRIGHT_2

Also: Try passing the timestamp server as parameter
 2020-01-22 14:47:39 +00:00
Mihaela Stoica
37a3d17667 Add StockholmOrGreater functions 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-01-17 10:56:38 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import. 
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-16 16:26:30 +00:00
Konstantina Chremmou
45fe63ecde Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
efa0fc2fdc CA-187943: Show a warning when a new VM's disks cannot be accommodated on the template or default SR due to lack of space. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
99a3a30fc7 Removed methods that add unnecessary complexity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-08 16:09:36 +00:00
Konstantina Chremmou
9e1ec4cf41 CA-333236: Calculate local time for HotfixEligibilityAlert properties on the UI thread. 
The Title and Description of HotfixEligibilityAlert  involve calculation of local
time which should be done on the UI thread, otherwise the time is not localised
correctly, and additionally the application crashes when dismissing or sorting
these alerts.
Also, stop spamming the logs with each alert removal; code efficiency correction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-01-02 13:15:18 +00:00
Darren Matthews
ce217adc60 L10N : Translation and Resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-12-13 12:49:56 +00:00
Konstantina Chremmou
f459ef5956 CA-331420: Do not refresh the license status on the general tab if the selected object is not a pool/host. 
- Removed AsyncServerTime class as it adds complexity and the risk of
  getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-09 14:39:09 +00:00
Xueqing Zhang
224acb6706 CA-330890: update storage select wazard in XCM 
Signed-off-by: Xueqing Zhang <xueqing.zhang@citrix.com>
 2019-12-09 11:06:25 +00:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
1bf5add051 Typo in property name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-12-06 11:17:46 +00:00
Konstantina Chremmou
423e619101 Updated 3rd party libraries; includes upgrade to PuTTY 0.73 (CP-32362) 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-14 12:14:26 +00:00
Mihaela Stoica
c1dc88a203 Update API bindings 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-13 13:39:27 +00:00
Konstantina Chremmou
072397ac2a Refactoring and deletion of dead code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
5614dafbe6 CA-329742, CA-330301: Logging simplification. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
99572da0fb Corrections to the logging of Win32 exceptions. Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-11-13 12:31:44 +00:00
Darren Matthews
e56a6e5d66 L10N : Translation Update and Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-11-11 15:23:40 +00:00
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated. 
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-08 10:27:49 +00:00
Mihaela Stoica
16eb52eba3 Sort Messages.resx 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-01 15:14:24 +00:00
Mihaela Stoica
326e4d8fe8 CA-329695: Restrict switching the boot mode in the New VM wizard (when created from template or snapshot) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-11-01 15:14:24 +00:00
Konstantina Chremmou
5d8b0f685f Corrected spelling to match the docs. Use en-us spelling. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-30 11:41:44 +00:00
Konstantina Chremmou
dcaf527757 CA-293784: Path and message updates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-30 11:41:44 +00:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-10-21 13:53:59 +01:00
Mihaela Stoica
32981d24f1 CP-32254: Add DMC deprecation banner 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2019-10-18 10:04:51 +01:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter 
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
 2019-10-18 09:56:21 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-14 09:24:36 +01:00
Konstantina Chremmou
6f0a9cae6a CA-293784: updated plugins to use the XenServerPSModule as the snap-in has been retired. 
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-09 13:32:07 +01:00
Konstantina Chremmou
e9d2da082d Prevent XenCenter from crashing if starting it by double-clicking a license file. 
Also, fixed hotkeys and info message on the PasswordRequest dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-10-07 18:00:32 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756 
Merge feature/REQ-756 into master
 2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2019-09-25 15:17:19 +01:00
Konstantina Chremmou
91e2ec3bbe CP-32101: Allow the application to seek help relevant to its release instead of always pointing to help for the latest CR. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 15:02:05 +01:00
Konstantina Chremmou
5244c91658 Help refactoring. 
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 15:02:05 +01:00
Konstantina Chremmou
441734be82 CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool. 
Also, corrected the RBAC permission check after stopping using the conversion plugin.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-25 13:25:26 +01:00
Konstantina Chremmou
3d92246607 The GpuConfiguration list should not be editable. Resize GpuShinyBar Edit button when the text changes. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2019-09-23 13:39:54 +01:00