Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-20 15:29:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,918 Commits 12 Branches 48 Tags 186 MiB
776dfc1a13
Commit Graph

2766 Commits

Author SHA1 Message Date
Danilo Del Busso
6fecc41045
CP-40157: Update friendly name for xapi_open_fds data source 
Also apply string sorting

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-02-01 11:23:37 +00:00
Konstantina Chremmou
f30afbe1d2 XSI-1362/CA-373773: Reworked the logic for selecting boot mode when creating a VM. 
The new logic takes also account of platform:secure-boot=auto.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-31 16:20:13 +00:00
Konstantina Chremmou
439d29d9c3 Don't make server requests in the body of a property. Some minor code smells. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-31 16:20:13 +00:00
Konstantina Chremmou
86c39a559a
Merge pull request #3077 from kc284/pureAsyncAction 
Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions.
 2023-01-31 12:20:47 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-30 16:24:16 +00:00
Konstantina Chremmou
dcbfe2c8fa Corrected user visible copyright and uses of vendor names. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-30 16:24:16 +00:00
Konstantina Chremmou
34ca86fed7 Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-26 00:15:57 +00:00
Konstantina Chremmou
6c3dc7b703 CP-41433: Updated some uses of the company name. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
72f411b950 CP-41433: Legacy console name is not applicable any more. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
ca021b95dd CP-41433: Do not rebrand released versions. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
775f3e49a9 Removed XenCenterVersion from BrandManager. Use the Program.Version instead. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
f7796582c3 CP-41433: Use the product name for the installation path, and the settings/logs parent folder. 
Also, renamed the placeholder because msbuild converts spaces to underscores
and in debug mode the settings path is different from the one expected.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
4d36f67f46 Renamed placeholders so they are easier to understand. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
b2cd71a915 Moved all bracketed placeholders from Branding.resx to XenModel assembly attributes. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
2506e51c9a CP-41433: Moved branded licence strings back to FriendlyNames and replaced bracketed placeholders with string formatting placeholders. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
d9a603629f Moved common assembly properties to a separate file. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
68ef3b10aa CP-41433: Updated branding of About and LegalNotices dialogs. Also: 
- Corrections to the layout of the LegalNoticesDialog and the AboutDialog.
- Dispose the LegaNoticesDialog when the AboutDialog is closed.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-25 12:50:49 +00:00
Konstantina Chremmou
fbe8c60336 Merge remote-tracking branch 'upstream/feature/vtpm' 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Properties/Resources.resx
#	XenModel/Utils/Helpers.Versions.cs
#	XenModel/XenAPI/Pool.cs
 2023-01-10 15:17:23 +00:00
Konstantina Chremmou
e21598d9a0
Merge pull request #3074 from kc284/compression 
CP-41281: Exposed pool option for migration compression
 2023-01-09 16:09:03 +00:00
Konstantina Chremmou
6ce266a4dd Tweaked the titles of some properties and options tabs. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-05 11:39:21 +00:00
Konstantina Chremmou
512d2c217d CP-41281: Exposed pool option for migration compression. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-05 11:39:20 +00:00
Konstantina Chremmou
d46722c6eb Renamed method adding an RbacMethod with key because it was very easy to use it for adding a list of RbacMethods instead. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-04 22:10:18 +00:00
Konstantina Chremmou
7ec581eb95 Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-04 21:27:42 +00:00
Konstantina Chremmou
26e7d4e700 CP-41432: Embed the homepage html files in the project resources. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2022-12-16 00:37:24 +00:00
Konstantina Chremmou
6f41019ad9 CP-41432: Replaced the HomePage .mht files with an html file. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2022-12-16 00:37:24 +00:00
Konstantina Chremmou
6dd175eab0 Fixed exception thrown by actions without an API task (typically actions running synchronous calls). 
Also, catch and log all exceptions and Failures.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2022-12-14 01:00:54 +00:00
Konstantina Chremmou
92e66a2eed
Merge pull request #3068 from kc284/ionic 
Removed dependency on IonicZip.
 2022-12-14 01:00:23 +00:00
Konstantina Chremmou
e74232dc15
Merge pull request #3067 from kc284/xva-verify 
xva_verify: some unused code removal; added cli switch.
 2022-12-14 00:59:48 +00:00
Konstantina Chremmou
a29eb998ae
Merge pull request #3065 from kc284/master 
CP-41048: Add each SR to the SrPicker as soon as its scan finishes, without waiting for the other scans to finish.
 2022-12-05 15:00:01 +00:00
Konstantina Chremmou
1e44d42020 Check for unplugged PBDs when selecting SRs for placing a new disk or importing an XVA. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-30 13:28:44 +00:00
Konstantina Chremmou
e29b8b39d5 Removed dependency on IonicZip. Use the corresponding classes of .NET Framework. 
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-18 16:53:30 +00:00
Konstantina Chremmou
8804038dc4 Removed code for bz2 because it has never been used/exposed in the UI. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-18 12:20:59 +00:00
Konstantina Chremmou
a98d516bbe Removed delegate definitions and some unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-17 14:49:35 +00:00
Konstantina Chremmou
a77f3c3994 Corrections per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-16 17:36:17 +00:00
Konstantina Chremmou
a3569aa875 CP-41048: Add each SR to the SrPicker as soon as its scan finishes, without waiting for the other scans to finish. 
The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-15 16:48:53 +00:00
Konstantina Chremmou
5252272853 Changed the order of some of the initial and final operations. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-14 09:45:34 +00:00
Danilo Del Busso
9c07ed4707
Normalise whitespace in XenConnection.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-10-20 14:26:35 +01:00
Danilo Del Busso
0b5d259745
CA-371356: Add option to prevent resetting pwd prompt function on connection disconnection 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-10-20 14:26:32 +01:00
Danilo Del Busso
77bd034e8d
CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028) 
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs

* CA-359965: Fix miscellaneous formatting issues

* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.

* Use slightly more intuitive name for property; also inverted its logic.

* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.

* Re-arranged classes in file.

* Refactored SrPickerItem:

- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
  to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
  so that the correct size can be used for each storage (thin vs. non-thin provision).

* Correction as per code review and some tweaks to make the checks clearer and more efficient.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-10-11 09:26:54 +01:00
Konstantina Chremmou
a4e7462948 Fixed issue where the version on the update dropdown was not refreshed if a new update was found. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-10-07 13:20:56 +01:00
Konstantina Chremmou
0d70266173 CP-40748: Upgrade log4net to 2.0.15 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-10-04 11:00:12 +01:00
Konstantina Chremmou
74487155fa
Merge pull request #3053 from xenserver/master 
Merge master into feature/vtpm
 2022-09-16 14:27:56 +01:00
Konstantina Chremmou
71a8fde3c6 Wording and layout modifications for clarity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-15 16:26:47 +01:00
Konstantina Chremmou
126bf9131c Use the correct xapi tag for vTPM support. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-13 16:35:32 +01:00
Konstantina Chremmou
8e850b42e3 Updated C# SDK (xapi 22.26.0-1.xs8). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-13 16:35:32 +01:00
Konstantina Chremmou
eedcfbe59d CP-40350: Hide vtpm capability if the feature flag is off. 
Also, some refactoring and addition of null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
9e00a633f3 Create vTPMs as non-unique by default. Added title and description to create/destroy vTPM actions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
bbc4ccdd52 Allow vTPM assignment when creating a VM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
f7d96e21fd UEFI and UEFI secure boot modes are now fully supported, hence remove experimental warning. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm. 
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
7768b71b2a Address review comments. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-31 11:06:40 +01:00
Konstantina Chremmou
7144528f6b CP-39938: Flag a partially applied hotfix with red only if homogeneous application is required. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-22 12:45:37 +00:00
Danilo Del Busso
4f91b8a7e0
Merge pull request #3036 from danilo-delbusso/improvement/RPU_CP-39929 
CP-39929: Improvements on the RPU/Updates wizard
 2022-08-22 11:58:30 +00:00
Konstantina Chremmou
476648636b CP-40642: Hide templates with platform["vtpm"]=true 
Also, some corrections to the template comparer on the NewVM wizard's Template page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 17:11:50 +01:00
Konstantina Chremmou
1a786b38bf CP-39688: Added vTPM manager for creating and removing vTPMs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 17:11:50 +01:00
Konstantina Chremmou
9381388722 CP-40350: New vtpm capability in the server status report. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 15:12:46 +01:00
Konstantina Chremmou
5d75200735 CP-39533: Added indication on the general tab that a vTPM is attached to a VM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 15:12:46 +01:00
Konstantina Chremmou
0daed5eff6 SDK drop exposing new API fields and calls for vTPM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 15:12:46 +01:00
Danilo Del Busso
85e0ffec12
CP-39929: Use 24hrs format for RPU/Update logs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-17 11:40:38 +01:00
Danilo Del Busso
60cd8b9f88
CP-39929: Fix incorrect timestamp shown in RPU/Update wizards 
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 15:57:55 +01:00
Danilo Del Busso
487eba2edf CA-368321: Update Json.NET from 10.0.2 to 13.0.1 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 13:39:48 +01:00
kishore Mengani
1f0452bf8f L10n: Translations updated & Resx sync 
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
 2022-08-12 10:31:53 +01:00
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports. 
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-14 16:00:58 +01:00
Konstantina Chremmou
46cd8308be CP-38582: Corrected version check - last_software_update was added in xapi 22.20.0 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 13:08:59 +01:00
Konstantina Chremmou
3d313f2d31 Updated C# SDK (xapi 22.20.0-1.xs8). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 10:49:06 +01:00
Konstantina Chremmou
6898148466
Merge pull request #3021 from kc284/remove-updates-tab 
CP-39817: Removed updates tab page.
 2022-06-21 10:48:46 +01:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:47:54 +01:00
Konstantina Chremmou
b79eda2d4b Removed unused code around restoring dismissed updates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:43 +01:00
Konstantina Chremmou
fc925ba047 Removed unused CfuAvailabilityCheck class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:43 +01:00
Konstantina Chremmou
414eff9c2f CP-39817: Removed the option to check for server new versions since it is not relevant any longer. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
e5d090d614 CP-39817: Removed the updates tab page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Danilo Del Busso
2798315b46
Merge pull request #3017 from danilo-delbusso/task/last-updated_CP-38583 
CP-38582: Show `Last updated` field in General `TabPage`
 2022-06-15 13:32:36 +01:00
Konstantina Chremmou
8beae03d35 CP-38583: suggested modifications. (And a couple of code smells). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-15 13:05:11 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622 
REQ-622: Citrix Hypervisor Center quick-update mechanism
 2022-06-13 14:57:15 +01:00
Konstantina Chremmou
c66a23f314 CP-39952: Do not ask the user to uninstall the container management supp-pack. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-08 14:01:04 +01:00
Konstantina Chremmou
fd627e687f CP-39933: Show the names of the PV guests preventing upgrade if any are detected. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-08 14:01:04 +01:00
Danilo Del Busso
6d6b0ce5fc
CP-38582: Show Last updated field in General TabPage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-30 09:36:39 +01:00
Konstantina Chremmou
2889b1678d Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:36:08 +01:00
Konstantina Chremmou
cc4d3d9ee7 Extended product version checker to cope with RPM versions. Use xapi_build instead of xapi for version comparisons. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:36:02 +01:00
Konstantina Chremmou
df35684586 Moved version checking methods to a separate file. Use C# naming conventions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DragDropCrossPoolMoveHaltedVMCommand.cs
#	XenAdmin/Commands/DragDropMigrateVMCommand.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/Filters/CrossPoolMigrateCanMigrateFilter.cs
 2022-05-25 11:35:47 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:29:25 +01:00
Konstantina Chremmou
afa21f16a9
Merge pull request #3011 from kc284/CA-366140 
CA-366140: Reverted original solution. Handled error thrown when retrieving datasources.
 2022-05-25 11:04:51 +01:00
Konstantina Chremmou
76738ad91f
Merge pull request #3003 from kc284/drag-drop-3 
CA-294370: Rewrote logic calculating if migration is allowed + some other fixes.
 2022-05-25 11:04:26 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed." 
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
 2022-05-19 11:18:52 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates 
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
 2022-05-17 10:51:10 +01:00
Konstantina Chremmou
8af0184030 Replaced dismiss button with release notes button. Show the application name in the update button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-16 14:08:02 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002) 
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-05-10 12:22:28 +01:00
Konstantina Chremmou
eca6f1d2a4 CA-294370: Rewrote logic calculating if migration is allowed: 
Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:37 +01:00
Konstantina Chremmou
d0fdc5360b
Merge pull request #2980 from danilo-delbusso/bug/rdp-gray_CA-322672 
CA-322672: Do not stop polling for RDP capabilities on VMs
 2022-05-09 15:15:39 +01:00
Konstantina Chremmou
ae7df535c2 Some layout and logic changes so the page looks and behaves more like the other wizard pages with progress bars. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
9b7d502e74 CA-329538: Tell the user to ensure tools are installed if a VM cannot be migrated via drag-and-drop. 
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:16 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
4496d4571d CA-365905 (XSI-1215): Create a temporary file in the target download folder if the latter is in a different drive from the default temporary folder. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:17 +01:00
Konstantina Chremmou
1928cf3db7 CA-366139: Specify which VM lacking the feature could not be migrated during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:01 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-22 14:32:14 +01:00
Danilo Del Busso
d17b99e6b0
CA-322672: Improve comments around RDP status checks 
`data/ts` indicates the VM has RDP enabled

`feature-ts2` is the feature flag indicating that `data/ts` is valid.

`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)

the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-20 12:39:47 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube 
CP-36392: Improvement of sonarqube score
 2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-14 11:45:21 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986) 
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-14 11:36:55 +01:00
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988) 
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-12 12:09:44 +01:00
Konstantina Chremmou
558897740d Reworked instantiation of dummy actions that complete immediately. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 19:43:09 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973) 
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 10:11:33 +01:00
Konstantina Chremmou
04ac8249a6 CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:35 +01:00
Konstantina Chremmou
d2548ae4c0 CP-36392: Do not create an action for changing the master password. 
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:34 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:34 +01:00
Konstantina Chremmou
84ad7054ea Compacted the ActionBase constructors and renamed file to match the class name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method. 
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
492cd4dc88 CP-36392: Do not use a loop for only one iteration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-04 21:07:09 +01:00
Konstantina Chremmou
acc5ed0210 CP-38542: Remove option to disable live patching. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 16:17:22 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page: 
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 16:07:43 +01:00
Konstantina Chremmou
ef86be5347
Merge pull request #2978 from kc284/actions 
Compacted ParallelAction and MultipleAction constructors.
 2022-04-01 16:07:30 +01:00
Konstantina Chremmou
51a400bf70 CA-365717: Two corrections on VM import (from XVA): 
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 11:21:41 +01:00
Konstantina Chremmou
5920691ea4 Merge branch 'master' into feature/REQ-622 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Commands/DisconnectCommand.cs
#	XenAdmin/MainWindow.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2022-03-30 15:17:13 +01:00
Konstantina Chremmou
f5075e8eac Sorted string prior to merging from master (where there are sorted). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-30 15:00:27 +01:00
Danilo Del Busso
c5d2e36564
CA-322672: Do not stop polling for RDP capabilities on VMs 
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:34:09 +01:00
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959) 
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 15:25:32 +01:00
Konstantina Chremmou
81d5c508a1 Refactoring suggested by code review (largely naming conventions). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 13:43:24 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:50:27 +00:00
Konstantina Chremmou
dd978914cf CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:51 +00:00
Konstantina Chremmou
2110607cc1 CA-365143: Correction when changing a VM's memory settings: 
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:40 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:25 +00:00
Konstantina Chremmou
3453e84a0f CA-365223: PVS accelerator is now part of the main install. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:33:03 +00:00
Konstantina Chremmou
25760b2bc6 CP-38814: Minor message improvement. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:32:11 +00:00
Konstantina Chremmou
eb58973497 Fixed crash when retrieving pool info from DR metadata. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:31:48 +00:00
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968) 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-03-10 14:16:13 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-03-03 14:35:30 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s 
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Konstantina Chremmou
a342adc859 CA-364152: Do not calculate completed percentage if there are no actions to run. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-23 12:38:02 +00:00
Danilo Del Busso
a578b6924c CA-361078: Parse OVFs without a Limit element in the vCPUs section 
VMWare OVFs don't export the value

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-18 10:28:38 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953) 
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
 2022-02-18 10:24:33 +00:00
Konstantina Chremmou
8493ee5e90 CA-363819: Fixed issue where VM network usage data were not shown on the Search TabPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 13:17:57 +00:00
Konstantina Chremmou
29189873a3 CA-363610: OVF import: fixed upload of OS fixup ISO. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 13:17:57 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch. 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments. 
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction 
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool. 
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
713a61cead Updated C# SDK (xapi 22.5.0-1.xs8). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-28 14:19:34 +00:00
Danilo Del Busso
2bc25d72d5 CP-38814: Add friendly names to new xapi alerts 
vm_migrated
vm_snapshotted
vm_snapshot_reverted
vm_checkpointed
vm_paused
vm_unpaused

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:46:37 +00:00
Danilo Del Busso
d7f1853562 Bump C# SDK to modified version of xapi 21.3.0/1.xs8 
SDK update does not contain the removal of `evacuate` overloads

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:46:37 +00:00
Konstantina Chremmou
8f9afafb7a Use Tick() when setting both the PercentComplete and the Description to avoid firing OnChanged() twice. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:23:02 +00:00
Konstantina Chremmou
1225e98225 Improved logging and reporting percentage when importing an XVA. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:23:02 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483 
CP-38483: Unbundle putty from  Citrix Hypervisor Center
 2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc CA-362354: Account for non-exe files when saving SSH client path 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Konstantina Chremmou
1e1bb8ddcd Retry sorting .resx strings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-10 14:39:38 +00:00
Darren Matthews
95667d3c80 L10N : Translations 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-01-10 10:13:24 +00:00
Konstantina Chremmou
e129b0b321 Revert "Sort .resx strings" 
This reverts commit 0536fdc05a.
 2022-01-10 10:12:30 +00:00
Danilo Del Busso
0536fdc05a Sort .resx strings 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-10 09:53:58 +00:00
Konstantina Chremmou
879191424c Added hotkeys. Corrected tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
c58d066389 CP-38529: Order strings in Messages.resx alphabetically 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
c6eedbc9f3 CP-38529: Add ssh client strings to Messages.resx 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
41be442413 CP-38529: Add SshConsole enum 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Darren Matthews
702ce7ce0f L10N : Resx resync and Translation Updates 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-01-05 11:38:40 +00:00
Danilo Del Busso
48dd60486a
Merge pull request #2889 from danilo-delbusso/CA-359124 
CA-359124 & CA-360426: Add snapshot VIFs to mapping during cross pool migration & fix VIF mapping in cross pool migration
 2022-01-05 12:13:40 +01:00
Danilo Del Busso
d33f90aaf3
CA-361078: vCPUs count isn't exported/imported within OVFs (#2913) 
* CA-361078: Export max vCPUs when generating OVF

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Populate max vCPUs when importing OVFs

Also keeps backwards compatibility with old import

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Tidy up `SetCPUs` method in `OVF.cs`

Also fixes whitespace using automatic formatter in VS2019

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-04 10:56:16 +00:00
Konstantina Chremmou
f6db9820a1 Retrieve VM snapshots from the cache instead of making an API call to the server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Danilo Del Busso
18595759f7 CA-362018: Improve update notification dismissal message 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-22 12:15:08 +01:00
Danilo Del Busso
16d7f74158
CP-36392: Misc fixes to flagged Bugs (#2907) 
* CP-36392: Add several `null` checks

All were flagged by SonarQube

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `SettingsUpdate`

Added to `XenAdmin`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Collapse useless condition check

Also use pattern matching for type cast

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `ProduceConsumerQueue`

Add to `XenAdmin.Actions`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Add explicit `null` check

While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Replace useless self-assignment with ad-hoc method

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Fix minor formatting issues

Add newline at end of file, and reformat content of if statement

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up latest flagged bugs changes

- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up setter in `ChangeableList.cs`

Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-21 15:53:46 +00:00
Konstantina Chremmou
4a6b2b1e1b
CA-343229: Some modifications: 
- Fixed issue whereby logging out the current user did not log out other
  sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-17 11:08:31 +00:00
Danilo Del Busso
53bf485a14
Replace negative term with log(ging) out user 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-17 11:06:56 +00:00
Danilo Del Busso
4fe544a8e0
CA-343229: Add Helper function to fetch list of logged in subjects 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-17 11:06:53 +00:00
Danilo Del Busso
f7527534e5
CA-343229: Update messages for roles update and user logout 
- Add options for multiple users/subjects
- Let user know they'll also be disconnecting other users

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-17 10:58:49 +00:00
Konstantina Chremmou
c19fb06bf7 CP-38473: Block RPU if the pool has hosts with certificate key length less than 2048 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-16 11:34:23 +00:00
Danilo Del Busso
e169f0bfcc
Amend indentation in changes for CA-359124 & CA-360426 
Refactor all tabs into 4x spaces

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:29:31 +00:00
Danilo Del Busso
7e007cd6ef
CA-360426: Fix VIF to Network mapping during cross pool migration 
Amend mapping so it reflects xapi calls, keeping VIF -> Network mapping and removing Network -> Network mapping

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:27:22 +00:00
Danilo Del Busso
bee0b881d4
CA-359124: Add snapshot VIFs to mapping during cross pool migration 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Add VM snapshots VIFs to network mapping wizard page

This is not entirely necessary, since the mapping in the background is actually Network -> Network.
However, this is closer to the intent of the page.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Tidy up methods in `VmCrossPoolMigrateACtion.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:25:58 +00:00
Konstantina Chremmou
a0a706e9bb Merge branch 'master' into vm-copy-credentials_CA-359712 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/ImportWizard/ImportWizard.cs
#	XenModel/Actions/VM/VMCopyAction.cs
 2021-12-02 22:14:48 +00:00
Konstantina Chremmou
cace3036cf
Merge pull request #2854 from danilo-delbusso/CA-339273 
CA-339273: Add source server/pool info to descriptions of actions that move/copy/import resources
 2021-12-02 21:01:20 +00:00
Konstantina Chremmou
2af5758424
Merge pull request #2842 from danilo-delbusso/master 
CA-350411: Add conditional page control refresh in Import Wizard
 2021-12-02 21:01:00 +00:00
Konstantina Chremmou
e9fa5674c3 CA-339273: Some corrections and minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-02 11:20:49 +00:00
Konstantina Chremmou
eef4e5f995 CP-38427 issue 1: Do not allow enabling TLS verification during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-30 22:46:43 +00:00
Konstantina Chremmou
051c205899 CA-350411 part 2: Add conditional page control refresh in Import Wizard 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 15:35:00 +00:00
Konstantina Chremmou
a327390e4a Further refactoring of CopyVM- and CopyTemplateCommand to reduce repetitive code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
Konstantina Chremmou
e265e86cfa Refactored and renamed class WizardPermission and the code areas using it. Corrections to RBAC messages. Sorted Messages.resx. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898) 
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-11-22 12:02:26 +00:00
Konstantina Chremmou
c2f92aa02a
Merge pull request #2903 from danilo-delbusso/CP-36392-Bugs 
CP-36392: Address statically flagged trivial issues that can cause bugs
 2021-11-17 11:36:48 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
 2021-11-15 15:49:39 +00:00
Danilo Del Busso
e791b70ba7
CP-36392: Move return to new line in Search.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:39 +00:00
Danilo Del Busso
11e90940e0
CP-36392: Simplify Equals method in QueryTypes.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:08 +00:00
Danilo Del Busso
f66216bf7b
CP-36392: Improve readability in Name method of Network's xapi extension 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:18:32 +00:00
Danilo Del Busso
9b4f960336
CP-36392: Check for whitespace-only values in GEtPerfmonDefinitions 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:15:29 +00:00
Danilo Del Busso
5f117e90c5
CP-36392: Add null check in EnableHostAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:21:25 +00:00