Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-27 02:56:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,381 Commits 11 Branches 48 Tags 186 MiB
7a930070af
Commit Graph

6381 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
7a930070af
Merge pull request #3006 from kc284/cli-protocol 
Certificate validation for xe.exe (CP-36392) + a lot of refactoring
 2022-05-19 11:10:18 +01:00
Konstantina Chremmou
74bf6f3ba5 CP-36392: Fixes to sonarqube score. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 11:09:46 +01:00
Konstantina Chremmou
4f7ad4f0f0 Fixed broken build and made some additional L10n corrections to the layout. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 11:09:39 +01:00
Konstantina Chremmou
eb0dc04381 Fixed indentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-18 20:32:36 +01:00
Konstantina Chremmou
02f59946b9 Fixed further code smells as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-18 20:28:08 +01:00
Konstantina Chremmou
c4617240aa Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-18 20:28:08 +01:00
Konstantina Chremmou
5c632a5592 Moved Logger class to its own file. Improved the format of the logged messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-18 11:43:57 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates 
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
 2022-05-17 10:51:10 +01:00
Konstantina Chremmou
dd0c5d4891 CP-36392: Implemented server certificate validation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-10 21:44:29 +01:00
Konstantina Chremmou
a02dfbb07e Reworked error handling. Prevent from showing duplicate output of commands in debug mode. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-10 20:47:27 +01:00
Konstantina Chremmou
90097ece49 Use C# naming conventions for properties. Also, do not provide default username. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-10 19:32:44 +01:00
Konstantina Chremmou
76e0b098b2 Removed undocumented argument "server". Added explicit help switch. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-10 19:24:21 +01:00
Konstantina Chremmou
48f7ffe0d6 Removed unimplemented switch --nossl. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
d23c7f2de6 Removed class ThinCliProtocol. Class Config suffices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
fc13c1e060 Turned magic string into a constant in the Messages class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
2bc75656cf Show the executable's version when using -version. Updated version check during handshake. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
d662af4f8e Removed field thinCliProtocol.dropOut as it was always false. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
aff3d2ad97 Removed code redundancies. Use C# naming conventions for method, classes and enums. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
a1a577fa22 Removed field thinCliProtocol.dProgress because it was not implemented. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
c226316632 Replaced field thinCliProtocol.dExit with direct call to Environment.Exit(). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
b343a97b72 Replaced field thinCliProtocol.dConsoleReadLine with direct call to Console.ReadLine(). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
c992c4b171 Replaced field thinCliProtocol.dConsoleWriteLine with method Logger.Info() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:54 +01:00
Konstantina Chremmou
e31cfaeda5 Removed field thinCliProtocol.dConsoleWrite. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
2bbebce05f Replaced field thinCliProtocol.dGlobalDebugstatic method Logger.Debug() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
0abef1f9ca Replaced field thinCliProtocol.dGlobalUsagewith static method Logger.Usage() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
e2ded395ee Replaced field thinCliProtocol.dGlobalError with static method Logger.Error() 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
113dab51d5 Moved CommandLib classes used only by Xe to the latter project where they belong. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:53 +01:00
Konstantina Chremmou
d0fdc5360b
Merge pull request #2980 from danilo-delbusso/bug/rdp-gray_CA-322672 
CA-322672: Do not stop polling for RDP capabilities on VMs
 2022-05-09 15:15:39 +01:00
Konstantina Chremmou
938de8dcb7 CA-311156: Select the home node prior to starting restoring sessions. 
Because if these are protected by a master password, the application shows
all tabs it constructed with while the password dialog is open.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:38:25 +01:00
Konstantina Chremmou
b172cd0785 Removed private field ToolbarsEnabled: 
It's not worth increasing the complexity of the already complex main form
in order to avoid repeating the setting's name.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:38:25 +01:00
Konstantina Chremmou
404ee1680a Tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
ae7df535c2 Some layout and logic changes so the page looks and behaves more like the other wizard pages with progress bars. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
9b7d502e74 CA-329538: Tell the user to ensure tools are installed if a VM cannot be migrated via drag-and-drop. 
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:16 +01:00
Konstantina Chremmou
6f3895ff10 Minor refactoring: 
Use C# naming conventions; merged nested if blocks; use pattern matching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
429341cdca
Merge pull request #2992 from kc284/console 
Port PR#2941 to master
 2022-04-25 17:06:35 +01:00
Konstantina Chremmou
4496d4571d CA-365905 (XSI-1215): Create a temporary file in the target download folder if the latter is in a different drive from the default temporary folder. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:17 +01:00
Konstantina Chremmou
1928cf3db7 CA-366139: Specify which VM lacking the feature could not be migrated during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:01 +01:00
Konstantina Chremmou
2908547411 Added code owners (default reviewers). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:05:37 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-22 14:32:14 +01:00
Konstantina Chremmou
efb855a6e9 Modifications around VncView disposal: 
- Do not dispose of the activeView when pausing the console (which happens
  when we move away from the console tab.
- When setting a new source, remove and re-add the activeView only when
  it has changed.
- Dispose an unneeded view immediately instead of starting a timer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
5453c0c2ca Corrected toggling console paused state when selecting/deselecting the console tabs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
456cd93db8 A VncView is created for both VNC and RDP, so I don't see why it should be disposed of for VNC only. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
0c1541985c Check for docking should happen outside the VncView's Pause() method. 
Also, use Pascal case for property name to match C# conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
3601ada1f6 Reduced the public interface of the console panel. 
Methods exposing internal functionality like the timers should not be public.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Konstantina Chremmou
4d7457c331 The console panel is not meant to come in focus when the user navigates on the treeview. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Konstantina Chremmou
63c170310d Use Pascal case for method names to match C# conventions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Danilo Del Busso
d17b99e6b0
CA-322672: Improve comments around RDP status checks 
`data/ts` indicates the VM has RDP enabled

`feature-ts2` is the feature flag indicating that `data/ts` is valid.

`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)

the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-20 12:39:47 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube 
CP-36392: Improvement of sonarqube score
 2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-14 11:45:21 +01:00