* Remove credentials controls from `BugToolPageDestination`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Explicitly call dispose in `BugToolPageDestination.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Tidy up code in `BugToolPageDestination.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Move `StatusReportRow` to its own file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Move `ClientSideDataRow` and `HostStatusRow` to own files
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update order of pages in `BugToolWizard`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update action and create row for packaging status report in BugTool wizard
Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Allow for pending `StatusReportAction` to be cancelled
This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Report packaged data amount in `ZipStatusReportAction`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Remove unused `using`s
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Minor layout tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed folder and namespace to match the ones for the other wizards.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed wizard's private fields. Some code efficiency corrections.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Keep the row classes as private within the BugToolPageRetrieveData class.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Removed leftover unused action.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Tidy up status report messages. Use more relevant icon.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Made blurb localisable.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed private fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Simplified the stages of the compilation of the status report.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed row classes again to match the action names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Simplify reporting the progress of the zipping action.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Recursive call is not necessary. Tweaked message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Sort strings
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Update copyright notices
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
---------
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, renamed the placeholder because msbuild converts spaces to underscores
and in debug mode the settings path is different from the one expected.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
- Corrections to the layout of the LegalNoticesDialog and the AboutDialog.
- Dispose the LegaNoticesDialog when the AboutDialog is closed.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs
* CA-359965: Fix miscellaneous formatting issues
* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.
* Use slightly more intuitive name for property; also inverted its logic.
* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.
* Re-arranged classes in file.
* Refactored SrPickerItem:
- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
so that the correct size can be used for each storage (thin vs. non-thin provision).
* Correction as per code review and some tweaks to make the checks clearer and more efficient.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The new name complies with C# conventions and allows distinguishing it from xapi field names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, some corrections to the template comparer on the NewVM wizard's Template page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 updates token name to be more consistent
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 updates token name in missed request
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 reads token name from registry
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
`data/ts` indicates the VM has RDP enabled
`feature-ts2` is the feature flag indicating that `data/ts` is valid.
`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)
the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove changes in string capitalisation
Move capitalisation invariance to checks only
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add remaining `ToLowerInvariant()` calls
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366115: Release the installer when cancelling the installation because of pending tasks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-366116: Use always the same filename for the temporary downloaded installer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Allow to cancel while retrying to download the installer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* Further modifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-39382 adds back in messages lost in merge conflict resolution
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Re-arranged and re-worded controls so that this page looks more like
the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-31587 made checksum comparison case insensitive as well as culture insensative
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* Fixes not null assertion
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* Merges internal classes to be in same file
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-361078: Export max vCPUs when generating OVF
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-361078: Populate max vCPUs when importing OVFs
Also keeps backwards compatibility with old import
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-361078: Tidy up `SetCPUs` method in `OVF.cs`
Also fixes whitespace using automatic formatter in VS2019
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Add several `null` checks
All were flagged by SonarQube
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Specify `namespace` for `SettingsUpdate`
Added to `XenAdmin`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Collapse useless condition check
Also use pattern matching for type cast
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Specify `namespace` for `ProduceConsumerQueue`
Add to `XenAdmin.Actions`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Add explicit `null` check
While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Replace useless self-assignment with ad-hoc method
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Fix minor formatting issues
Add newline at end of file, and reformat content of if statement
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Tidy up latest flagged bugs changes
- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Tidy up setter in `ChangeableList.cs`
Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Fixed issue whereby logging out the current user did not log out other
sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Add options for multiple users/subjects
- Let user know they'll also be disconnecting other users
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
CA-359124: Add VM snapshots VIFs to network mapping wizard page
This is not entirely necessary, since the mapping in the background is actually Network -> Network.
However, this is closer to the intent of the page.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
CA-359124: Tidy up methods in `VmCrossPoolMigrateACtion.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-359809 improved illegal character message
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 cleared whitespace, improve code readability
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 implemented reviewer comments.
Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 improved string localisation, Code tidy
Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 changed can not to cannot
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
