Also, renamed the placeholder because msbuild converts spaces to underscores
and in debug mode the settings path is different from the one expected.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
- Corrections to the layout of the LegalNoticesDialog and the AboutDialog.
- Dispose the LegaNoticesDialog when the AboutDialog is closed.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs
* CA-359965: Fix miscellaneous formatting issues
* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.
* Use slightly more intuitive name for property; also inverted its logic.
* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.
* Re-arranged classes in file.
* Refactored SrPickerItem:
- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
so that the correct size can be used for each storage (thin vs. non-thin provision).
* Correction as per code review and some tweaks to make the checks clearer and more efficient.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The new name complies with C# conventions and allows distinguishing it from xapi field names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, some corrections to the template comparer on the NewVM wizard's Template page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 updates token name to be more consistent
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 updates token name in missed request
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CP-39720 reads token name from registry
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
`data/ts` indicates the VM has RDP enabled
`feature-ts2` is the feature flag indicating that `data/ts` is valid.
`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)
the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove changes in string capitalisation
Move capitalisation invariance to checks only
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add remaining `ToLowerInvariant()` calls
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366115: Release the installer when cancelling the installation because of pending tasks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-366116: Use always the same filename for the temporary downloaded installer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Allow to cancel while retrying to download the installer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* Further modifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-39382 adds back in messages lost in merge conflict resolution
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Re-arranged and re-worded controls so that this page looks more like
the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-31587 made checksum comparison case insensitive as well as culture insensative
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* Fixes not null assertion
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* Merges internal classes to be in same file
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-361078: Export max vCPUs when generating OVF
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-361078: Populate max vCPUs when importing OVFs
Also keeps backwards compatibility with old import
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-361078: Tidy up `SetCPUs` method in `OVF.cs`
Also fixes whitespace using automatic formatter in VS2019
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Add several `null` checks
All were flagged by SonarQube
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Specify `namespace` for `SettingsUpdate`
Added to `XenAdmin`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Collapse useless condition check
Also use pattern matching for type cast
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Specify `namespace` for `ProduceConsumerQueue`
Add to `XenAdmin.Actions`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Add explicit `null` check
While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Replace useless self-assignment with ad-hoc method
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Fix minor formatting issues
Add newline at end of file, and reformat content of if statement
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Tidy up latest flagged bugs changes
- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-36392: Tidy up setter in `ChangeableList.cs`
Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Fixed issue whereby logging out the current user did not log out other
sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Add options for multiple users/subjects
- Let user know they'll also be disconnecting other users
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
CA-359124: Add VM snapshots VIFs to network mapping wizard page
This is not entirely necessary, since the mapping in the background is actually Network -> Network.
However, this is closer to the intent of the page.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
CA-359124: Tidy up methods in `VmCrossPoolMigrateACtion.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-359809 improved illegal character message
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 cleared whitespace, improve code readability
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 implemented reviewer comments.
Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 improved string localisation, Code tidy
Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 changed can not to cannot
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
Removed ApplyLicenseEditionCommand as it was unnecessary (there was no
button/menuitem calling it). Use the ApplyLicenseEditionAction instead.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
`reaonly` should be used for items that can't be modified. The changed collections/arrays are modified, so `readonly` is misleading
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Mixture of correctly implementing `Trim()` calls, and removing calls that generate useless ephemeral variables.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Also, no need to use a different message for single and multiple VMs or templates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-34231: Replace negative language with `block list` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `stop` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `freezing` in code
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run/ran` in code comments
Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
* CA-34231: Replace negative language with `run` in Command.cs Run method
Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/TabPages/GeneralTabPage.cs
* CA-34231: Replace negative language with `run` in Command.cs CanRun method
Used Resharper rename utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/DRConfigureCommand.cs
# XenAdmin/Commands/DRDryrunCommand.cs
# XenAdmin/Commands/DRFailbackCommand.cs
# XenAdmin/Commands/DRFailoverCommand.cs
# XenAdmin/Commands/DisasterRecoveryCommand.cs
# XenAdmin/Commands/VMGroupCommand.cs
* CA-34231: Replace negative language with `run` in Command.cs RunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Command.cs
Also applied to related symbols. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods named CanRun
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/CrossPoolMigrateCommand.cs
* CA-34231: Replace negative language with `run` in remaining Run methods
Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Commands folder
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder
Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
* CA-34231: Replace all remaining negative language with `run` in code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/Controls/WlbRecommendations.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
# XenModel/WLB/WlbScheduledTask.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in code strings
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative language with `supporter` in .resx files
Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in CFUValidator code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CFUValidator.cs
* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method
Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
# XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resources
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/EvacuateHostDialog.resx
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resource files.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.resx
* CA-34231: Rename missing language references for change to `coordinator`
Misc files were not saved before last commits.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/HACommand.cs
# XenAdmin/TabPages/AdPage.cs
# XenModel/Actions/Network/CreateBondAction.cs
# XenModel/Actions/Network/NetworkAction.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`
Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
# XenAdmin/Commands/HACommand.cs
* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/TabPages/GeneralTabPage.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
# XenAdmin/XenSearch/Columns.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Actions/Network/CreateBondAction.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
# XenModel/Messages.resx
* CA-34231: Rename dialogs to replace negative connotations with `main`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`
Also updated its resx file. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Update class names in HelpManager.resx
Following renaming of main password dialog. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `Metadata.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`
Used ReSharper renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`
Used ReSharper
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language in solution
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove commented out code in VNCGraphicsClient.cs
Code has only been improved partially as it's not strictly relevant to the PR
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend negative word replacement in XSVNCScreen.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Simplify debug call formatting in NewPoolDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Add code mistakenly removed in MainWindow.cs
Removed as part of `f155f9c8`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Revert renaming of constant related to Windows' API
Considered external to CH Center
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`
Previous ALT+<key> hotkey was conflicting with CreatePool
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs
Not relevant to the PR, but the change is small enought to no need extra testing
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend typo in PoolJoinRules.cs
supporer -> supporter
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`
Variables and methods XenAPI-Extensions were mistakenly skipped
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`
This is only used to format the string
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`
Done in order to fix merge conflict into master
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend misc negative language renaming typos
`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Hide GPU page if the host has no GPU capability
* Hid GPU page in PropertiesDialog
* Hid GPU page in NewVMWizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Move GPU availability check to Helpers class
* Switch from field to method based check
* Update affected logic
* Remove rubric toggle in PopulatePage when GpuEditPage is shown
* Hide AddVGPUDialog when GpusAvailable returns false
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Remove missing GPUs strings in Messages.resx
* GPU_RUBRIC_NO_GPUS_POOL
* GPU_RUBRIC_NO_GPUS_SERVER
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Disable combobox in AddVGPUDialog when there are no GPUs
Avoids exception being thrown if user tries to select empty first item
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Amend position of GPU availability check
Moved since gpuCapability is used in the Finish method of the wizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Remove unecessary null checks in Helpers method
The Cache and its properties (e.g. GPU_groups) are readonly and initialised as empty.
The API object properties that are ref lists (g.PGPUs, g.supported_VGPU_types) are also initialised as empty and are demarshalled by the SDK as empty if they have no values.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* The solution libraries do not need a config file like the applications.
In fact the config file of XenAdminTests was mostly an unneeded copy of the
XenAdmin app.config; the NUnit setting has moved to the AssemblyInfo in NUnit3.
* Removed unused XenOvfApi settings.
* The constants in the Settings were largely not configurable, hence I moved them into the code.
The ones marked with TODO will be revisited within CP-32779.
* Removed config file from library XenOvfApi. Restored broken cryptography algorithm lookup.
(The list of algorithms had been removed from the Settings within the fix to CA-350574).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also moved initial description update from base constructor call to body of subclass constructor.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* DataSet field Uuid is not really a uuid. Renamed to Id to avoid misunderstandings.
* Renamed properties DataSet.Type and DataSourceItem.DataType to Category. The old name was not reflecting what they were.
* Renamed property DataSet.TypeString to DataSet.DataSourceName so it reflects better what it is.
* Renamed property DataSet.Name to DataSet.FriendlyName for clarity. Removed duplicate string.Format() call.
* The DataSourceItem.Uuid is not really a uuid. Renamed it to Id to avoid misunderstandings. Also, compacted DataSourceItem constructors.
* Removed unused and duplicate properties.
- DataKey.Hide was unused. Once removed, DataSet.Deselected was unused, hence was also removed.
- Dataset.Draw was duplicating DataSet.Show, hence was removed.
- DataSet.NeverShow is not necessary, DataSet.Hide can be used both for datasources
that should not be shown at all as well as datasources that are wrong for this object.
* Made DataSet.FriendlyName a get-only property and compacted repetitive code.
* Use the Helpers regular expressions for assigning the datasource category.
* Removed id from the DataSet constructor parameters. It can be constructed from the XenObject and the datasource name.
* Compacted the code for readability (it was difficult to follow the build of the URIs).
Also, removed use of Helper.GetUuid to avoid the use of reflection. Minimised casts.
* CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name.
- Also, merged static method DataSet.Create into the DataSet constructor.
- Minor restructuring of the ArchiveMaintainer file (moved all private fields
and properties closer together).
- Added new resource file so the units can be separated from Messages.
- Also, merged static method DataSet.Create into the DataSet constructor.
- Minor restructuring of the ArchiveMaintainer file (moved all private fields
and properties closer together).
- Added new resource file so the units can be separated from Messages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Fixed broken test due to missing static images.
- Fixed NUnitEngineExeption thrown due to StackOverflowException when searching
for non-existing assembly (due to wrong branding).
- Commented out ignored tests causing the overall NUnit result to be reported as
Warning instead of Passed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This allows removal of DelegatedAsyncAction.ResultObject, which might lead to complicated implementations.
Also: some refactoring of the other WLB retrieve recommendations actions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
