Commit Graph

147 Commits

Author SHA1 Message Date
Konstantina Chremmou
f12bb5a15e Code tidy: the TreeSearchBox should be notifying the MainWindow via an event when
the search mode has changed; the latter should not be accessible from outside the
class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-22 17:56:34 +01:00
Konstantina Chremmou
f2e4f61732 MainWindow code tidy: Use the property SelectionManager where possible instead of
the private field selectionManager.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-22 17:25:12 +01:00
Konstantina Chremmou
60bca4d1df MainWindow code tidy: removed methods constructing ToolStripMenuItems as unecessary.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-22 16:48:16 +01:00
Konstantina Chremmou
a516796006 Main window code tidy: separated calls refreshing the header and tab pages from
the call refreshing the treeview.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-22 10:55:32 +01:00
Konstantina Chremmou
6a9d87c6f1 MainWindow tidy up: use existing method to launch the AboutBox rather than reimplementing
the same code. Use a CommandToolStripItem to launch the BugToolWizard like we do
for other wizards. Added overload for the MainWindowCommandInterface.ShowForm
method which allows to pass arguments to a wizard constructor.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-21 17:13:23 +01:00
Konstantina Chremmou
9f16bdd963 Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-08-21 16:04:13 +01:00
Mihaela Stoica
abd198e1eb CA-108512: Fixed the issue when Connect to Server dialog box becomes unresponsive when invalid password is tried during reconnect to host.
The error occurred when user specified a second wrong password. If the same wrong password was specified again and again, it didn't trigger it. This was due to an error in code where we didn't use the updated password in the second connection attempt.
Fixed by changing the code to use the updated username and password combination for every login attempt.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-08-19 16:59:41 +01:00
Konstantina Chremmou
620e268a6b CP-5750: Avoid creating new ToolstripMenuItems every time an action is updated,
but choose instead which ones to display.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-19 13:17:33 +01:00
Konstantina Chremmou
4b6871d4af Merge remote-tracking branch 'origin/master' 2013-08-16 17:44:39 +01:00
Konstantina Chremmou
59539af921 CA-95272: Fixed several memory leaks coming from undisposed pens and brushes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-16 17:43:57 +01:00
Konstantina Chremmou
7a261bb2ed CP-5750: Aesthetic: added border to the top toolstrip. Also removed unused tooltip.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-16 15:10:42 +01:00
Mihaela Stoica
83ff32cbbc CA-108174 Fixed Uncaught exception while creating new SR after the ISO drop down box was created in the New VM Wizard
- added code to deregister event handlers when the ISO drop down box is disposed; plus some code tidy-up

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-08-16 13:34:17 +01:00
Konstantina Chremmou
f9b8624114 CP-5750: Currently the license alert is generated only when the license is due to
expire soon, therefore assign severity level 3 (warning).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-16 13:25:46 +01:00
Konstantina Chremmou
b2ddebef49 CP-5750: Updated existing LogTab tests to reflect gui changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-16 12:57:39 +01:00
Konstantina Chremmou
d020fd7163 CA-107909: Fixed layout issue occurring in the EN on SC XenCenter.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-14 17:30:22 +01:00
Konstantina Chremmou
b54b30a150 CA-103290: When the alert filters are on enable the use to choose whetehr they want
to export all or only the shown alerts (functionality similar to the DismissAll button).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-14 17:12:39 +01:00
Konstantina Chremmou
6cbea8adcc CA-103347: Improved the messages on the confirmation dialogs for the "Dismiss All"
alerts operations (when filters are on/off). Corrected button enabled state.
Other minor code improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-14 16:59:25 +01:00
Konstantina Chremmou
f9a9fb122c CP-5750: Separated Cancelled from Failed actions. Fixed control invoke issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 17:08:04 +01:00
Konstantina Chremmou
d9c7b09e84 Conversion from British to American english.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 11:36:21 +01:00
Konstantina Chremmou
2a1d8893ab CP-5750: Added label to indicate when filters are on/off. Changed the order of
the items on the actions split button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 11:04:08 +01:00
Konstantina Chremmou
67d15dcca5 CP-5750: Moved capping of event numbers to a more relevant place and corrected logic
to remove the oldest items first and fire an event when doing so.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 10:52:15 +01:00
Konstantina Chremmou
86c6950aeb CP-5750: Implemented event filtering by status, location and date.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 10:15:52 +01:00
Konstantina Chremmou
427ecd49ac CP-5750: Implemented ability to sort events. Set vertical scrollbars for the gridview.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-12 14:00:29 +01:00
Konstantina Chremmou
6950123da0 Code efficiency: compacted methods retrieving IXenObjects from VirtualTreeNodes
because certain checks were run more than once.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-10 13:25:35 +01:00
Konstantina Chremmou
4dac13b768 Removed unused methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-10 13:17:14 +01:00
Konstantina Chremmou
c2333b03b1 CP-5750: Initial implementation of the new Events DataGridView.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-10 12:29:36 +01:00
Konstantina Chremmou
23d10bd513 CP-5750: Do not filter the Log tab entries according to the selection on the treeview.
For the time being show all entries. New filtering according to the entry location
will be implemented in a future commit.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:41 +01:00
Konstantina Chremmou
16ba4699db CP-5750: Removed Clear button. Initial implementation of top ToolStrip and
DismissAll/DismissSelected split button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:39 +01:00
Konstantina Chremmou
62586ef89c CP-5750: Removed ActionType; the actions should be categorised by status (in progress,
succeeded, failed; cancelled at the moment counts as failed, we may need to distinguish
in future). As a consequence the filter checkboxes from the top of the Log tab
were removed and some temporary changes were made to the drawing of action rows
(the controls will change completely in a subsequent commit).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:38 +01:00
Konstantina Chremmou
38ab6b8ffa CP-5750: When a License warning is generated, create an alert rather than an Action.
Removed ActionType.Alert. Removed Alerts checkbox from the Log tab.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:36 +01:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00
Konstantina Chremmou
eb1dd68a28 CP-5750: Code tidy. Comment improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:31 +01:00
Konstantina Chremmou
58e9b1c822 CA-113431: Display a warning when a pool has a mixture of free hosts with license
expiry dates that are more than 30 days apart (not ideal, but safest solution for
the case of a mixture of free and free but expiring soon hosts.)

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:18:15 +01:00
Konstantina Chremmou
35226d65dd CA-113319: LicenseManager was showing confusing licensing information.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:17:24 +01:00
Konstantina Chremmou
accf445584 CA-112931: Fixed issue where the "Activate Free XenServer” button was disabled
when selecting multiple hosts on the Licence manager.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:46:05 +01:00
Konstantina Chremmou
fb2418da63 Try enabling unit tests for branches other than trunk.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:45:53 +01:00
Konstantina Chremmou
db1aacaa85 The parameter 'force' was added to Host.apply_edition in Clearwater, not Augusta.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:45:12 +01:00
Konstantina Chremmou
20770553c6 CP-5752: Renamed "Add Group" button to "More", changed its image and moved it closer
to the other grouping buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:47 +01:00
Konstantina Chremmou
f3855500b4 CP-5752: Renamed default search. Use Action delegate instead of EventHandler when
there is no need to pass in parameters when the event is fired. Minor code tidy.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:45 +01:00
Konstantina Chremmou
f8044cde8e CP-5752: Removed the SearchOptions DropDownButton and moved the functionality of its items to separate buttons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:43 +01:00
Konstantina Chremmou
1ee173d349 CP-5752: Moved ExportSearch method from the MainWindow.cs to the Search tabpage where it belongs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:42 +01:00
Konstantina Chremmou
8f51089efe CP-5752: Use Action delegate instead of EventHandler when there is no need to
pass in parameters when the event is fired. Moved QueryElement.Dispose method
from the Designer.cs to the main file (it needs visibility since it contains more
code than the autogenerated method).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:40 +01:00
Konstantina Chremmou
03d5053073 CP-5752: Moved Save Search functionality from the SearchOptions dropdown menu to
a Save button in the Searcher panel. Moved collapse Searcher panel functionality
from the SearchOptions dropdown menu to a Close button in the panel. Use new
Expanded property to query the state of the Searcher panel (instead of Visible).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:38 +01:00
Konstantina Chremmou
014de807a3 CP-5752: Moved ShowColumns functionality from the SearchOptions dropdown menu to
a button at the top left of the search output panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:36 +01:00
Sorin Sbarnea
59723074a7 build scripts update: replaced some hardcoded repository names with a variable so it will work the same on git and hg. Expecting no effects here but it will minimise the differences between trunk and older branches. 2013-07-30 12:42:43 +01:00
Adrian Jachacy
16429b4707 CA-108795: Fix TestDelay tests.
Removed TestDelays tests from UpdateManagerTests.cs

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-26 14:36:18 +01:00
Adrian Jachacy
edce7529f6 CA-109273: [DELL-194] Throws exception if Download & Install used on host in maintenance mode.
1. Added additional check to DownloadAndInstall method in ManageUpdatesDialog.cs: will proceed to the prechecks page in the Install Update Wizard only when there are selected servers on the previous page.
2. Modified code to allow hotfix installation when the host is in maintenance mode; however the host cannot be upgraded when in maintenance mode.
3. Modified test to reflect changes described above.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-25 09:44:52 +01:00
Adrian Jachacy
d68db5ffaf Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-24 14:06:55 +01:00
Adrian Jachacy
b4d282577b CA-111876: XenCenter displays an empty Summary page on cancelling the reattachment of HBA SR.
Moved LMVoHBA related code from UpdateWizardContent() method to CanShowLVMoHBASummaryPage() method which is called from RunNextPagePrecheck() method now: the code prepares all lvmohbaSrDescriptors for each LUN selected by the user and executes RunFinalAction() method.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-24 13:34:21 +01:00
Stephen Turner
213f5f9591 CA-111829: Only sets the restart priority on some of the VMs when enabling HA or modifying HA configuration. 2013-07-24 13:28:32 +01:00